From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: chasel.chiu@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Tue, 13 Aug 2019 21:10:52 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2019 21:10:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,383,1559545200"; d="scan'208";a="170605161" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by orsmga008.jf.intel.com with ESMTP; 13 Aug 2019 21:10:49 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by PGSMSX105.gar.corp.intel.com ([169.254.4.133]) with mapi id 14.03.0439.000; Wed, 14 Aug 2019 12:10:48 +0800 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" , "Gao, Liming" CC: "rfc@edk2.groups.io" , "Feng, Bob C" , "Cetola, Stephano" , "Laszlo Ersek (lersek@redhat.com)" , "afish@apple.com" , "Kinney, Michael D" Subject: Re: [edk2-devel] [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag. Thread-Topic: [edk2-devel] [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag. Thread-Index: AdVQ4WroZfB3mdj6SpKK06WHGB09pwA+07uQ///KqAD//tkX4A== Date: Wed, 14 Aug 2019 04:10:48 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5045D885@PGSMSX111.gar.corp.intel.com> References: <3C3EFB470A303B4AB093197B6777CCEC5045B801@PGSMSX111.gar.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D02AD@SHSMSX104.ccr.corp.intel.com> <20190813182958.GE29255@bivouac.eciton.net> In-Reply-To: <20190813182958.GE29255@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTgyZWIyODYtOGMzNi00N2RkLTk3NzctN2Y4ZmUwZmFkMWY4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTnd4WUNNT2tyVHBPV3ZoTEJTN01sSXJoSmFqTjFcL3h4XC9IVlFJZ3FYdWMrZk9ZTlppeWdCWUFKSDVaK0xvVVNvIn0= x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, Thanks for the valuable feedbacks and suggestions. I will re-write script and re-send code review. Regards, Chasel > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Le= if > Lindholm > Sent: Wednesday, August 14, 2019 2:30 AM > To: Gao, Liming > Cc: Chiu, Chasel ; rfc@edk2.groups.io; Feng, Bob = C > ; devel@edk2.groups.io; Cetola, Stephano > ; Laszlo Ersek (lersek@redhat.com) > ; afish@apple.com; Kinney, Michael D > > Subject: Re: [edk2-devel] [RFC] BZ 2067 BaseTools/Scripts: Add > GetUtcDateTime.py for edk2-stable201908 stable tag. >=20 > I am not fundamentally opposed to merging a simple script that does not = affect > other code in the tree. >=20 > *But* the fact that we have multiple occurrences of this this time aroun= d *is* > a bit of a concern for me. Yes, they won't affect the workings of anythi= ng else > as part of the release. But they will not have had any chance to be actu= ally used > by others. >=20 > For this particular script, I am also not very keen on the implementatio= n. It > manually parses the command line and prints usage instead of using argpa= rse. > And it contains the sys.exit(Main()) antipattern, which does not play we= ll with > Python3 asynchronous i/o (and hence is a bad habit to get into). >=20 > Since this script is truly trivial, I am OK for it to be included *if* i= t is rewritten > using argparse and not calling sys.exit. >=20 > Best Regards, >=20 > Leif >=20 > On Tue, Aug 13, 2019 at 01:42:23PM +0000, Gao, Liming wrote: > > This is a small helper script. I am OK to add it for edk2-stable201908= stable > tag. > > > > Thanks > > Liming > > From: Chiu, Chasel > > Sent: Monday, August 12, 2019 3:45 PM > > To: rfc@edk2.groups.io > > Cc: Gao, Liming ; Feng, Bob C > > ; devel@edk2.groups.io > > Subject: [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for > edk2-stable201908 stable tag. > > > > > > Hello, > > > > I would like to add below simple script to 201908 stable tag, review w= as sent > on August 8th: > > > > A script that can return UTC date and time in ascii format which is co= nvenient > for patching build time information in any binary. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2067 > > Patch: https://edk2.groups.io/g/devel/topic/32797962#45177 > > > > Thanks! > > Chasel > > >=20 >=20