From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: chasel.chiu@intel.com) Received: from mga17.intel.com (mga17.intel.com []) by groups.io with SMTP; Fri, 16 Aug 2019 18:17:14 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Aug 2019 18:17:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,395,1559545200"; d="scan'208";a="328836468" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by orsmga004.jf.intel.com with ESMTP; 16 Aug 2019 18:17:12 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by PGSMSX108.gar.corp.intel.com ([169.254.8.125]) with mapi id 14.03.0439.000; Sat, 17 Aug 2019 09:17:11 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Gao, Liming" , "Desimone, Nathaniel L" , "Kinney, Michael D" , "Sinha, Ankit" Subject: Re: [edk2-platforms][PATCH V1 37/37] Add WhiskeylakeOpenBoardPkg to global build config and documentation Thread-Topic: [edk2-platforms][PATCH V1 37/37] Add WhiskeylakeOpenBoardPkg to global build config and documentation Thread-Index: AQHVVJEgocopj8D2a0OYpOPMYqbO3ab+idMg Date: Sat, 17 Aug 2019 01:17:10 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5046246E@PGSMSX111.gar.corp.intel.com> References: <20190817001603.30632-1-michael.a.kubacki@intel.com> <20190817001603.30632-38-michael.a.kubacki@intel.com> In-Reply-To: <20190817001603.30632-38-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDRhZTI2MTctZTgyOS00YjZhLThjZWItNmVkMzZmOGVhMjdkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQXBrWDZmMm1IWGJrcmJJc2g5RkNDazdKdjRFTWxXYzRKQktmb3VSZ3crcHMxcDJSamxNUk9mWk9DXC9EWHA5YnQifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Gao, Liming ; Desimone, > Nathaniel L ; Kinney, Michael D > ; Sinha, Ankit > Subject: [edk2-platforms][PATCH V1 37/37] Add WhiskeylakeOpenBoardPkg to > global build config and documentation >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2083 >=20 > * Adds the WhiskeylakeURvp board as a build option in build.cfg so it > it is listed as a valid build target. > * Updates relevant Readme.md files to include instructions for > WhiskeylakeOpenBoardPkg. > * Adds the maintainers for WhiskeylakeOpenBoardPkg to maintainers.txt. >=20 > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Liming Gao > Cc: Nate DeSimone > Cc: Michael D Kinney > Cc: Ankit Sinha > Signed-off-by: Michael Kubacki > --- > Maintainers.txt | 5 +++ > Platform/Intel/Readme.md | 44 +++++++++++++------- > Platform/Intel/build.cfg | 4 +- > Readme.md | 1 + > 4 files changed, 38 insertions(+), 16 deletions(-) >=20 > diff --git a/Maintainers.txt b/Maintainers.txt index bc8cbd6458..b16432bf= 87 > 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -98,6 +98,11 @@ M: Shifei A Lu > M: Xiaohu Zhou > M: Isaac W Oram >=20 > +Platform/Intel/WhiskeylakeOpenBoardPkg > +M: Chasel Chiu > +M: Michael Kubacki > +M: Nate DeSimone > + > Platform/Intel/Tools > M: Bob Feng > M: Liming Gao > diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index > 00f42985a2..aaf6ef4d3e 100644 > --- a/Platform/Intel/Readme.md > +++ b/Platform/Intel/Readme.md > @@ -53,9 +53,10 @@ A UEFI firmware implementation using MinPlatformPkg > is constructed using the fol >=20 >=20 > ## Board Support > +* The `ClevoOpenBoardPkg` contains board implementations for Clevo > systems. > * The `KabylakeOpenBoardPkg` contains board implementations for Kaby > Lake systems. > * The `PurleyOpenBoardPkg` contains board implementations for Purley > systems. > -* The `ClevoOpenBoardPkg` contains board implementations for Clevo > systems. > +* The `WhiskeylakeOpenBoardPkg` contains board implementations for > Whiskey Lake systems. >=20 > ## Board Package Organization > The board package follows the standard EDK II package structure with the > following additional elements and guidelines: > @@ -189,7 +190,12 @@ return back to the minimum platform caller. > | | | |---build_config.cfg: BoardM= tOlympus > specific > | | | | build = settings, environment > variables. > | | | |---build_board.py: Optional= board-specific > pre-build, > - | | | | build, p= ost-build and clean > functions. > + | | | build, p= ost-build and clean > functions. > + | | | > + | | |------WhiskeylakeOpenBoardPkg > + | | | |------WhiskeylakeURvp > + | | | |---build_config.cfg: Whiske= ylakeURvp > specific build > + | | | settin= gs environment > variables. > |------FSP > >=20 > @@ -222,19 +228,6 @@ Users can also flash the UEFI firmware image to the > highest area of the flash re >=20 > ### **Known limitations** >=20 > -**KabylakeOpenBoardPkg** > -1. This firmware project has only been tested on the Intel KabylakeRvp3 > board. > -2. This firmware project has only been tested booting to Microsoft Windo= ws > 10 x64 with AHCI mode and Integrated Graphic > - Device. > -3. The Windows build was tested on Windows 10 with Microsoft Visual Stud= io > 2015. > -4. The Linux build was tested on Ubuntu 16.04.5 LTS with GCC version 5.4= .0. > -5. The build was tested with NASM version 2.11.08. > - > -**PurleyOpenBoardPkg** > -1. This firmware project has only been tested on the Microsoft MtOlympus > board. > -2. This firmware project has only been tested booting to Microsoft Windo= ws > Server 2016 with NVME on M.2 slot. > -3. This firmware project build has only been tested using the Microsoft = Visual > Studio 2015 compiler. > - > **ClevoOpenBoardPkg** > 1. Currently, support is only being added for the N1xxWU series of board= s. > 2. The Windows build was tested on Windows 10 with Microsoft Visual Stud= io > 2015 compiler. > @@ -244,6 +237,27 @@ Users can also flash the UEFI firmware image to the > highest area of the flash re 6. The firmware project applies to all Clev= o > supported board configurations but is only being tested on System 76 Gala= go > Pro devices. >=20 > +**KabylakeOpenBoardPkg** > +1. This firmware project has only been tested on the Intel KabylakeRvp3 > board. > +2. This firmware project has only been tested booting to Microsoft > +Windows 10 x64 with AHCI mode and Integrated Graphic > + Device. > +3. The Windows build was tested on Windows 10 with Microsoft Visual Stud= io > 2015. > +4. The Linux build was tested on Ubuntu 16.04.5 LTS with GCC version 5.4= .0. > +5. The build was tested with NASM version 2.11.08. > + > +**PurleyOpenBoardPkg** > +1. This firmware project has only been tested on the Microsoft MtOlympus > board. > +2. This firmware project has only been tested booting to Microsoft Windo= ws > Server 2016 with NVME on M.2 slot. > +3. This firmware project build has only been tested using the Microsoft = Visual > Studio 2015 compiler. > + > +**WhiskeylakeOpenBoardPkg** > +1. This firmware project has only been tested on the Intel WhiskeylakeUR= vp > board. > +2. This firmware project has only been tested booting to Microsoft > +Windows 10 x64 with AHCI mode and Integrated Graphic > + Device. > +3. The Windows build was tested on Windows 10 with Microsoft Visual Stud= io > 2015. > +4. The Linux build was tested on Ubuntu 16.04.5 LTS with GCC version 5.4= .0. > +5. The build was tested with NASM version 2.11.08. > + > ### **Planned Activities** > * Replace the batch build scripts with cross-platform Python build scrip= ts. > * Publish a Minimum Platform specification to describe the architecture = and > interfaces in more detail. > diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index > fc6e4fe824..b6d32ada49 100644 > --- a/Platform/Intel/build.cfg > +++ b/Platform/Intel/build.cfg > @@ -51,6 +51,8 @@ NUMBER_OF_PROCESSORS =3D 0 >=20 > [PLATFORMS] > # board_name =3D path_to_board_build_config.cfg > +BoardMtOlympus =3D > PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg > KabylakeRvp3 =3D KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > N1xxWU =3D ClevoOpenBoardPkg/N1xxWU/build_config.cfg > -BoardMtOlympus =3D PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg > +WhiskeylakeURvp =3D > +WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg > + > diff --git a/Readme.md b/Readme.md > index 1befd0b544..e4f211eee6 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -228,6 +228,7 @@ they will be documented with the platform. > * [Clevo](Platform/Intel/ClevoOpenBoardPkg) > * [Kaby Lake](Platform/Intel/KabylakeOpenBoardPkg) > * [Purley](Platform/Intel/PurleyOpenBoardPkg) > +* [Whiskey Lake](Platform/Intel/WhiskeylakeOpenBoardPkg) >=20 > For more information, see the > [EDK II Minimum Platform > Specification](https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-spec= if > ication). > -- > 2.16.2.windows.1