public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kubacki, Michael A" <michael.a.kubacki@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files
Date: Wed, 21 Aug 2019 08:09:34 +0000	[thread overview]
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504667EC@PGSMSX111.gar.corp.intel.com> (raw)
In-Reply-To: <20190821080108.1736-3-shenglei.zhang@intel.com>


Some of files touched by this patch still having old copyright year, please help to extend.
With above update: Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, August 21, 2019 4:01 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing
> header files in INF files
> 
> The header files are used but missing in INF,which causes warning message
> when building them.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2037
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  .../MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf     | 1 +
>  .../SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf | 1 +
>  .../Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf              | 1 +
>  .../Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf       | 2 ++
>  .../PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf        | 2 ++
>  .../Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf     | 1 +
>  .../Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf     | 1 +
>  7 files changed, 9 insertions(+)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
> b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
> index cca7de94..4c5202f9 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
> +++
> b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm
> +++ .inf
> @@ -50,6 +50,7 @@
>  [Sources]
>    Common/SpiFvbServiceCommon.c
>    Common/FvbInfo.c
> +  Common/SpiFvbServiceCommon.h
>    Smm/SpiFvbServiceSmm.c
> 
>  [Protocols]
> diff --git
> a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfo
> rmSecLib/SecFspWrapperPlatformSecLib.inf
> b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfo
> rmSecLib/SecFspWrapperPlatformSecLib.inf
> index 5d77e9e4..3f5a63f2 100644
> ---
> a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfo
> rmSecLib/SecFspWrapperPlatformSecLib.inf
> +++
> b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlat
> +++ formSecLib/SecFspWrapperPlatformSecLib.inf
> @@ -41,6 +41,7 @@
>    SecGetPerformance.c
>    SecTempRamDone.c
>    PlatformInit.c
> +  FsptCoreUpd.h
> 
>  [Sources.IA32]
>    Ia32/SecEntry.nasm
> diff --git
> a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformD
> xe.inf
> b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformD
> xe.inf
> index 64814528..172280e8 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformD
> xe.inf
> +++ b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatf
> +++ ormDxe.inf
> @@ -23,6 +23,7 @@
>    SecureBootBypass.c
>    ExternalDeviceDmaProtection.c
>    MorSupport.c
> +  HstiIbvPlatformDxe.h
> 
>  [Packages]
>    MdePkg/MdePkg.dec
> diff --git
> a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria
> bleLibFce.inf
> b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria
> bleLibFce.inf
> index fd80c611..ad8882fe 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria
> bleLibFce.inf
> +++
> b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobV
> +++ ariableLibFce.inf
> @@ -37,6 +37,8 @@
>  [Sources]
>    PeiHobVariableLibFce.c
>    InternalCommonLib.c
> +  Variable.h
> +  Fce.h
> 
>  [Ppis]
>    gEfiPeiMemoryDiscoveredPpiGuid                ## NOTIFY
> diff --git
> a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria
> bleLibFceOptSize.inf
> b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria
> bleLibFceOptSize.inf
> index 82d81c98..e1a76715 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria
> bleLibFceOptSize.inf
> +++
> b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobV
> +++ ariableLibFceOptSize.inf
> @@ -36,6 +36,8 @@
>  [Sources]
>    PeiHobVariableLibFceOptSize.c
>    InternalCommonLib.c
> +  Variable.h
> +  Fce.h
> 
>  [Ppis]
>    gEfiPeiMemoryDiscoveredPpiGuid                ## NOTIFY
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi
> ntCheckLib.inf
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi
> ntCheckLib.inf
> index 62fceffb..76e193dc 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi
> ntCheckLib.inf
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTe
> +++ stPointCheckLib.inf
> @@ -68,6 +68,7 @@
>    DxeCheckTcgMor.c
>    DxeCheckDmaProtection.c
>    TestPointHelp.c
> +  TestPointInternal.h
> 
>  [Guids]
>    gEfiMemoryAttributesTableGuid
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestP
> ointCheckLib.inf
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestP
> ointCheckLib.inf
> index 6007fbc9..03d027ec 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestP
> ointCheckLib.inf
> +++
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTe
> +++ stPointCheckLib.inf
> @@ -45,6 +45,7 @@
>    DxeCheckLoadedImage.c
>    DxeCheckGcd.c
>    TestPointHelp.c
> +  TestPointInternal.h
> 
>  [Pcd]
>    gMinPlatformPkgTokenSpaceGuid.PcdTestPointIbvPlatformFeature
> --
> 2.18.0.windows.1


  reply	other threads:[~2019-08-21  8:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21  8:01 [edk2-platform PATCH 0/2] Fix warning message issues Zhang, Shenglei
2019-08-21  8:01 ` [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF Zhang, Shenglei
2019-08-23 17:32   ` Kubacki, Michael A
2019-08-23 18:11   ` Chaganty, Rangasai V
2019-08-27  1:31     ` Zhang, Shenglei
2019-08-21  8:01 ` [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files Zhang, Shenglei
2019-08-21  8:09   ` Chiu, Chasel [this message]
2019-08-23 17:33   ` Kubacki, Michael A
2019-08-23 21:55   ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C3EFB470A303B4AB093197B6777CCEC504667EC@PGSMSX111.gar.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox