From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: chasel.chiu@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Wed, 21 Aug 2019 01:13:36 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Aug 2019 01:13:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,412,1559545200"; d="scan'208";a="183465875" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by orsmga006.jf.intel.com with ESMTP; 21 Aug 2019 01:13:34 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by KMSMSX151.gar.corp.intel.com ([169.254.10.91]) with mapi id 14.03.0439.000; Wed, 21 Aug 2019 16:09:35 +0800 From: "Chiu, Chasel" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Desimone, Nathaniel L" , "Gao, Liming" Subject: Re: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files Thread-Topic: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files Thread-Index: AQHVV/aq1gQiURzZt0a1t4MUGrEbk6cFPwfg Date: Wed, 21 Aug 2019 08:09:34 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504667EC@PGSMSX111.gar.corp.intel.com> References: <20190821080108.1736-1-shenglei.zhang@intel.com> <20190821080108.1736-3-shenglei.zhang@intel.com> In-Reply-To: <20190821080108.1736-3-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTg3NGFkZjQtMWZmZS00MDVjLTkyZDEtNzA0NzZmNTg2Y2E4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiY0U4d2xEb0tRa0hpamFYY2tWTDRTSjNxSXBFMXdnYlZZdVR3eEFJQU05b2hoTUdNNFdIek9BcEtXdEVRXC9xT08ifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Some of files touched by this patch still having old copyright year, please= help to extend. With above update: Reviewed-by: Chasel Chiu > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, August 21, 2019 4:01 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing > header files in INF files >=20 > The header files are used but missing in INF,which causes warning message > when building them. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2037 >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > .../MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf | 1 + > .../SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf | 1 + > .../Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf | 1 + > .../Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf | 2 ++ > .../PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf | 2 ++ > .../Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf | 1 + > .../Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf | 1 + > 7 files changed, 9 insertions(+) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf > b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf > index cca7de94..4c5202f9 100644 > --- > a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf > +++ > b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm > +++ .inf > @@ -50,6 +50,7 @@ > [Sources] > Common/SpiFvbServiceCommon.c > Common/FvbInfo.c > + Common/SpiFvbServiceCommon.h > Smm/SpiFvbServiceSmm.c >=20 > [Protocols] > diff --git > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfo > rmSecLib/SecFspWrapperPlatformSecLib.inf > b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfo > rmSecLib/SecFspWrapperPlatformSecLib.inf > index 5d77e9e4..3f5a63f2 100644 > --- > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfo > rmSecLib/SecFspWrapperPlatformSecLib.inf > +++ > b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlat > +++ formSecLib/SecFspWrapperPlatformSecLib.inf > @@ -41,6 +41,7 @@ > SecGetPerformance.c > SecTempRamDone.c > PlatformInit.c > + FsptCoreUpd.h >=20 > [Sources.IA32] > Ia32/SecEntry.nasm > diff --git > a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformD > xe.inf > b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformD > xe.inf > index 64814528..172280e8 100644 > --- > a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformD > xe.inf > +++ b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatf > +++ ormDxe.inf > @@ -23,6 +23,7 @@ > SecureBootBypass.c > ExternalDeviceDmaProtection.c > MorSupport.c > + HstiIbvPlatformDxe.h >=20 > [Packages] > MdePkg/MdePkg.dec > diff --git > a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria > bleLibFce.inf > b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria > bleLibFce.inf > index fd80c611..ad8882fe 100644 > --- > a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria > bleLibFce.inf > +++ > b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobV > +++ ariableLibFce.inf > @@ -37,6 +37,8 @@ > [Sources] > PeiHobVariableLibFce.c > InternalCommonLib.c > + Variable.h > + Fce.h >=20 > [Ppis] > gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY > diff --git > a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria > bleLibFceOptSize.inf > b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria > bleLibFceOptSize.inf > index 82d81c98..e1a76715 100644 > --- > a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria > bleLibFceOptSize.inf > +++ > b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobV > +++ ariableLibFceOptSize.inf > @@ -36,6 +36,8 @@ > [Sources] > PeiHobVariableLibFceOptSize.c > InternalCommonLib.c > + Variable.h > + Fce.h >=20 > [Ppis] > gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi > ntCheckLib.inf > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi > ntCheckLib.inf > index 62fceffb..76e193dc 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi > ntCheckLib.inf > +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTe > +++ stPointCheckLib.inf > @@ -68,6 +68,7 @@ > DxeCheckTcgMor.c > DxeCheckDmaProtection.c > TestPointHelp.c > + TestPointInternal.h >=20 > [Guids] > gEfiMemoryAttributesTableGuid > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestP > ointCheckLib.inf > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestP > ointCheckLib.inf > index 6007fbc9..03d027ec 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestP > ointCheckLib.inf > +++ > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTe > +++ stPointCheckLib.inf > @@ -45,6 +45,7 @@ > DxeCheckLoadedImage.c > DxeCheckGcd.c > TestPointHelp.c > + TestPointInternal.h >=20 > [Pcd] > gMinPlatformPkgTokenSpaceGuid.PcdTestPointIbvPlatformFeature > -- > 2.18.0.windows.1