[edk2-platforms PATCH 0/4] Add build option in DSC files

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [edk2-platforms PATCH 0/4] Add build option in DSC files
@ 2019-08-22  7:08 Zhang, Shenglei
  2019-08-22  7:08 ` [edk2-platforms PATCH 1/4] Platform/AdvancedFeaturePkg.dsc: Add build option Zhang, Shenglei
                   ` (3 more replies)
  0 siblings, 4 replies; 12+ messages in thread
From: Zhang, Shenglei @ 2019-08-22  7:08 UTC (permalink / raw)
  To: devel
  Cc: Dandan Bi, Liming Gao, Sai Chaganty, Eric Dong, Michael Kubacki,
	Chasel Chiu, Nate DeSimone

Add build option "/D DISABLE_NEW_DEPRECATED_INTERFACES"
to make sure the deprecated APIs are not used in our code.
https://bugzilla.tianocore.org/show_bug.cgi?id=2111

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
shenglei (4):
  Platform/AdvancedFeaturePkg.dsc: Add build option
  Platform/DebugFeaturePkg.dsc: Add build option
  Platform/MinPlatformPkg.dsc: Add build option
  Platform/UserInterfaceFeaturePkg.dsc: Add build option

 Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc       | 3 +++
 Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc             | 3 +++
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc               | 3 +++
 .../Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc  | 2 ++
 4 files changed, 11 insertions(+)

-- 
2.18.0.windows.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [edk2-platforms PATCH 1/4] Platform/AdvancedFeaturePkg.dsc: Add build option
  2019-08-22  7:08 [edk2-platforms PATCH 0/4] Add build option in DSC files Zhang, Shenglei
@ 2019-08-22  7:08 ` Zhang, Shenglei
  2019-08-23 17:21   ` [edk2-devel] " Kubacki, Michael A
  2019-08-23 17:57   ` Chaganty, Rangasai V
  2019-08-22  7:08 ` [edk2-platforms PATCH 2/4] Platform/DebugFeaturePkg.dsc: " Zhang, Shenglei
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 12+ messages in thread
From: Zhang, Shenglei @ 2019-08-22  7:08 UTC (permalink / raw)
  To: devel; +Cc: Michael Kubacki, Sai Chaganty, Liming Gao, Shenglei Zhang

Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in
DSC file to make sure that the deprecated APIs will not be
used in our code.
https://bugzilla.tianocore.org/show_bug.cgi?id=2111

Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
index ea1a0072..57f28b8c 100644
--- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
+++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
@@ -148,3 +148,6 @@
   AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.inf
   AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.inf
   AdvancedFeaturePkg/Ipmi/BmcAcpi/BmcAcpi.inf
+
+[BuildOptions]
+  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
\ No newline at end of file
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [edk2-devel] [edk2-platforms PATCH 1/4] Platform/AdvancedFeaturePkg.dsc: Add build option
  2019-08-22  7:08 ` [edk2-platforms PATCH 1/4] Platform/AdvancedFeaturePkg.dsc: Add build option Zhang, Shenglei
@ 2019-08-23 17:21   ` Kubacki, Michael A
  2019-08-23 17:57   ` Chaganty, Rangasai V
  1 sibling, 0 replies; 12+ messages in thread
From: Kubacki, Michael A @ 2019-08-23 17:21 UTC (permalink / raw)
  To: devel@edk2.groups.io, Zhang, Shenglei; +Cc: Chaganty, Rangasai V, Gao, Liming

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 22, 2019 12:08 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Gao, Liming <liming.gao@intel.com>; Zhang,
> Shenglei <shenglei.zhang@intel.com>
> Subject: [edk2-devel] [edk2-platforms PATCH 1/4]
> Platform/AdvancedFeaturePkg.dsc: Add build option
> 
> Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in DSC file
> to make sure that the deprecated APIs will not be used in our code.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2111
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
> b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
> index ea1a0072..57f28b8c 100644
> --- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
> +++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
> @@ -148,3 +148,6 @@
>    AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.inf
>    AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.inf
>    AdvancedFeaturePkg/Ipmi/BmcAcpi/BmcAcpi.inf
> +
> +[BuildOptions]
> +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> \ No newline at end of file
> --
> 2.18.0.windows.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [edk2-platforms PATCH 1/4] Platform/AdvancedFeaturePkg.dsc: Add build option
  2019-08-22  7:08 ` [edk2-platforms PATCH 1/4] Platform/AdvancedFeaturePkg.dsc: Add build option Zhang, Shenglei
  2019-08-23 17:21   ` [edk2-devel] " Kubacki, Michael A
@ 2019-08-23 17:57   ` Chaganty, Rangasai V
  1 sibling, 0 replies; 12+ messages in thread
From: Chaganty, Rangasai V @ 2019-08-23 17:57 UTC (permalink / raw)
  To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Kubacki, Michael A, Gao, Liming

Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Zhang, Shenglei 
Sent: Thursday, August 22, 2019 12:08 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Gao, Liming <liming.gao@intel.com>; Zhang, Shenglei <shenglei.zhang@intel.com>
Subject: [edk2-platforms PATCH 1/4] Platform/AdvancedFeaturePkg.dsc: Add build option

Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in DSC file to make sure that the deprecated APIs will not be used in our code.
https://bugzilla.tianocore.org/show_bug.cgi?id=2111

Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
index ea1a0072..57f28b8c 100644
--- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
+++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
@@ -148,3 +148,6 @@
   AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.inf
   AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.inf
   AdvancedFeaturePkg/Ipmi/BmcAcpi/BmcAcpi.inf
+
+[BuildOptions]
+  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
\ No newline at end of file
--
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [edk2-platforms PATCH 2/4] Platform/DebugFeaturePkg.dsc: Add build option
  2019-08-22  7:08 [edk2-platforms PATCH 0/4] Add build option in DSC files Zhang, Shenglei
  2019-08-22  7:08 ` [edk2-platforms PATCH 1/4] Platform/AdvancedFeaturePkg.dsc: Add build option Zhang, Shenglei
@ 2019-08-22  7:08 ` Zhang, Shenglei
  2019-08-23 17:22   ` [edk2-devel] " Kubacki, Michael A
  2019-08-22  7:08 ` [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: " Zhang, Shenglei
  2019-08-22  7:08 ` [edk2-platforms PATCH 4/4] Platform/UserInterfaceFeaturePkg.dsc: " Zhang, Shenglei
  3 siblings, 1 reply; 12+ messages in thread
From: Zhang, Shenglei @ 2019-08-22  7:08 UTC (permalink / raw)
  To: devel; +Cc: Eric Dong, Liming Gao, Shenglei Zhang

Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in
DSC file to make sure that the deprecated APIs will not be
used in our code.
https://bugzilla.tianocore.org/show_bug.cgi?id=2111

Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
index b88d1fae..61046f7a 100644
--- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
+++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
@@ -96,3 +96,6 @@
 
   DebugFeaturePkg/AcpiDebug/AcpiDebugDxe.inf
   DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
+
+[BuildOptions]
+  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
\ No newline at end of file
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [edk2-devel] [edk2-platforms PATCH 2/4] Platform/DebugFeaturePkg.dsc: Add build option
  2019-08-22  7:08 ` [edk2-platforms PATCH 2/4] Platform/DebugFeaturePkg.dsc: " Zhang, Shenglei
@ 2019-08-23 17:22   ` Kubacki, Michael A
  0 siblings, 0 replies; 12+ messages in thread
From: Kubacki, Michael A @ 2019-08-23 17:22 UTC (permalink / raw)
  To: devel@edk2.groups.io, Zhang, Shenglei; +Cc: Dong, Eric, Gao, Liming

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 22, 2019 12:08 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Zhang, Shenglei <shenglei.zhang@intel.com>
> Subject: [edk2-devel] [edk2-platforms PATCH 2/4]
> Platform/DebugFeaturePkg.dsc: Add build option
> 
> Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in DSC file
> to make sure that the deprecated APIs will not be used in our code.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2111
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> index b88d1fae..61046f7a 100644
> --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> @@ -96,3 +96,6 @@
> 
>    DebugFeaturePkg/AcpiDebug/AcpiDebugDxe.inf
>    DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
> +
> +[BuildOptions]
> +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> \ No newline at end of file
> --
> 2.18.0.windows.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: Add build option
  2019-08-22  7:08 [edk2-platforms PATCH 0/4] Add build option in DSC files Zhang, Shenglei
  2019-08-22  7:08 ` [edk2-platforms PATCH 1/4] Platform/AdvancedFeaturePkg.dsc: Add build option Zhang, Shenglei
  2019-08-22  7:08 ` [edk2-platforms PATCH 2/4] Platform/DebugFeaturePkg.dsc: " Zhang, Shenglei
@ 2019-08-22  7:08 ` Zhang, Shenglei
  2019-08-22 18:03   ` [edk2-devel] " Chiu, Chasel
                     ` (2 more replies)
  2019-08-22  7:08 ` [edk2-platforms PATCH 4/4] Platform/UserInterfaceFeaturePkg.dsc: " Zhang, Shenglei
  3 siblings, 3 replies; 12+ messages in thread
From: Zhang, Shenglei @ 2019-08-22  7:08 UTC (permalink / raw)
  To: devel
  Cc: Michael Kubacki, Chasel Chiu, Nate DeSimone, Liming Gao,
	Shenglei Zhang

Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in
DSC file to make sure that the deprecated APIs will not be
used in our code.
https://bugzilla.tianocore.org/show_bug.cgi?id=2111

Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
index 8a3638b7..9bbb7963 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
@@ -187,3 +187,6 @@
   MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf
   MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf
 !endif
+
+[BuildOptions]
+  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
\ No newline at end of file
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [edk2-devel] [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: Add build option
  2019-08-22  7:08 ` [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: " Zhang, Shenglei
@ 2019-08-22 18:03   ` Chiu, Chasel
  2019-08-23 17:24   ` Kubacki, Michael A
  2019-08-23 23:39   ` Nate DeSimone
  2 siblings, 0 replies; 12+ messages in thread
From: Chiu, Chasel @ 2019-08-22 18:03 UTC (permalink / raw)
  To: devel@edk2.groups.io, Zhang, Shenglei
  Cc: Kubacki, Michael A, Desimone, Nathaniel L, Gao, Liming


This file still having 2018 in copyright, so please help to extend it.
With above change Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 22, 2019 3:08 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Zhang, Shenglei <shenglei.zhang@intel.com>
> Subject: [edk2-devel] [edk2-platforms PATCH 3/4]
> Platform/MinPlatformPkg.dsc: Add build option
> 
> Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in DSC file
> to make sure that the deprecated APIs will not be used in our code.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2111
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> index 8a3638b7..9bbb7963 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> @@ -187,3 +187,6 @@
>    MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf
>    MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf
>  !endif
> +
> +[BuildOptions]
> +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> \ No newline at end of file
> --
> 2.18.0.windows.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [edk2-devel] [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: Add build option
  2019-08-22  7:08 ` [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: " Zhang, Shenglei
  2019-08-22 18:03   ` [edk2-devel] " Chiu, Chasel
@ 2019-08-23 17:24   ` Kubacki, Michael A
  2019-08-23 23:39   ` Nate DeSimone
  2 siblings, 0 replies; 12+ messages in thread
From: Kubacki, Michael A @ 2019-08-23 17:24 UTC (permalink / raw)
  To: devel@edk2.groups.io, Zhang, Shenglei
  Cc: Chiu, Chasel, Desimone, Nathaniel L, Gao, Liming

Please extend the file copyright date. With that change:

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 22, 2019 12:08 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Zhang, Shenglei <shenglei.zhang@intel.com>
> Subject: [edk2-devel] [edk2-platforms PATCH 3/4]
> Platform/MinPlatformPkg.dsc: Add build option
> 
> Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in DSC file
> to make sure that the deprecated APIs will not be used in our code.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2111
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> index 8a3638b7..9bbb7963 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> @@ -187,3 +187,6 @@
>    MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf
>    MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf
>  !endif
> +
> +[BuildOptions]
> +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> \ No newline at end of file
> --
> 2.18.0.windows.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: Add build option
  2019-08-22  7:08 ` [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: " Zhang, Shenglei
  2019-08-22 18:03   ` [edk2-devel] " Chiu, Chasel
  2019-08-23 17:24   ` Kubacki, Michael A
@ 2019-08-23 23:39   ` Nate DeSimone
  2 siblings, 0 replies; 12+ messages in thread
From: Nate DeSimone @ 2019-08-23 23:39 UTC (permalink / raw)
  To: Zhang, Shenglei, devel@edk2.groups.io
  Cc: Kubacki, Michael A, Chiu, Chasel, Gao, Liming

As noted by others, please update copyright year. With that change...

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Zhang, Shenglei 
Sent: Thursday, August 22, 2019 12:08 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>; Zhang, Shenglei <shenglei.zhang@intel.com>
Subject: [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: Add build option

Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in DSC file to make sure that the deprecated APIs will not be used in our code.
https://bugzilla.tianocore.org/show_bug.cgi?id=2111

Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
index 8a3638b7..9bbb7963 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
@@ -187,3 +187,6 @@
   MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf
   MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf
 !endif
+
+[BuildOptions]
+  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
\ No newline at end of file
--
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [edk2-platforms PATCH 4/4] Platform/UserInterfaceFeaturePkg.dsc: Add build option
  2019-08-22  7:08 [edk2-platforms PATCH 0/4] Add build option in DSC files Zhang, Shenglei
                   ` (2 preceding siblings ...)
  2019-08-22  7:08 ` [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: " Zhang, Shenglei
@ 2019-08-22  7:08 ` Zhang, Shenglei
  2019-08-23 17:24   ` [edk2-devel] " Kubacki, Michael A
  3 siblings, 1 reply; 12+ messages in thread
From: Zhang, Shenglei @ 2019-08-22  7:08 UTC (permalink / raw)
  To: devel; +Cc: Dandan Bi, Liming Gao, Shenglei Zhang

Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in
DSC file to make sure that the deprecated APIs will not be
used in our code.
https://bugzilla.tianocore.org/show_bug.cgi?id=2111

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .../Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc   | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
index 2c24e43f..95c26766 100644
--- a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
+++ b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
@@ -76,3 +76,5 @@
   UserInterfaceFeaturePkg/UserAuthentication/UserAuthentication2Dxe.inf
   UserInterfaceFeaturePkg/UserAuthentication/UserAuthenticationSmm.inf
 
+[BuildOptions]
+  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
\ No newline at end of file
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [edk2-devel] [edk2-platforms PATCH 4/4] Platform/UserInterfaceFeaturePkg.dsc: Add build option
  2019-08-22  7:08 ` [edk2-platforms PATCH 4/4] Platform/UserInterfaceFeaturePkg.dsc: " Zhang, Shenglei
@ 2019-08-23 17:24   ` Kubacki, Michael A
  0 siblings, 0 replies; 12+ messages in thread
From: Kubacki, Michael A @ 2019-08-23 17:24 UTC (permalink / raw)
  To: devel@edk2.groups.io, Zhang, Shenglei; +Cc: Bi, Dandan, Gao, Liming

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 22, 2019 12:08 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Zhang, Shenglei <shenglei.zhang@intel.com>
> Subject: [edk2-devel] [edk2-platforms PATCH 4/4]
> Platform/UserInterfaceFeaturePkg.dsc: Add build option
> 
> Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in DSC file
> to make sure that the deprecated APIs will not be used in our code.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2111
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  .../Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc   | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git
> a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> index 2c24e43f..95c26766 100644
> --- a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> +++ b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> @@ -76,3 +76,5 @@
>    UserInterfaceFeaturePkg/UserAuthentication/UserAuthentication2Dxe.inf
>    UserInterfaceFeaturePkg/UserAuthentication/UserAuthenticationSmm.inf
> 
> +[BuildOptions]
> +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> \ No newline at end of file
> --
> 2.18.0.windows.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-08-23 23:39 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-22  7:08 [edk2-platforms PATCH 0/4] Add build option in DSC files Zhang, Shenglei
2019-08-22  7:08 ` [edk2-platforms PATCH 1/4] Platform/AdvancedFeaturePkg.dsc: Add build option Zhang, Shenglei
2019-08-23 17:21   ` [edk2-devel] " Kubacki, Michael A
2019-08-23 17:57   ` Chaganty, Rangasai V
2019-08-22  7:08 ` [edk2-platforms PATCH 2/4] Platform/DebugFeaturePkg.dsc: " Zhang, Shenglei
2019-08-23 17:22   ` [edk2-devel] " Kubacki, Michael A
2019-08-22  7:08 ` [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: " Zhang, Shenglei
2019-08-22 18:03   ` [edk2-devel] " Chiu, Chasel
2019-08-23 17:24   ` Kubacki, Michael A
2019-08-23 23:39   ` Nate DeSimone
2019-08-22  7:08 ` [edk2-platforms PATCH 4/4] Platform/UserInterfaceFeaturePkg.dsc: " Zhang, Shenglei
2019-08-23 17:24   ` [edk2-devel] " Kubacki, Michael A

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox