* [edk2-platforms][PATCH V2 0/2] Fix KBL-Based Platform GCC Build Failures
@ 2019-08-22 18:16 Kubacki, Michael A
2019-08-22 18:16 ` [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix " Kubacki, Michael A
2019-08-22 18:16 ` [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: " Kubacki, Michael A
0 siblings, 2 replies; 7+ messages in thread
From: Kubacki, Michael A @ 2019-08-22 18:16 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Nate DeSimone, Liming Gao, Ankit Sinha
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2109
These patches build failures found in Kaby Lake based platforms.
V2 Changes:
* Extended copyright date in BaseGpioExpanderLib.c to 2019.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
Michael Kubacki (2):
KabylakeOpenBoardPkg: Fix GCC Build Failures
ClevoOpenBoardPkg: Fix GCC Build Failures
Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c | 7 ++-----
Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatformSecLib.c | 2 +-
Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c | 8 +++-----
3 files changed, 6 insertions(+), 11 deletions(-)
--
2.16.2.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures
2019-08-22 18:16 [edk2-platforms][PATCH V2 0/2] Fix KBL-Based Platform GCC Build Failures Kubacki, Michael A
@ 2019-08-22 18:16 ` Kubacki, Michael A
2019-08-23 7:07 ` Chiu, Chasel
2019-08-23 22:09 ` Nate DeSimone
2019-08-22 18:16 ` [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: " Kubacki, Michael A
1 sibling, 2 replies; 7+ messages in thread
From: Kubacki, Michael A @ 2019-08-22 18:16 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Nate DeSimone, Liming Gao
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2109
Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatformSecLib.c | 2 +-
Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatformSecLib.c b/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatformSecLib.c
index d73fc77f69..d40eecae95 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatformSecLib.c
+++ b/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatformSecLib.c
@@ -174,7 +174,7 @@ SecPlatformMain (
//
CopyMem (CopyDestinationPointer, mPeiCoreFvLocationPpiList, sizeof (mPeiCoreFvLocationPpiList));
TopOfTemporaryRamPpiIndex = 1;
- (UINT8 *) CopyDestinationPointer += sizeof(mPeiCoreFvLocationPpiList);
+ CopyDestinationPointer += sizeof (mPeiCoreFvLocationPpiList);
}
CopyMem (CopyDestinationPointer, mPeiSecPlatformPpi, sizeof(mPeiSecPlatformPpi));
//
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
index ead1e6df19..3d1856d89e 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
@@ -1,7 +1,7 @@
/** @file
Support for IO expander TCA6424.
-Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -70,12 +70,11 @@ GpioExpGetRegister (
IN UINT8 Register
)
{
- EFI_STATUS Status;
UINT8 WriBuf[1];
UINT8 ReBuf[1] = {0};
WriBuf[0] = Register;
- Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 1, WriBuf, 1, ReBuf, WAIT_1_SECOND);
+ I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 1, WriBuf, 1, ReBuf, WAIT_1_SECOND);
return ReBuf[0];
}
@@ -99,13 +98,12 @@ GpioExpSetRegister (
IN UINT8 Value
)
{
- EFI_STATUS Status;
UINT8 WriBuf[2];
WriBuf[0] = Register;
WriBuf[1] = Value;
- Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 2, WriBuf, 0, NULL, WAIT_1_SECOND);
+ I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 2, WriBuf, 0, NULL, WAIT_1_SECOND);
}
/**
Set the input register to a give value mentioned in the function.
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: Fix GCC Build Failures
2019-08-22 18:16 [edk2-platforms][PATCH V2 0/2] Fix KBL-Based Platform GCC Build Failures Kubacki, Michael A
2019-08-22 18:16 ` [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix " Kubacki, Michael A
@ 2019-08-22 18:16 ` Kubacki, Michael A
2019-08-22 18:33 ` Sinha, Ankit
2019-08-23 22:09 ` Nate DeSimone
1 sibling, 2 replies; 7+ messages in thread
From: Kubacki, Michael A @ 2019-08-22 18:16 UTC (permalink / raw)
To: devel; +Cc: Nate DeSimone, Liming Gao, Ankit Sinha
Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c b/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
index 260c5bb6a2..cc70f15c24 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
+++ b/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
@@ -70,12 +70,11 @@ GpioExpGetRegister (
IN UINT8 Register
)
{
- EFI_STATUS Status;
UINT8 WriBuf[1];
UINT8 ReBuf[1] = {0};
WriBuf[0] = Register;
- Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 1, WriBuf, 1, ReBuf, WAIT_1_SECOND);
+ I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 1, WriBuf, 1, ReBuf, WAIT_1_SECOND);
return ReBuf[0];
}
@@ -99,13 +98,11 @@ GpioExpSetRegister (
IN UINT8 Value
)
{
- EFI_STATUS Status;
UINT8 WriBuf[2];
WriBuf[0] = Register;
WriBuf[1] = Value;
- Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 2, WriBuf, 0, NULL, WAIT_1_SECOND);
-
+ I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 2, WriBuf, 0, NULL, WAIT_1_SECOND);
}
/**
Set the input register to a give value mentioned in the function.
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: Fix GCC Build Failures
2019-08-22 18:16 ` [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: " Kubacki, Michael A
@ 2019-08-22 18:33 ` Sinha, Ankit
2019-08-23 22:09 ` Nate DeSimone
1 sibling, 0 replies; 7+ messages in thread
From: Sinha, Ankit @ 2019-08-22 18:33 UTC (permalink / raw)
To: Kubacki, Michael A, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Gao, Liming
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com>
-----Original Message-----
From: Kubacki, Michael A
Sent: Thursday, August 22, 2019 11:17 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>
Subject: [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: Fix GCC Build Failures
Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c b/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
index 260c5bb6a2..cc70f15c24 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
+++ b/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
@@ -70,12 +70,11 @@ GpioExpGetRegister (
IN UINT8 Register
)
{
- EFI_STATUS Status;
UINT8 WriBuf[1];
UINT8 ReBuf[1] = {0};
WriBuf[0] = Register;
- Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 1, WriBuf, 1, ReBuf, WAIT_1_SECOND);
+ I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 1, WriBuf, 1, ReBuf, WAIT_1_SECOND);
return ReBuf[0];
}
@@ -99,13 +98,11 @@ GpioExpSetRegister (
IN UINT8 Value
)
{
- EFI_STATUS Status;
UINT8 WriBuf[2];
WriBuf[0] = Register;
WriBuf[1] = Value;
- Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 2, WriBuf, 0, NULL, WAIT_1_SECOND);
-
+ I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 2, WriBuf, 0, NULL, WAIT_1_SECOND);
}
/**
Set the input register to a give value mentioned in the function.
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures
2019-08-22 18:16 ` [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix " Kubacki, Michael A
@ 2019-08-23 7:07 ` Chiu, Chasel
2019-08-23 22:09 ` Nate DeSimone
1 sibling, 0 replies; 7+ messages in thread
From: Chiu, Chasel @ 2019-08-23 7:07 UTC (permalink / raw)
To: Kubacki, Michael A, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Gao, Liming
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Kubacki, Michael A
> Sent: Friday, August 23, 2019 2:17 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC
> Build Failures
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2109
>
> Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>
> Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper
> PlatformSecLib/FspWrapperPlatformSecLib.c | 2 +-
>
> Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseG
> pioExpanderLib.c | 8 +++-----
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp
> erPlatformSecLib/FspWrapperPlatformSecLib.c
> b/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp
> erPlatformSecLib/FspWrapperPlatformSecLib.c
> index d73fc77f69..d40eecae95 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp
> erPlatformSecLib/FspWrapperPlatformSecLib.c
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp
> erPlatformSecLib/FspWrapperPlatformSecLib.c
> @@ -174,7 +174,7 @@ SecPlatformMain (
> //
> CopyMem (CopyDestinationPointer, mPeiCoreFvLocationPpiList, sizeof
> (mPeiCoreFvLocationPpiList));
> TopOfTemporaryRamPpiIndex = 1;
> - (UINT8 *) CopyDestinationPointer += sizeof(mPeiCoreFvLocationPpiList);
> + CopyDestinationPointer += sizeof (mPeiCoreFvLocationPpiList);
> }
> CopyMem (CopyDestinationPointer, mPeiSecPlatformPpi,
> sizeof(mPeiSecPlatformPpi));
> //
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Bas
> eGpioExpanderLib.c
> b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Bas
> eGpioExpanderLib.c
> index ead1e6df19..3d1856d89e 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Bas
> eGpioExpanderLib.c
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Bas
> eGpioExpanderLib.c
> @@ -1,7 +1,7 @@
> /** @file
> Support for IO expander TCA6424.
>
> -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -70,12 +70,11 @@ GpioExpGetRegister (
> IN UINT8 Register
> )
> {
> - EFI_STATUS Status;
> UINT8 WriBuf[1];
> UINT8 ReBuf[1] = {0};
>
> WriBuf[0] = Register;
> - Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 1, WriBuf, 1,
> ReBuf, WAIT_1_SECOND);
> + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 1, WriBuf, 1, ReBuf,
> WAIT_1_SECOND);
>
> return ReBuf[0];
> }
> @@ -99,13 +98,12 @@ GpioExpSetRegister (
> IN UINT8 Value
> )
> {
> - EFI_STATUS Status;
> UINT8 WriBuf[2];
>
> WriBuf[0] = Register;
> WriBuf[1] = Value;
> - Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 2, WriBuf, 0,
> NULL, WAIT_1_SECOND);
>
> + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 2, WriBuf, 0, NULL,
> WAIT_1_SECOND);
> }
> /**
> Set the input register to a give value mentioned in the function.
> --
> 2.16.2.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures
2019-08-22 18:16 ` [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix " Kubacki, Michael A
2019-08-23 7:07 ` Chiu, Chasel
@ 2019-08-23 22:09 ` Nate DeSimone
1 sibling, 0 replies; 7+ messages in thread
From: Nate DeSimone @ 2019-08-23 22:09 UTC (permalink / raw)
To: Kubacki, Michael A, devel@edk2.groups.io; +Cc: Chiu, Chasel, Gao, Liming
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Kubacki, Michael A
Sent: Thursday, August 22, 2019 11:17 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2109
Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatformSecLib.c | 2 +-
Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatformSecLib.c b/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatformSecLib.c
index d73fc77f69..d40eecae95 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatformSecLib.c
+++ b/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatformSecLib.c
@@ -174,7 +174,7 @@ SecPlatformMain (
//
CopyMem (CopyDestinationPointer, mPeiCoreFvLocationPpiList, sizeof (mPeiCoreFvLocationPpiList));
TopOfTemporaryRamPpiIndex = 1;
- (UINT8 *) CopyDestinationPointer += sizeof(mPeiCoreFvLocationPpiList);
+ CopyDestinationPointer += sizeof (mPeiCoreFvLocationPpiList);
}
CopyMem (CopyDestinationPointer, mPeiSecPlatformPpi, sizeof(mPeiSecPlatformPpi));
//
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
index ead1e6df19..3d1856d89e 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
@@ -1,7 +1,7 @@
/** @file
Support for IO expander TCA6424.
-Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -70,12 +70,11 @@ GpioExpGetRegister (
IN UINT8 Register
)
{
- EFI_STATUS Status;
UINT8 WriBuf[1];
UINT8 ReBuf[1] = {0};
WriBuf[0] = Register;
- Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 1, WriBuf, 1, ReBuf, WAIT_1_SECOND);
+ I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 1, WriBuf, 1, ReBuf, WAIT_1_SECOND);
return ReBuf[0];
}
@@ -99,13 +98,12 @@ GpioExpSetRegister (
IN UINT8 Value
)
{
- EFI_STATUS Status;
UINT8 WriBuf[2];
WriBuf[0] = Register;
WriBuf[1] = Value;
- Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 2, WriBuf, 0, NULL, WAIT_1_SECOND);
+ I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 2, WriBuf, 0, NULL, WAIT_1_SECOND);
}
/**
Set the input register to a give value mentioned in the function.
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: Fix GCC Build Failures
2019-08-22 18:16 ` [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: " Kubacki, Michael A
2019-08-22 18:33 ` Sinha, Ankit
@ 2019-08-23 22:09 ` Nate DeSimone
1 sibling, 0 replies; 7+ messages in thread
From: Nate DeSimone @ 2019-08-23 22:09 UTC (permalink / raw)
To: Kubacki, Michael A, devel@edk2.groups.io; +Cc: Gao, Liming, Sinha, Ankit
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Kubacki, Michael A
Sent: Thursday, August 22, 2019 11:17 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>
Subject: [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: Fix GCC Build Failures
Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c b/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
index 260c5bb6a2..cc70f15c24 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
+++ b/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpanderLib.c
@@ -70,12 +70,11 @@ GpioExpGetRegister (
IN UINT8 Register
)
{
- EFI_STATUS Status;
UINT8 WriBuf[1];
UINT8 ReBuf[1] = {0};
WriBuf[0] = Register;
- Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 1, WriBuf, 1, ReBuf, WAIT_1_SECOND);
+ I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 1, WriBuf, 1, ReBuf, WAIT_1_SECOND);
return ReBuf[0];
}
@@ -99,13 +98,11 @@ GpioExpSetRegister (
IN UINT8 Value
)
{
- EFI_STATUS Status;
UINT8 WriBuf[2];
WriBuf[0] = Register;
WriBuf[1] = Value;
- Status = I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 2, WriBuf, 0, NULL, WAIT_1_SECOND);
-
+ I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 2, WriBuf, 0, NULL, WAIT_1_SECOND);
}
/**
Set the input register to a give value mentioned in the function.
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-08-23 22:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-22 18:16 [edk2-platforms][PATCH V2 0/2] Fix KBL-Based Platform GCC Build Failures Kubacki, Michael A
2019-08-22 18:16 ` [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix " Kubacki, Michael A
2019-08-23 7:07 ` Chiu, Chasel
2019-08-23 22:09 ` Nate DeSimone
2019-08-22 18:16 ` [edk2-platforms][PATCH V2 2/2] ClevoOpenBoardPkg: " Kubacki, Michael A
2019-08-22 18:33 ` Sinha, Ankit
2019-08-23 22:09 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox