From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: chasel.chiu@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Fri, 23 Aug 2019 00:07:35 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2019 00:07:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,420,1559545200"; d="scan'208";a="263112036" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga001.jf.intel.com with ESMTP; 23 Aug 2019 00:07:34 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by PGSMSX101.gar.corp.intel.com ([169.254.1.232]) with mapi id 14.03.0439.000; Fri, 23 Aug 2019 15:07:33 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Gao, Liming" Subject: Re: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures Thread-Topic: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures Thread-Index: AQHVWRXL6Zu4jRV1oEKAPGisEjMpPacIUIvg Date: Fri, 23 Aug 2019 07:07:33 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504692CF@PGSMSX111.gar.corp.intel.com> References: <20190822181642.25596-1-michael.a.kubacki@intel.com> <20190822181642.25596-2-michael.a.kubacki@intel.com> In-Reply-To: <20190822181642.25596-2-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmE3NTFkZTItMmM1YS00MWE4LWI3MTEtOGM5MGI2NmZiOWE0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYVdFVmVaaGJPbjA1V3poSk1vWjZmU0dvWFpDVm41R1NtXC9EYW5veEp4b3dqTXVJdEtmNTlzaDVrNDY2aEp5eE4ifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Friday, August 23, 2019 2:17 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platforms][PATCH V2 1/2] KabylakeOpenBoardPkg: Fix GCC > Build Failures >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2109 >=20 > Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Michael Kubacki > --- >=20 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/FspWrapperPlatformSecLib.c | 2 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseG > pioExpanderLib.c | 8 +++----- > 2 files changed, 4 insertions(+), 6 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp > erPlatformSecLib/FspWrapperPlatformSecLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp > erPlatformSecLib/FspWrapperPlatformSecLib.c > index d73fc77f69..d40eecae95 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp > erPlatformSecLib/FspWrapperPlatformSecLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp > erPlatformSecLib/FspWrapperPlatformSecLib.c > @@ -174,7 +174,7 @@ SecPlatformMain ( > // > CopyMem (CopyDestinationPointer, mPeiCoreFvLocationPpiList, sizeof > (mPeiCoreFvLocationPpiList)); > TopOfTemporaryRamPpiIndex =3D 1; > - (UINT8 *) CopyDestinationPointer +=3D sizeof(mPeiCoreFvLocationPpiLi= st); > + CopyDestinationPointer +=3D sizeof (mPeiCoreFvLocationPpiList); > } > CopyMem (CopyDestinationPointer, mPeiSecPlatformPpi, > sizeof(mPeiSecPlatformPpi)); > // > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Bas > eGpioExpanderLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Bas > eGpioExpanderLib.c > index ead1e6df19..3d1856d89e 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Bas > eGpioExpanderLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/Bas > eGpioExpanderLib.c > @@ -1,7 +1,7 @@ > /** @file > Support for IO expander TCA6424. >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -70,12 +70,11 @@ GpioExpGetRegister ( > IN UINT8 Register > ) > { > - EFI_STATUS Status; > UINT8 WriBuf[1]; > UINT8 ReBuf[1] =3D {0}; >=20 > WriBuf[0] =3D Register; > - Status =3D I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 1, WriBuf,= 1, > ReBuf, WAIT_1_SECOND); > + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 1, WriBuf, 1, ReBuf= , > WAIT_1_SECOND); >=20 > return ReBuf[0]; > } > @@ -99,13 +98,12 @@ GpioExpSetRegister ( > IN UINT8 Value > ) > { > - EFI_STATUS Status; > UINT8 WriBuf[2]; >=20 > WriBuf[0] =3D Register; > WriBuf[1] =3D Value; > - Status =3D I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 2, WriBuf,= 0, > NULL, WAIT_1_SECOND); >=20 > + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 2, WriBuf, 0, NULL, > WAIT_1_SECOND); > } > /** > Set the input register to a give value mentioned in the function. > -- > 2.16.2.windows.1