From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: chasel.chiu@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Mon, 26 Aug 2019 19:04:31 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Aug 2019 19:04:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,435,1559545200"; d="scan'208";a="331663600" Received: from kmsmsx156.gar.corp.intel.com ([172.21.138.133]) by orsmga004.jf.intel.com with ESMTP; 26 Aug 2019 19:04:29 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by KMSMSX156.gar.corp.intel.com ([169.254.1.101]) with mapi id 14.03.0439.000; Tue, 27 Aug 2019 10:04:29 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [edk2-platforms][PATCH V3 1/2] CoffeelakeSiliconPkg: Fix GCC Build Failures Thread-Topic: [edk2-platforms][PATCH V3 1/2] CoffeelakeSiliconPkg: Fix GCC Build Failures Thread-Index: AQHVXD7YeZPMgj2zdU+GSDlU5Rv5lqcOPuxw Date: Tue, 27 Aug 2019 02:04:28 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5046B749@PGSMSX111.gar.corp.intel.com> References: <20190826184758.12440-1-michael.a.kubacki@intel.com> <20190826184758.12440-2-michael.a.kubacki@intel.com> In-Reply-To: <20190826184758.12440-2-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjNiNjEyMmUtOGZmNy00ODdhLWI2NGEtMjJiNzQ0YTIwNzQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTVwvR1krKzE1MTM5eExBczVVMFJ6VElBM0pObUlwOTh1VU81dkpBK3p2Ykt1NVdEeWRhXC9BWmFzOEE1ZG1Sb1E5In0= x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Tuesday, August 27, 2019 2:48 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms][PATCH V3 1/2] CoffeelakeSiliconPkg: Fix GCC Bui= ld > Failures >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2124 >=20 > Fixes build failures on GCC7.3.0. Tested on Ubuntu 18.04.1 LTS. >=20 > Cc: Chasel Chiu > Cc: Sai Chaganty > Signed-off-by: Michael Kubacki > --- >=20 > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioConfig.= h > | 2 ++ > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h > | 1 + >=20 > Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/PeiPchPoli= cyLi > b.c | 2 -- > Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDxe.c > | 1 + > 4 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git > a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioConfi > g.h > b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioConfi > g.h > index a810d4f1fc..e2c8730f38 100644 > --- > a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioConfi > g.h > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudio > +++ Config.h > @@ -9,7 +9,9 @@ > #ifndef _HDAUDIO_CONFIG_H_ > #define _HDAUDIO_CONFIG_H_ >=20 > +#include > #include > +#include >=20 > #define HDAUDIO_PREMEM_CONFIG_REVISION 1 #define > HDAUDIO_CONFIG_REVISION 2 diff --git > a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h > b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h > index 25def24fca..ff76e7c60f 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h > @@ -11,6 +11,7 @@ > #define _GPIO_LIB_H_ >=20 > #include > +#include >=20 > #define GPIO_NAME_LENGTH_MAX 32 >=20 > diff --git > a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/PeiPchPo= lic > yLib.c > b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/PeiPchPo= lic > yLib.c > index 2a1da20667..ece0be8158 100644 > --- > a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/PeiPchPo= lic > yLib.c > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/Pei > +++ PchPolicyLib.c > @@ -353,10 +353,8 @@ LoadLanConfigDefault ( > ) > { > PCH_LAN_CONFIG *LanConfig; > - UINT16 LpcDid; >=20 > LanConfig =3D ConfigBlockPointer; > - LpcDid =3D PchGetLpcDid (); >=20 > DEBUG ((DEBUG_INFO, "LanConfig->Header.GuidHob.Name =3D %g\n", > &LanConfig->Header.GuidHob.Name)); > DEBUG ((DEBUG_INFO, "LanConfig->Header.GuidHob.Header.HobLength =3D > 0x%x\n", LanConfig->Header.GuidHob.Header.HobLength)); > diff --git > a/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDxe.c > b/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDxe.c > index d646e60618..e6980f9a65 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDxe= .c > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDx > +++ e.c > @@ -41,6 +41,7 @@ SaInitEntryPointDxe ( > SaInitEntryPoint (); >=20 > Status =3D SaAcpiInit (ImageHandle); > + ASSERT_EFI_ERROR (Status); >=20 > /// > /// Create PCI Enumeration Completed callback for SA > -- > 2.16.2.windows.1