From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: chasel.chiu@intel.com)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by groups.io with SMTP; Tue, 27 Aug 2019 17:01:19 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
  by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2019 17:01:18 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,439,1559545200"; 
   d="scan'208";a="188059643"
Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86])
  by FMSMGA003.fm.intel.com with ESMTP; 27 Aug 2019 17:01:18 -0700
Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by
 KMSMSX151.gar.corp.intel.com ([169.254.10.91]) with mapi id 14.03.0439.000;
 Wed, 28 Aug 2019 08:01:16 +0800
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>, "Ni, Ray"
	<ray.ni@intel.com>, "devel@edk2.groups.io" <devel@edk2.groups.io>
CC: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg dependency
Thread-Topic: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg
 dependency
Thread-Index: AQHVXSiUzothNOSpwkqfPEXGPIW10qcPG6cAgACPzmA=
Date: Wed, 28 Aug 2019 00:01:16 +0000
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5046D960@PGSMSX111.gar.corp.intel.com>
References: <20190827224032.231280-1-ray.ni@intel.com>
 <02A34F284D1DA44BB705E61F7180EF0AAEE57CDC@ORSMSX114.amr.corp.intel.com>
In-Reply-To: <02A34F284D1DA44BB705E61F7180EF0AAEE57CDC@ORSMSX114.amr.corp.intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODc1YWIwY2YtOWM0ZC00M2Y2LWJmMmEtOTAzMTM4YjJmZGY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTFpFUEJ6WVppZTdJQVlIVUR1TkJ2bXNFUk4xRWhkUjV0MzdUR0ZFakt0dVFrVndraG9zRldvenBJS2xtU2xsVCJ9
x-ctpclassification: CTP_NT
x-originating-ip: [172.30.20.205]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


Same findings as Nate, with FspSecCoreT.inf copyright updated, Reviewed-by:=
 Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Desimone, Nathaniel L
> Sent: Wednesday, August 28, 2019 7:21 AM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Zeng, Star <star.zeng@intel.com=
>
> Subject: RE: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded
> MdeModulePkg dependency
>=20
> Actually, please make sure you update copyright year on FspSecCoreT.inf. =
With
> that change...
>=20
> Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
>=20
> -----Original Message-----
> From: Ni, Ray
> Sent: Tuesday, August 27, 2019 3:41 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg
> dependency
>=20
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
>  IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 -
> IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 1 -
> IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf | 1 -
>  3 files changed, 3 deletions(-)
>=20
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> index 571ed9bc44..25f2a109ab 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> @@ -40,7 +40,6 @@ [Binaries.Ia32]
>=20
>  [Packages]
>    MdePkg/MdePkg.dec
> -  MdeModulePkg/MdeModulePkg.dec
>    IntelFsp2Pkg/IntelFsp2Pkg.dec
>=20
>  [LibraryClasses]
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> index 17924b118c..1d9c2554d1 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> @@ -35,7 +35,6 @@ [Binaries.Ia32]
>=20
>  [Packages]
>    MdePkg/MdePkg.dec
> -  MdeModulePkg/MdeModulePkg.dec
>    IntelFsp2Pkg/IntelFsp2Pkg.dec
>=20
>  [LibraryClasses]
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
> index e66ea4593b..6f65e69e77 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
> @@ -34,7 +34,6 @@ [Binaries.Ia32]
>=20
>  [Packages]
>    MdePkg/MdePkg.dec
> -  MdeModulePkg/MdeModulePkg.dec
>    IntelFsp2Pkg/IntelFsp2Pkg.dec
>=20
>  [LibraryClasses]
> --
> 2.21.0.windows.1