* Re: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg dependency
2019-08-27 22:40 [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg dependency Ni, Ray
@ 2019-08-27 23:18 ` Nate DeSimone
2019-08-27 23:20 ` Nate DeSimone
2019-08-28 0:42 ` Zeng, Star
2 siblings, 0 replies; 5+ messages in thread
From: Nate DeSimone @ 2019-08-27 23:18 UTC (permalink / raw)
To: Ni, Ray, devel@edk2.groups.io; +Cc: Chiu, Chasel, Zeng, Star
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Ni, Ray
Sent: Tuesday, August 27, 2019 3:41 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg dependency
Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 - IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 1 - IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf | 1 -
3 files changed, 3 deletions(-)
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
index 571ed9bc44..25f2a109ab 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
@@ -40,7 +40,6 @@ [Binaries.Ia32]
[Packages]
MdePkg/MdePkg.dec
- MdeModulePkg/MdeModulePkg.dec
IntelFsp2Pkg/IntelFsp2Pkg.dec
[LibraryClasses]
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
index 17924b118c..1d9c2554d1 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
@@ -35,7 +35,6 @@ [Binaries.Ia32]
[Packages]
MdePkg/MdePkg.dec
- MdeModulePkg/MdeModulePkg.dec
IntelFsp2Pkg/IntelFsp2Pkg.dec
[LibraryClasses]
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
index e66ea4593b..6f65e69e77 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
@@ -34,7 +34,6 @@ [Binaries.Ia32]
[Packages]
MdePkg/MdePkg.dec
- MdeModulePkg/MdeModulePkg.dec
IntelFsp2Pkg/IntelFsp2Pkg.dec
[LibraryClasses]
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg dependency
2019-08-27 22:40 [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg dependency Ni, Ray
2019-08-27 23:18 ` Nate DeSimone
@ 2019-08-27 23:20 ` Nate DeSimone
2019-08-28 0:01 ` Chiu, Chasel
2019-08-28 0:42 ` Zeng, Star
2 siblings, 1 reply; 5+ messages in thread
From: Nate DeSimone @ 2019-08-27 23:20 UTC (permalink / raw)
To: Ni, Ray, devel@edk2.groups.io; +Cc: Chiu, Chasel, Zeng, Star
Actually, please make sure you update copyright year on FspSecCoreT.inf. With that change...
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Ni, Ray
Sent: Tuesday, August 27, 2019 3:41 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg dependency
Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 - IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 1 - IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf | 1 -
3 files changed, 3 deletions(-)
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
index 571ed9bc44..25f2a109ab 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
@@ -40,7 +40,6 @@ [Binaries.Ia32]
[Packages]
MdePkg/MdePkg.dec
- MdeModulePkg/MdeModulePkg.dec
IntelFsp2Pkg/IntelFsp2Pkg.dec
[LibraryClasses]
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
index 17924b118c..1d9c2554d1 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
@@ -35,7 +35,6 @@ [Binaries.Ia32]
[Packages]
MdePkg/MdePkg.dec
- MdeModulePkg/MdeModulePkg.dec
IntelFsp2Pkg/IntelFsp2Pkg.dec
[LibraryClasses]
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
index e66ea4593b..6f65e69e77 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
@@ -34,7 +34,6 @@ [Binaries.Ia32]
[Packages]
MdePkg/MdePkg.dec
- MdeModulePkg/MdeModulePkg.dec
IntelFsp2Pkg/IntelFsp2Pkg.dec
[LibraryClasses]
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg dependency
2019-08-27 23:20 ` Nate DeSimone
@ 2019-08-28 0:01 ` Chiu, Chasel
0 siblings, 0 replies; 5+ messages in thread
From: Chiu, Chasel @ 2019-08-28 0:01 UTC (permalink / raw)
To: Desimone, Nathaniel L, Ni, Ray, devel@edk2.groups.io; +Cc: Zeng, Star
Same findings as Nate, with FspSecCoreT.inf copyright updated, Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Desimone, Nathaniel L
> Sent: Wednesday, August 28, 2019 7:21 AM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: RE: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded
> MdeModulePkg dependency
>
> Actually, please make sure you update copyright year on FspSecCoreT.inf. With
> that change...
>
> Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
>
> -----Original Message-----
> From: Ni, Ray
> Sent: Tuesday, August 27, 2019 3:41 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg
> dependency
>
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
> IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 -
> IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 1 -
> IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> index 571ed9bc44..25f2a109ab 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> @@ -40,7 +40,6 @@ [Binaries.Ia32]
>
> [Packages]
> MdePkg/MdePkg.dec
> - MdeModulePkg/MdeModulePkg.dec
> IntelFsp2Pkg/IntelFsp2Pkg.dec
>
> [LibraryClasses]
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> index 17924b118c..1d9c2554d1 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> @@ -35,7 +35,6 @@ [Binaries.Ia32]
>
> [Packages]
> MdePkg/MdePkg.dec
> - MdeModulePkg/MdeModulePkg.dec
> IntelFsp2Pkg/IntelFsp2Pkg.dec
>
> [LibraryClasses]
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
> index e66ea4593b..6f65e69e77 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
> @@ -34,7 +34,6 @@ [Binaries.Ia32]
>
> [Packages]
> MdePkg/MdePkg.dec
> - MdeModulePkg/MdeModulePkg.dec
> IntelFsp2Pkg/IntelFsp2Pkg.dec
>
> [LibraryClasses]
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg dependency
2019-08-27 22:40 [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded MdeModulePkg dependency Ni, Ray
2019-08-27 23:18 ` Nate DeSimone
2019-08-27 23:20 ` Nate DeSimone
@ 2019-08-28 0:42 ` Zeng, Star
2 siblings, 0 replies; 5+ messages in thread
From: Zeng, Star @ 2019-08-28 0:42 UTC (permalink / raw)
To: Ni, Ray, devel@edk2.groups.io
Cc: Chiu, Chasel, Desimone, Nathaniel L, Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
> -----Original Message-----
> From: Ni, Ray
> Sent: Wednesday, August 28, 2019 6:41 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded
> MdeModulePkg dependency
>
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
> IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 -
> IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 1 -
> IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> index 571ed9bc44..25f2a109ab 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> @@ -40,7 +40,6 @@ [Binaries.Ia32]
>
> [Packages]
> MdePkg/MdePkg.dec
> - MdeModulePkg/MdeModulePkg.dec
> IntelFsp2Pkg/IntelFsp2Pkg.dec
>
> [LibraryClasses]
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> index 17924b118c..1d9c2554d1 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> @@ -35,7 +35,6 @@ [Binaries.Ia32]
>
> [Packages]
> MdePkg/MdePkg.dec
> - MdeModulePkg/MdeModulePkg.dec
> IntelFsp2Pkg/IntelFsp2Pkg.dec
>
> [LibraryClasses]
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
> index e66ea4593b..6f65e69e77 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
> @@ -34,7 +34,6 @@ [Binaries.Ia32]
>
> [Packages]
> MdePkg/MdePkg.dec
> - MdeModulePkg/MdeModulePkg.dec
> IntelFsp2Pkg/IntelFsp2Pkg.dec
>
> [LibraryClasses]
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread