From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: chasel.chiu@intel.com)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by groups.io with SMTP; Mon, 02 Sep 2019 07:06:39 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
  by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 07:06:38 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,459,1559545200"; 
   d="scan'208";a="184505944"
Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88])
  by orsmga003.jf.intel.com with ESMTP; 02 Sep 2019 07:06:37 -0700
Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by
 KMSMSX153.gar.corp.intel.com ([169.254.5.69]) with mapi id 14.03.0439.000;
 Mon, 2 Sep 2019 22:06:36 +0800
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Kubacki, Michael A" <michael.a.kubacki@intel.com>, "Desimone, Nathaniel
 L" <nathaniel.l.desimone@intel.com>, "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] MinPlatformPkg/TestPointCheckLib: Add check for pointer Variable
Thread-Topic: [PATCH] MinPlatformPkg/TestPointCheckLib: Add check for
 pointer Variable
Thread-Index: AQHVYYraPlve5Oq5V0q0wVLiz5BRU6cYbAug
Date: Mon, 2 Sep 2019 14:06:36 +0000
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5047E785@PGSMSX111.gar.corp.intel.com>
References: <20190902123452.27716-1-shenglei.zhang@intel.com>
 <20190902123452.27716-4-shenglei.zhang@intel.com>
In-Reply-To: <20190902123452.27716-4-shenglei.zhang@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDhkOWMxMTMtMDAyYS00NGY4LWE3YjgtYjg4MmU5Y2FmMDViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRW9MNVwvNmp4cWZYaEhpZ1FBWlRJZlFUcHFLVURBMWlJYk16QklPZEIycFVLdno3Wkh2M01lR1ZzOUsrXC9wN2l0In0=
x-ctpclassification: CTP_NT
x-originating-ip: [172.30.20.205]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


Please extend copyright, with this update Reviewed-by: Chasel Chiu <chasel.=
chiu@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Monday, September 2, 2019 8:35 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MinPlatformPkg/TestPointCheckLib: Add check for pointer
> Variable
>=20
> Add check for pointer Variable to ensure it is not NULL when used.
>=20
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  .../Test/Library/TestPointCheckLib/DxeCheckUefiSecureBoot.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>=20
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckU
> efiSecureBoot.c
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckU
> efiSecureBoot.c
> index b53a09ab..f5125ede 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckU
> efiSecureBoot.c
> +++
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckU
> efiSecureBoot.c
> @@ -52,6 +52,9 @@ TestPointCheckUefiSecureBoot (
>    ReturnStatus =3D EFI_SUCCESS;
>    for (Index =3D 0; Index <
> sizeof(mUefiSecureBootVariable)/sizeof(mUefiSecureBootVariable[0]);
> Index++) {
>      Status =3D GetVariable2 (mUefiSecureBootVariable[Index].Name,
> mUefiSecureBootVariable[Index].Guid, &Variable, &Size);
> +    if(Variable =3D=3D NULL) {
> +      return EFI_NOT_FOUND;
> +    }
>      if (EFI_ERROR(Status)) {
>        DEBUG ((DEBUG_ERROR, "Variable - %S not found\n",
> mUefiSecureBootVariable[Index].Name));
>        ReturnStatus =3D Status;
> @@ -69,6 +72,9 @@ TestPointCheckUefiSecureBoot (
>=20
>    for (Index =3D 0; Index <
> sizeof(mUefiSecureBootModeVariable)/sizeof(mUefiSecureBootModeVariabl
> e[0]); Index++) {
>      Status =3D GetVariable2 (mUefiSecureBootModeVariable[Index].Name,
> mUefiSecureBootModeVariable[Index].Guid, &Variable, &Size);
> +    if(Variable =3D=3D NULL) {
> +      return EFI_NOT_FOUND;
> +    }
>      if (EFI_ERROR(Status)) {
>        DEBUG ((DEBUG_ERROR, "Variable - %S not found\n",
> mUefiSecureBootModeVariable[Index].Name));
>        ReturnStatus =3D Status;
> --
> 2.18.0.windows.1