From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: chasel.chiu@intel.com)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by groups.io with SMTP; Wed, 04 Sep 2019 22:02:03 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
  by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2019 22:02:02 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,469,1559545200"; 
   d="scan'208";a="173815777"
Received: from kmsmsx155.gar.corp.intel.com ([172.21.73.106])
  by orsmga007.jf.intel.com with ESMTP; 04 Sep 2019 22:02:01 -0700
Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by
 KMSMSX155.gar.corp.intel.com ([169.254.15.65]) with mapi id 14.03.0439.000;
 Thu, 5 Sep 2019 13:02:00 +0800
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Agyeman, Prince" <prince.agyeman@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Sinha, Ankit" <ankit.sinha@intel.com>, "Desimone, Nathaniel L"
	<nathaniel.l.desimone@intel.com>, "Kubacki, Michael A"
	<michael.a.kubacki@intel.com>, "Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [edk2-platforms] [PATCH v2] ClevoOpenBoardPkg: Fix GCC5 build issue
Thread-Topic: [edk2-platforms] [PATCH v2] ClevoOpenBoardPkg: Fix GCC5 build
 issue
Thread-Index: AQHVYzgqXUMeXnTBckG4vdnb4DO7g6cch5Fg
Date: Thu, 5 Sep 2019 05:02:00 +0000
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC50481FEC@PGSMSX111.gar.corp.intel.com>
References: <3ba8ea19214a11534628c53ed3eec9861738b23d.1567611584.git.prince.agyeman@intel.com>
In-Reply-To: <3ba8ea19214a11534628c53ed3eec9861738b23d.1567611584.git.prince.agyeman@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzRkOGZiMTEtMTQxZC00NzNkLTlmNTgtNDZlMGRlMDljZGIxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidG1sRlRKK1JGNlc0eHRGSVFONDNHMHRaeGRKM05qWmpTaGk1NnJqc1wvcmJwZ2l2S255ZUpcL2RwMmNIcXVJajVRIn0=
x-ctpclassification: CTP_NT
x-originating-ip: [172.30.20.206]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Agyeman, Prince
> Sent: Wednesday, September 4, 2019 11:48 PM
> To: devel@edk2.groups.io
> Cc: Agyeman, Prince <prince.agyeman@intel.com>; Sinha, Ankit
> <ankit.sinha@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Bi,
> Dandan <dandan.bi@intel.com>
> Subject: [edk2-platforms] [PATCH v2] ClevoOpenBoardPkg: Fix GCC5 build
> issue
>=20
> From: Agyeman <prince.agyeman@intel.com>
>=20
> Fixed GPIO table missing curly brackets
>=20
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> CC: Dandan Bi <dandan.bi@intel.com>
>=20
> Signed-off-by: Agyeman <prince.agyeman@intel.com>
> ---
>  .../N1xxWU/Library/BoardInitLib/N1xxWUGpioTable.c               | 2
> +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git
> a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxW
> UGpioTable.c
> b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxW
> UGpioTable.c
> index c99b83753f..27f70df001 100644
> ---
> a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxW
> UGpioTable.c
> +++
> b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxW
> UGpioTable.c
> @@ -155,7 +155,7 @@ GPIO_INIT_CONFIG mGpioTableN1xxWU[] =3D
>    {GPIO_SKL_LP_GPP_C16, {GpioPadModeGpio,    GpioHostOwnGpio,
> GpioDirOut,     GpioOutLow,     GpioIntDis, GpioHostDeepReset,
> GpioTermNone}}, //I2C0_SDA
>    {GPIO_SKL_LP_GPP_C17, {GpioPadModeGpio,    GpioHostOwnGpio,
> GpioDirOut,     GpioOutDefault, GpioIntDis, GpioHostDeepReset,
> GpioTermNone}}, //I2C0_SCL
>    {GPIO_SKL_LP_GPP_C18, {GpioPadModeGpio,    GpioHostOwnGpio,
> GpioDirOut,     GpioOutDefault, GpioIntDis, GpioHostDeepReset,
> GpioTermNone}}, //I2C1_SDA
> -  {GPIO_SKL_LP_GPP_C19, GpioPadModeGpio,     GpioHostOwnAcpi,
> GpioDirInInv,   GpioOutDefault, GpioIntLevel | GpioIntSci,
> GpioHostDeepReset, GpioTermNone}, //I2C1_SCL
> +  {GPIO_SKL_LP_GPP_C19, {GpioPadModeGpio,    GpioHostOwnAcpi,
> GpioDirInInv,   GpioOutDefault, GpioIntLevel | GpioIntSci,
> GpioHostDeepReset, GpioTermNone}}, //I2C1_SCL
>    {GPIO_SKL_LP_GPP_C20, {GpioPadModeNative1, GpioHostOwnDefault,
> GpioDirDefault, GpioOutLow,     GpioIntDis, GpioHostDeepReset,
> GpioTermNone}}, //UART2_RXD
>    {GPIO_SKL_LP_GPP_C21, {GpioPadModeNative1, GpioHostOwnDefault,
> GpioDirDefault, GpioOutDefault, GpioIntDis, GpioHostDeepReset,
> GpioTermNone}}, //UART2_TXD
>    {GPIO_SKL_LP_GPP_C22, {GpioPadModeNative1, GpioHostOwnDefault,
> GpioDirNone,    GpioOutDefault, GpioIntDis, GpioHostDeepReset,
> GpioTermNone}}, //UART2_RTSB
> --
> 2.19.1.windows.1