From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: chasel.chiu@intel.com)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by groups.io with SMTP; Sun, 15 Sep 2019 19:17:38 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
  by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Sep 2019 19:17:38 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,510,1559545200"; 
   d="scan'208";a="187024180"
Received: from pgsmsx113.gar.corp.intel.com ([10.108.55.202])
  by fmsmga007.fm.intel.com with ESMTP; 15 Sep 2019 19:17:37 -0700
Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.128]) by
 pgsmsx113.gar.corp.intel.com ([169.254.6.69]) with mapi id 14.03.0439.000;
 Mon, 16 Sep 2019 10:17:37 +0800
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Kubacki, Michael A" <michael.a.kubacki@intel.com>, "Desimone, Nathaniel
 L" <nathaniel.l.desimone@intel.com>, "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL
Thread-Topic: [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add return value
 when OutTable is NULL
Thread-Index: AQHVbCtaswSymv6saEa21W+O7OzkqactkVdw
Date: Mon, 16 Sep 2019 02:17:36 +0000
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504CFF1B@PGSMSX111.gar.corp.intel.com>
References: <20190916010857.42264-1-shenglei.zhang@intel.com>
In-Reply-To: <20190916010857.42264-1-shenglei.zhang@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDE2MzAyZTctZmQyMi00OTlmLWEwY2MtNzg0YzA0OTA0MmZmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT3FwbTlwWWZSb1hcL2pnbCt0d1hcL2JyWHRWeUlIZ1k3Y0RQbGU2eFo2dzR6NVBZQkgrbUpqWGdaZnBRRTZjWjZtIn0=
x-ctpclassification: CTP_NT
x-originating-ip: [172.30.20.206]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Monday, September 16, 2019 9:09 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add return value
> when OutTable is NULL
>=20
> Currently there is no check for the parameter OutTable.
> So add the logic that return value EFI_INVALID_PARAMETER when the
> OutTable is NULL.
>=20
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>=20
> v2:Update the copyright and the if...else statement coding style.
>=20
>  .../Test/Library/TestPointCheckLib/DxeCheckAcpi.c           | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckA
> cpi.c
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckA
> cpi.c
> index 263781a2..83736bf3 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckA
> cpi.c
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh
> +++ eckAcpi.c
> @@ -1,6 +1,6 @@
>  /** @file
>=20
> -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
>=20
>  **/
> @@ -610,6 +610,8 @@ DumpAcpiRsdt (
>=20
>    if (OutTable !=3D NULL) {
>      *OutTable =3D NULL;
> +  } else{
> +    return EFI_INVALID_PARAMETER;
>    }
>=20
>    ReturnStatus =3D EFI_SUCCESS;
> @@ -663,6 +665,8 @@ DumpAcpiXsdt (
>=20
>    if (OutTable !=3D NULL) {
>      *OutTable =3D NULL;
> +  } else{
> +    return EFI_INVALID_PARAMETER;
>    }
>=20
>    ReturnStatus =3D EFI_SUCCESS;
> --
> 2.18.0.windows.1