From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: chasel.chiu@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Wed, 25 Sep 2019 02:53:03 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 02:53:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,547,1559545200"; d="scan'208";a="179767695" Received: from pgsmsx114.gar.corp.intel.com ([10.108.55.203]) by orsmga007.jf.intel.com with ESMTP; 25 Sep 2019 02:53:01 -0700 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.2]) by pgsmsx114.gar.corp.intel.com ([169.254.4.250]) with mapi id 14.03.0439.000; Wed, 25 Sep 2019 17:52:53 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Sinha, Ankit" , Jeremy Soller Subject: Re: [edk2-platforms][PATCH V2 06/15] KabylakeOpenBoardPkg: Move flash map to board Thread-Topic: [edk2-platforms][PATCH V2 06/15] KabylakeOpenBoardPkg: Move flash map to board Thread-Index: AQHVcwPXheiVJBekGUaGvGpldtl7u6c8J98g Date: Wed, 25 Sep 2019 09:52:52 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504E21AA@PGSMSX112.gar.corp.intel.com> References: <20190924181248.12816-1-michael.a.kubacki@intel.com> <20190924181248.12816-7-michael.a.kubacki@intel.com> In-Reply-To: <20190924181248.12816-7-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWI2ZWY3Y2MtNDViYy00NTM3LWE1YWItMmFjZDkyMGQ4ZDQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRGJJOGJmSit4dlRFUmMxNlZkeWk1emtuXC8rbkloVnpnaG1hUVZNeXBieUhTZmZDK2hxa2l6TzRQZ3o1RnJTSlcifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Wednesday, September 25, 2019 2:13 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-platforms][PATCH V2 06/15] KabylakeOpenBoardPkg: Move > flash map to board >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2207 >=20 > The flash map currently in KabylakeOpenBoardPkg is only applicable to the > KabylakeRvp3 board. This change moves the flash map to that board > directory to prepare for other boards to reside in the package. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Ankit Sinha > Cc: Jeremy Soller > Signed-off-by: Michael Kubacki > --- > Platform/Intel/KabylakeOpenBoardPkg/{ =3D> > KabylakeRvp3}/Include/Fdf/FlashMapInclude.fdf | 0 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > | 2 +- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > | 2 +- > 3 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Include/Fdf/FlashMapInclude.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMa > pInclude.fdf > similarity index 100% > rename from > Platform/Intel/KabylakeOpenBoardPkg/Include/Fdf/FlashMapInclude.fdf > rename to > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMapI > nclude.fdf > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > index 7267d478ad..2b8eab36a1 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > @@ -8,7 +8,7 @@ > ## >=20 > [Defines] > - !include > $(PLATFORM_BOARD_PACKAGE)/Include/Fdf/FlashMapInclude.fdf > + !include $(PROJECT)/Include/Fdf/FlashMapInclude.fdf >=20 >=20 > ################################################################ > ################ > # > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > index ab1a9a61c2..78f808bfaf 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > @@ -13,7 +13,7 @@ openssl_path =3D > PLATFORM_BOARD_PACKAGE =3D KabylakeOpenBoardPkg PROJECT =3D > KabylakeOpenBoardPkg/KabylakeRvp3 BOARD =3D KabylakeRvp3 > -FLASH_MAP_FDF =3D > KabylakeOpenBoardPkg/Include/Fdf/FlashMapInclude.fdf > +FLASH_MAP_FDF =3D > +KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMapInclude.fdf > PROJECT_DSC =3D KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > BOARD_PKG_PCD_DSC =3D > KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc > ADDITIONAL_SCRIPTS =3D > KabylakeOpenBoardPkg/KabylakeRvp3/build_board.py > -- > 2.16.2.windows.1