From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: chasel.chiu@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Wed, 25 Sep 2019 02:58:40 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 02:58:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,547,1559545200"; d="scan'208";a="203582700" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by fmsmga001.fm.intel.com with ESMTP; 25 Sep 2019 02:58:38 -0700 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.2]) by KMSMSX153.gar.corp.intel.com ([169.254.5.31]) with mapi id 14.03.0439.000; Wed, 25 Sep 2019 17:58:37 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Sinha, Ankit" , Jeremy Soller Subject: Re: [edk2-platforms][PATCH V2 11/15] KabylakeOpenBoardPkg: Consolidate board IDs in a single file Thread-Topic: [edk2-platforms][PATCH V2 11/15] KabylakeOpenBoardPkg: Consolidate board IDs in a single file Thread-Index: AQHVcwPaMNeg56QuBE+evv1bdXjUIKc8KXNg Date: Wed, 25 Sep 2019 09:58:37 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504E2219@PGSMSX112.gar.corp.intel.com> References: <20190924181248.12816-1-michael.a.kubacki@intel.com> <20190924181248.12816-12-michael.a.kubacki@intel.com> In-Reply-To: <20190924181248.12816-12-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWIyZTgxZTMtM2U5NC00NWJjLWE0OWItMmQ3NGFjZjFkYzMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS3cxOFJxM0RHRVwveXhhUVUyclRGQmI3WnFtRGR2b3RKdkJNdGRGaHc5Y1R5RFhZOTRRR1h4ZXY1d1RmckZqSXEifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Wednesday, September 25, 2019 2:13 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-platforms][PATCH V2 11/15] KabylakeOpenBoardPkg: > Consolidate board IDs in a single file >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2207 >=20 > Moves all Kaby Lake board ID definitions into a single header file so it = is > easier to maintain the values and include the values into common package > files that need to make decisions based on board ID. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Ankit Sinha > Cc: Jeremy Soller > Signed-off-by: Michael Kubacki > --- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/GalagoPro3Id.h > | 13 --------- >=20 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/Pei > GalagoPro3InitLib.h | 2 +- > Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h > | 29 ++++++++++++++++++++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/KabylakeRvp3I > d.h | 15 ---------- >=20 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiKabylakeRvp3InitLib.h | 2 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Dx > eGalagoPro3AcpiTableLib.c | 2 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Dx > eMultiBoardAcpiSupportLib.c | 2 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Sm > mGalagoPro3AcpiEnableLib.c | 2 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Sm > mMultiBoardAcpiSupportLib.c | 2 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/Pei > MultiBoardInitPostMemLib.c | 2 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/Pei > MultiBoardInitPreMemLib.c | 2 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeKabylakeRvp3AcpiTableLib.c | 6 ++-- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.c | 2 +- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmKabylakeRvp3AcpiEnableLib.c | 4 +-- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmMultiBoardAcpiSupportLib.c | 2 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiBoardInitPreMemLib.c | 2 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiMultiBoardInitPostMemLib.c | 2 +- >=20 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiMultiBoardInitPreMemLib.c | 2 +- > 18 files changed, 47 insertions(+), 46 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/GalagoPro3Id. > h > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/GalagoPro3Id. > h > deleted file mode 100644 > index d85a7dcf52..0000000000 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/GalagoPro3Id. > h > +++ /dev/null > @@ -1,13 +0,0 @@ > -/** @file > - > -Copyright (c) 2019, Intel Corporation. All rights reserved.
> -SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef _GALAGO_PRO_3_ID_H_ > -#define _GALAGO_PRO_3_ID_H_ > - > -#define BoardIdGalagoPro3 0x20 > - > -#endif > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiGalagoPro3InitLib.h > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiGalagoPro3InitLib.h > index 81d99f7295..742b5f5e04 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiGalagoPro3InitLib.h > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLi > +++ b/PeiGalagoPro3InitLib.h > @@ -18,7 +18,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > extern const UINT8 mDqByteMapSklRvp3[2][6][2]; extern const UINT8 > mDqsMapCpu2DramSklRvp3[2][8]; diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h > b/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h > new file mode 100644 > index 0000000000..e83c56252d > --- /dev/null > +++ b/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h > @@ -0,0 +1,29 @@ > +/** @file > +Kaby Lake Platform Board Identifiers > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +#ifndef _PLATFORM_BOARD_ID_H_ > +#define _PLATFORM_BOARD_ID_H_ > + > +#define FlavorUnknown 0x0 > +#define FlavorMobile 0x1 > +#define FlavorDesktop 0x2 > +#define FlavorWorkstation 0x3 > +#define FlavorUpServer 0x4 > +#define FlavorEmbedded 0x5 > +#define FlavorPlatformMax 0x6 > + > +#define TypeUnknown 0x0 > +#define TypeTrad 0x1 > +#define TypeUltUlx 0x2 > + > +#define BoardIdSkylakeRvp3 0x4 > +#define BoardIdGalagoPro3 0x20 > +#define BoardIdKabyLakeYLpddr3Rvp3 0x60 > + > +#define BoardIdUnknown1 0xffff > + > +#endif > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/KabylakeRvp > 3Id.h > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/KabylakeRvp > 3Id.h > deleted file mode 100644 > index 3b6397af1f..0000000000 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/KabylakeRvp > 3Id.h > +++ /dev/null > @@ -1,15 +0,0 @@ > -/** @file > - > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> -SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef _KABYLAKE_RVP3_ID_H_ > -#define _KABYLAKE_RVP3_ID_H_ > - > -// PUT SKL CRB BoardIds here > -#define BoardIdSkylakeRvp3 0x4 > -#define BoardIdKabyLakeYLpddr3Rvp3 0x60 > - > -#endif // _PEI_KABYLAKE_RVP3_BOARD_INIT_LIB_H_ > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiKabylakeRvp3InitLib.h > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib > /PeiKabylakeRvp3InitLib.h > index bd60720137..5b2ccf6b0d 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiKabylakeRvp3InitLib.h > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit > +++ Lib/PeiKabylakeRvp3InitLib.h > @@ -18,7 +18,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > extern const UINT8 mDqByteMapSklRvp3[2][6][2]; extern const UINT8 > mDqsMapCpu2DramSklRvp3[2][8]; diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeGalagoPro3AcpiTableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeGalagoPro3AcpiTableLib.c > index 76a8da9cda..b9386d59b8 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeGalagoPro3AcpiTableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/DxeGalagoPro3AcpiTableLib.c > @@ -18,7 +18,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > GLOBAL_REMOVE_IF_UNREFERENCED EFI_GLOBAL_NVS_AREA_PROTOCOL > mGlobalNvsArea; >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.c > index 639524c7d0..42440b6b14 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/DxeMultiBoardAcpiSupportLib.c > @@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/S > mmGalagoPro3AcpiEnableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > SmmGalagoPro3AcpiEnableLib.c > index ee897e422a..265c00551a 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/S > mmGalagoPro3AcpiEnableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/SmmGalagoPro3AcpiEnableLib.c > @@ -15,7 +15,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/S > mmMultiBoardAcpiSupportLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > SmmMultiBoardAcpiSupportLib.c > index c4c1e116c8..8eec028324 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/S > mmMultiBoardAcpiSupportLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/SmmMultiBoardAcpiSupportLib.c > @@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiMultiBoardInitPostMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiMultiBoardInitPostMemLib.c > index 5ddf04dece..2ef12ea399 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiMultiBoardInitPostMemLib.c > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLi > +++ b/PeiMultiBoardInitPostMemLib.c > @@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiMultiBoardInitPreMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiMultiBoardInitPreMemLib.c > index 12e03b37cb..a21246444c 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiMultiBoardInitPreMemLib.c > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLi > +++ b/PeiMultiBoardInitPreMemLib.c > @@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeKabylakeRvp3AcpiTableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeKabylakeRvp3AcpiTableLib.c > index e65742559a..154d859090 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeKabylakeRvp3AcpiTableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeKabylakeRvp3AcpiTableLib.c > @@ -1,7 +1,7 @@ > /** @file > Platform Hook Library instances >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -18,7 +18,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > GLOBAL_REMOVE_IF_UNREFERENCED EFI_GLOBAL_NVS_AREA_PROTOCOL > mGlobalNvsArea; >=20 > @@ -43,7 +43,7 @@ KabylakeRvp3UpdateGlobalNvs ( > mGlobalNvsArea.Area->PowerState =3D 1; // AC =3D1; for mobile platform= , > will update this value in SmmPlatform.c >=20 > mGlobalNvsArea.Area->NativePCIESupport =3D PcdGet8 > (PcdPciExpNative); > - > + > // > // Enable APIC > // > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeMultiBoardAcpiSupportLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeMultiBoardAcpiSupportLib.c > index 4da685d0ac..0c78342a1d 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeMultiBoardAcpiSupportLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeMultiBoardAcpiSupportLib.c > @@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmKabylakeRvp3AcpiEnableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/SmmKabylakeRvp3AcpiEnableLib.c > index 71c6e230fa..c9d0cda831 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmKabylakeRvp3AcpiEnableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/SmmKabylakeRvp3AcpiEnableLib.c > @@ -1,7 +1,7 @@ > /** @file > Platform Hook Library instances >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -15,7 +15,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmMultiBoardAcpiSupportLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/SmmMultiBoardAcpiSupportLib.c > index 4a120e14eb..96eaf6e6e8 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmMultiBoardAcpiSupportLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/SmmMultiBoardAcpiSupportLib.c > @@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiBoardInitPreMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib > /PeiBoardInitPreMemLib.c > index 464f67e036..f1829c287d 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiBoardInitPreMemLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit > +++ Lib/PeiBoardInitPreMemLib.c > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include #include > -#include > +#include >=20 > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiMultiBoardInitPostMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib > /PeiMultiBoardInitPostMemLib.c > index cc800b552b..72cdeaa0b2 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiMultiBoardInitPostMemLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit > +++ Lib/PeiMultiBoardInitPostMemLib.c > @@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiMultiBoardInitPreMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib > /PeiMultiBoardInitPreMemLib.c > index 843ae9890c..3cf391c0bb 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiMultiBoardInitPreMemLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit > +++ Lib/PeiMultiBoardInitPreMemLib.c > @@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include >=20 > -#include > +#include >=20 > EFI_STATUS > EFIAPI > -- > 2.16.2.windows.1