From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: chasel.chiu@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Wed, 25 Sep 2019 02:59:35 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 02:59:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,547,1559545200"; d="scan'208";a="188736942" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga008.fm.intel.com with ESMTP; 25 Sep 2019 02:59:34 -0700 Received: from pgsmsx110.gar.corp.intel.com (10.221.44.111) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 17:59:32 +0800 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.2]) by PGSMSX110.gar.corp.intel.com ([169.254.13.150]) with mapi id 14.03.0439.000; Wed, 25 Sep 2019 17:59:32 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Sinha, Ankit" , Jeremy Soller Subject: Re: [edk2-platforms][PATCH V2 12/15] KabylakeOpenBoardPkg: Add board ID to Global NVS Thread-Topic: [edk2-platforms][PATCH V2 12/15] KabylakeOpenBoardPkg: Add board ID to Global NVS Thread-Index: AQHVcwPaJb5p+Nh4dk6XpYjzb3884ac8KcnA Date: Wed, 25 Sep 2019 09:59:31 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504E2228@PGSMSX112.gar.corp.intel.com> References: <20190924181248.12816-1-michael.a.kubacki@intel.com> <20190924181248.12816-13-michael.a.kubacki@intel.com> In-Reply-To: <20190924181248.12816-13-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2UyMDM0YzAtYWUyZS00MWFlLTkzNGQtM2Y1NDJjNWJkZDBjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUGdNZWZvRmE1Z0dMa0d5ZUNZcnZ5a1FCYjlcL3JMUzYwWHlrMTF0SFlOb3QrSTI1b1hVTHhyc2FKdnd2dEhkQjgifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Return-Path: chasel.chiu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Wednesday, September 25, 2019 2:13 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-platforms][PATCH V2 12/15] KabylakeOpenBoardPkg: Add > board ID to Global NVS >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2207 >=20 > Adds the board ID as a field in global NVS (BDID) to allow ACPI code to t= ake > conditional actions based on the active board. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Ankit Sinha > Cc: Jeremy Soller > Signed-off-by: Michael Kubacki > --- > Platform/Intel/KabylakeOpenBoardPkg/Include/Acpi/GlobalNvsAreaDef.h > | 3 ++- >=20 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Dx > eGalagoPro3AcpiTableLib.c | 2 ++ >=20 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeKabylakeRvp3AcpiTableLib.c | 2 ++ > Platform/Intel/KabylakeOpenBoardPkg/Include/Acpi/GlobalNvs.asl > | 3 ++- > 4 files changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Include/Acpi/GlobalNvsAreaDef.h > b/Platform/Intel/KabylakeOpenBoardPkg/Include/Acpi/GlobalNvsAreaDef.h > index 93c5a0b55a..3d0a3f4ed8 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/Include/Acpi/GlobalNvsAreaDef.h > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/Include/Acpi/GlobalNvsAreaDef. > +++ h > @@ -1,7 +1,7 @@ > /** @file > ACPI DSDT table >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -111,6 +111,7 @@ typedef struct { > UINT8 TbtNativeOsHotPlug; ///< Offset 81 > TbtNativeOsHotPlug > UINT8 TbtSelector; ///< Offset 82 > Thunderbolt(TM) Root port selector > UINT8 TbtSelector1; ///< Offset 83 > Thunderbolt(TM) Root port selector > + UINT8 BoardId; ///< Offset 84 > Board ID > } EFI_GLOBAL_NVS_AREA; >=20 > #pragma pack(pop) > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeGalagoPro3AcpiTableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeGalagoPro3AcpiTableLib.c > index b9386d59b8..5b36f6dfb3 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeGalagoPro3AcpiTableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/DxeGalagoPro3AcpiTableLib.c > @@ -56,6 +56,8 @@ GalagoPro3UpdateGlobalNvs ( >=20 > mGlobalNvsArea.Area->Ps2MouseEnable =3D PcdGet8 > (PcdPs2KbMsEnable); > mGlobalNvsArea.Area->Ps2KbMsEnable =3D PcdGet8 > (PcdPs2KbMsEnable); > + > + mGlobalNvsArea.Area->BoardId =3D (UINT8) LibPcdGetSku (); > } >=20 > EFI_STATUS > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeKabylakeRvp3AcpiTableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeKabylakeRvp3AcpiTableLib.c > index 154d859090..eceac3d037 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeKabylakeRvp3AcpiTableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeKabylakeRvp3AcpiTableLib.c > @@ -56,6 +56,8 @@ KabylakeRvp3UpdateGlobalNvs ( >=20 > mGlobalNvsArea.Area->Ps2MouseEnable =3D FALSE; > mGlobalNvsArea.Area->Ps2KbMsEnable =3D PcdGet8 > (PcdPs2KbMsEnable); > + > + mGlobalNvsArea.Area->BoardId =3D (UINT8) LibPcdGetSku (); > } >=20 > EFI_STATUS > diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Include/Acpi/GlobalNvs.a= sl > b/Platform/Intel/KabylakeOpenBoardPkg/Include/Acpi/GlobalNvs.asl > index e0ff9d9bf5..92b4bc1e53 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/Include/Acpi/GlobalNvs.asl > +++ b/Platform/Intel/KabylakeOpenBoardPkg/Include/Acpi/GlobalNvs.asl > @@ -1,7 +1,7 @@ > /** @file > ACPI DSDT table >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -111,4 +111,5 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > Offset(81), TNAT, 8, // Offset(81), TbtNativeOsHotPlug > Offset(82), TBSE, 8, // Offset(82), Thunderbolt(TM) Root port > selector > Offset(83), TBS1, 8, // Offset(83), Thunderbolt(TM) Root port > selector > + Offset(84), BDID, 8, // Offset(84), Board ID > } > -- > 2.16.2.windows.1