Re: [edk2-platforms][PATCH V2 13/15] KabylakeOpenBoardPkg/BoardAcpiDxe: Add Synaptics PS/2 mouse

["Chiu, Chasel" <chasel.chiu@intel.com>]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Kubacki, Michael A <michael.a.kubacki@intel.com>
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>;
> Jeremy Soller <jeremy@system76.com>
> Subject: [edk2-platforms][PATCH V2 13/15]
> KabylakeOpenBoardPkg/BoardAcpiDxe: Add Synaptics PS/2 mouse
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207
> 
> Moves the Synaptics PS/2 mouse support required for the Galago Pro 3
> trackpad to function from the previous location in
> ClevoOpenBoardPkg/N1xxWU to the common ASL file in
> KabylakeOpenBoardPkg.
> The board ID is used to determine which PS/2 mouse device to expose.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>  Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl |
> 41 +++++++++++++++++++-
>  1 file changed, 39 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> index 9f9d39c92c..d934c20beb 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.as
> +++ l
> @@ -1,11 +1,12 @@
>  /** @file
>    ACPI DSDT table
> 
> -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> 
> +#include "PlatformBoardId.h"
> 
>  // LPC Bridge - Device 31, Function 0
>  scope (\_SB.PCI0.LPCB) {
> @@ -66,7 +67,43 @@ scope (\_SB.PCI0.LPCB) {
>            {
>              If (P2MK) //Ps2 Keyboard and Mouse Enable
>              {
> -              Return(0x000F)
> +              If (LNotEqual(BDID,BoardIdGalagoPro3))
> +              {
> +                Return(0x000F)
> +              }
> +            }
> +          }
> +          Return(0x0000)
> +        }
> +
> +        Name(_CRS,ResourceTemplate()
> +        {
> +          IRQ(Edge,ActiveHigh,Exclusive){0x0C}
> +        })
> +
> +        Name(_PRS, ResourceTemplate(){
> +          StartDependentFn(0, 0) {
> +          IRQNoFlags(){12}
> +          }
> +          EndDependentFn()
> +        })
> +      }
> +
> +      Device(SYNM)    // Synaptics Mouse
> +      {
> +        Name(_HID,"SYN1221")
> +        Name(_CID,EISAID("PNP0F13"))
> +
> +        Method(_STA)
> +        {
> +          If (P2ME) //Ps2 Mouse Enable
> +          {
> +            If (P2MK) //Ps2 Keyboard and Mouse Enable
> +            {
> +              If (LEqual(BDID,BoardIdGalagoPro3))
> +              {
> +                Return(0x000F)
> +              }
>              }
>            }
>            Return(0x0000)
> --
> 2.16.2.windows.1