From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: chasel.chiu@intel.com)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by groups.io with SMTP; Wed, 25 Sep 2019 03:01:20 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
  by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 03:01:19 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,547,1559545200"; 
   d="scan'208";a="340363116"
Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105])
  by orsmga004.jf.intel.com with ESMTP; 25 Sep 2019 03:01:17 -0700
Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.2]) by
 PGSMSX107.gar.corp.intel.com ([169.254.7.216]) with mapi id 14.03.0439.000;
 Wed, 25 Sep 2019 18:01:16 +0800
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Kubacki, Michael A" <michael.a.kubacki@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>, "Sinha, Ankit"
	<ankit.sinha@intel.com>, Jeremy Soller <jeremy@system76.com>
Subject: Re: [edk2-platforms][PATCH V2 13/15] KabylakeOpenBoardPkg/BoardAcpiDxe: Add Synaptics PS/2 mouse
Thread-Topic: [edk2-platforms][PATCH V2 13/15]
 KabylakeOpenBoardPkg/BoardAcpiDxe: Add Synaptics PS/2 mouse
Thread-Index: AQHVcwPbJR7cKK++ik6qyEoukePfzKc8KkNg
Date: Wed, 25 Sep 2019 10:01:15 +0000
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504E223B@PGSMSX112.gar.corp.intel.com>
References: <20190924181248.12816-1-michael.a.kubacki@intel.com>
 <20190924181248.12816-14-michael.a.kubacki@intel.com>
In-Reply-To: <20190924181248.12816-14-michael.a.kubacki@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2VlNWUxOWItZDI5Ny00NDE2LThmNjktODA4OGM3NjI2ZDdkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid0ZLZGpsS2hRNHdabndiWmVHQnlSZ01JZDNFWTNveG4rSnVmZURPb1hMS0d4ODkrNjNSNm5nTHA4U2FrYTBjNiJ9
x-ctpclassification: CTP_NT
x-originating-ip: [172.30.20.206]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Kubacki, Michael A <michael.a.kubacki@intel.com>
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>;
> Jeremy Soller <jeremy@system76.com>
> Subject: [edk2-platforms][PATCH V2 13/15]
> KabylakeOpenBoardPkg/BoardAcpiDxe: Add Synaptics PS/2 mouse
>=20
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2207
>=20
> Moves the Synaptics PS/2 mouse support required for the Galago Pro 3
> trackpad to function from the previous location in
> ClevoOpenBoardPkg/N1xxWU to the common ASL file in
> KabylakeOpenBoardPkg.
> The board ID is used to determine which PS/2 mouse device to expose.
>=20
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>  Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl |
> 41 +++++++++++++++++++-
>  1 file changed, 39 insertions(+), 2 deletions(-)
>=20
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> index 9f9d39c92c..d934c20beb 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.as
> +++ l
> @@ -1,11 +1,12 @@
>  /** @file
>    ACPI DSDT table
>=20
> -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
>=20
>  **/
>=20
> +#include "PlatformBoardId.h"
>=20
>  // LPC Bridge - Device 31, Function 0
>  scope (\_SB.PCI0.LPCB) {
> @@ -66,7 +67,43 @@ scope (\_SB.PCI0.LPCB) {
>            {
>              If (P2MK) //Ps2 Keyboard and Mouse Enable
>              {
> -              Return(0x000F)
> +              If (LNotEqual(BDID,BoardIdGalagoPro3))
> +              {
> +                Return(0x000F)
> +              }
> +            }
> +          }
> +          Return(0x0000)
> +        }
> +
> +        Name(_CRS,ResourceTemplate()
> +        {
> +          IRQ(Edge,ActiveHigh,Exclusive){0x0C}
> +        })
> +
> +        Name(_PRS, ResourceTemplate(){
> +          StartDependentFn(0, 0) {
> +          IRQNoFlags(){12}
> +          }
> +          EndDependentFn()
> +        })
> +      }
> +
> +      Device(SYNM)    // Synaptics Mouse
> +      {
> +        Name(_HID,"SYN1221")
> +        Name(_CID,EISAID("PNP0F13"))
> +
> +        Method(_STA)
> +        {
> +          If (P2ME) //Ps2 Mouse Enable
> +          {
> +            If (P2MK) //Ps2 Keyboard and Mouse Enable
> +            {
> +              If (LEqual(BDID,BoardIdGalagoPro3))
> +              {
> +                Return(0x000F)
> +              }
>              }
>            }
>            Return(0x0000)
> --
> 2.16.2.windows.1