From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Kubacki, Michael A" <michael.a.kubacki@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Sinha, Ankit" <ankit.sinha@intel.com>,
Jeremy Soller <jeremy@system76.com>
Subject: Re: [edk2-platforms][PATCH V2 15/15] Add GalagoPro3 board details to global build and documentation
Date: Wed, 25 Sep 2019 10:05:18 +0000 [thread overview]
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504E226D@PGSMSX112.gar.corp.intel.com> (raw)
In-Reply-To: <20190924181248.12816-16-michael.a.kubacki@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Kubacki, Michael A <michael.a.kubacki@intel.com>
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>;
> Jeremy Soller <jeremy@system76.com>
> Subject: [edk2-platforms][PATCH V2 15/15] Add GalagoPro3 board details to
> global build and documentation
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207
>
> * Updates maintainers for the System 76 GalagoPro3 board
> * Updated Readme.md with System 76 GalagoPro3 board details
> * Adds the ability to build the GalagoPro3 board to build.cfg
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
> Maintainers.txt | 3 ++
> Platform/Intel/Readme.md | 44 +++++++++++++-------
> Platform/Intel/build.cfg | 1 +
> 3 files changed, 34 insertions(+), 14 deletions(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt index a30ee2f602..1260c8d246
> 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -87,6 +87,9 @@ M: Chasel Chiu <chasel.chiu@intel.com>
> M: Michael Kubacki <michael.a.kubacki@intel.com>
> M: Nate DeSimone <nathaniel.l.desimone@intel.com>
>
> +Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3
> +R: Jeremy Soller <jeremy@system76.com>
> +
> Platform/Intel/MinPlatformPkg
> M: Michael Kubacki <michael.a.kubacki@intel.com>
> M: Chasel Chiu <chasel.chiu@intel.com>
> diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index
> 6a9b1d2e00..03fa4c2315 100644
> --- a/Platform/Intel/Readme.md
> +++ b/Platform/Intel/Readme.md
> @@ -83,6 +83,15 @@ A UEFI firmware implementation using
> MinPlatformPkg is constructed using the fol
> ----------------------------------------|--------------------------------------------|-------------------
> -----------|--------------------|
> | Simics Quick Start Package | Nehalem
> | SimicsOpenBoardPkg | BoardX58Ich10 |
>
> +#### System 76
> +
> +***Galago Pro Laptop***
> +
> +| Machine Name | Supported Chipsets
> | BoardPkg | Board Name |
> +----------------------------------------|--------------------------------------------|------------------
> ------------|--------------------|
> +| galp2 | Kaby Lake
> | KabylakeOpenBoardPkg | GalagoPro3 |
> +| galp3 & galp3-b | Kaby Lake Refresh
> | KabylakeOpenBoardPkg | GalagoPro3 |
> +
> ## Board Package Organization
> The board package follows the standard EDK II package structure with the
> following additional elements and guidelines:
> * Only code usable across more than one board at the root level.
> @@ -217,28 +226,31 @@ return back to the minimum platform caller.
> | | | post-build, and
> clean functions.
> | | |
> | | |------KabylakeOpenBoardPkg
> - | | | |------KabylakeRvp3
> - | | | |---build_config.cfg:
> KabylakeRvp3 specific
> - | | | |
> build settings, environment variables.
> - | | | |---build_board.py:
> Optional board-specific pre-build, build
> - | | |
> and clean post-build functions.
> + | | | |------GalagoPro3
> + | | | | |---build_config.cfg:
> System 76 Galago Pro 3 specific build
> + | | | |
> settings environment variables.
> + | | | |------KabylakeRvp3
> + | | | |---build_config.cfg:
> KabylakeRvp3 specific
> + | | | |
> build settings, environment variables.
> + | | | |---build_board.py:
> Optional board-specific pre-build, build
> + | | |
> and clean post-build functions.
> | | |
> | | |------PurleyOpenBoardPkg
> | | | |------BoardMtOlympus
> - | | | |---build_config.cfg:
> BoardMtOlympus specific
> - | | | |
> build settings, environment variables.
> - | | | |---build_board.py:
> Optional board-specific pre-build,
> - | | |
> build, post-build and clean functions.
> + | | | |---build_config.cfg:
> BoardMtOlympus specific
> + | | | |
> build settings, environment variables.
> + | | | |---build_board.py:
> Optional board-specific pre-build,
> + | | |
> build, post-build and clean functions.
> | | |
> | | |------SimicsOpenBoardPkg
> | | | |------BoardX58Ich10
> - | | | |---build_config.cfg:
> BoardX58Ich10 specific
> - | | | |
> build settings, environment variables.
> + | | | |---build_config.cfg:
> BoardX58Ich10 specific
> + | | |
> build settings, environment variables.
> | | |
> | | |------WhiskeylakeOpenBoardPkg
> - | | | |------WhiskeylakeURvp
> - | | | |---build_config.cfg:
> WhiskeylakeURvp specific build
> - | | |
> settings environment variables.
> + | | | |------WhiskeylakeURvp
> + | | | |---build_config.cfg:
> WhiskeylakeURvp specific build
> + | | |
> settings environment variables.
> | | |
> |------FSP
> </pre>
> @@ -263,6 +275,10 @@ errors.
> ### **Known limitations**
>
> **KabylakeOpenBoardPkg**
> +*GalagoPro3*
> +1. The firmware project has not been tested on the Galago Pro 3B.
> +
> +*KabylakeRvp3*
> 1. This firmware project has only been tested for Microsoft Windows 10 x64
> boot with AHCI mode and Integrated Graphic
> Device.
>
> diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index
> 04e8f4fa64..2040774d1b 100644
> --- a/Platform/Intel/build.cfg
> +++ b/Platform/Intel/build.cfg
> @@ -54,5 +54,6 @@ NUMBER_OF_PROCESSORS = 0 # board_name =
> path_to_board_build_config.cfg BoardMtOlympus =
> PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg
> BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
> +GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
> KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> WhiskeylakeURvp =
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
> --
> 2.16.2.windows.1
next prev parent reply other threads:[~2019-09-25 10:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 18:12 [edk2-platforms][PATCH V2 00/15] Move ClevoOpenBoardPkg/N1xxWU Contents to KabylakeOpenBoardPkg Kubacki, Michael A
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 01/15] Platform/Intel: Remove N1xxWU board build option Kubacki, Michael A
2019-09-25 9:49 ` [edk2-devel] " Chiu, Chasel
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 02/15] ClevoOpenBoardPkg: Remove package contents Kubacki, Michael A
2019-09-25 9:48 ` [edk2-devel] " Chiu, Chasel
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 03/15] ClevoOpenBoardPkg: Remove global files and references Kubacki, Michael A
2019-09-25 9:49 ` [edk2-devel] " Chiu, Chasel
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 04/15] KabylakeOpenBoardPkg: Move policy update libs to KabylakeRvp3 board Kubacki, Michael A
2019-09-25 9:50 ` Chiu, Chasel
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 05/15] KabylakeOpenBoardPkg: Move EcCommands.h " Kubacki, Michael A
2019-09-25 9:51 ` Chiu, Chasel
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 06/15] KabylakeOpenBoardPkg: Move flash map to board Kubacki, Michael A
2019-09-25 9:52 ` Chiu, Chasel
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 07/15] KabylakeOpenBoardPkg: Add PeiSerialPortLibSpiFlash Kubacki, Michael A
2019-09-25 9:53 ` Chiu, Chasel
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 08/15] KabylakeOpenBoardPkg/GalagoPro3: Add headers Kubacki, Michael A
2019-09-25 9:53 ` Chiu, Chasel
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 09/15] KabylakeOpenBoardPkg/GalagoPro3: Add library instances Kubacki, Michael A
2019-09-25 9:54 ` Chiu, Chasel
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 10/15] KabylakeOpenBoardPkg/GalagoPro3: Add modules Kubacki, Michael A
2019-09-25 9:54 ` Chiu, Chasel
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 11/15] KabylakeOpenBoardPkg: Consolidate board IDs in a single file Kubacki, Michael A
2019-09-25 9:58 ` Chiu, Chasel
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 12/15] KabylakeOpenBoardPkg: Add board ID to Global NVS Kubacki, Michael A
2019-09-25 9:59 ` Chiu, Chasel
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 13/15] KabylakeOpenBoardPkg/BoardAcpiDxe: Add Synaptics PS/2 mouse Kubacki, Michael A
2019-09-25 10:01 ` Chiu, Chasel
2019-09-25 22:36 ` Nate DeSimone
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 14/15] KabylakeOpenBoardPkg/GalagoPro3: Add build files Kubacki, Michael A
2019-09-25 10:04 ` Chiu, Chasel
2019-09-25 22:38 ` Nate DeSimone
2019-09-24 18:12 ` [edk2-platforms][PATCH V2 15/15] Add GalagoPro3 board details to global build and documentation Kubacki, Michael A
2019-09-25 10:05 ` Chiu, Chasel [this message]
2019-09-25 22:39 ` Nate DeSimone
2019-09-24 23:54 ` [edk2-devel] [edk2-platforms][PATCH V2 00/15] Move ClevoOpenBoardPkg/N1xxWU Contents to KabylakeOpenBoardPkg Sinha, Ankit
2019-09-25 21:01 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C3EFB470A303B4AB093197B6777CCEC504E226D@PGSMSX112.gar.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox