From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: chasel.chiu@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Wed, 25 Sep 2019 03:05:22 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 03:05:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,547,1559545200"; d="scan'208";a="364279307" Received: from pgsmsx113.gar.corp.intel.com ([10.108.55.202]) by orsmga005.jf.intel.com with ESMTP; 25 Sep 2019 03:05:20 -0700 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.2]) by pgsmsx113.gar.corp.intel.com ([169.254.6.69]) with mapi id 14.03.0439.000; Wed, 25 Sep 2019 18:05:19 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Sinha, Ankit" , Jeremy Soller Subject: Re: [edk2-platforms][PATCH V2 15/15] Add GalagoPro3 board details to global build and documentation Thread-Topic: [edk2-platforms][PATCH V2 15/15] Add GalagoPro3 board details to global build and documentation Thread-Index: AQHVcwPe1kwxTAsZAkCMa9e84TH3sac8K2eQ Date: Wed, 25 Sep 2019 10:05:18 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504E226D@PGSMSX112.gar.corp.intel.com> References: <20190924181248.12816-1-michael.a.kubacki@intel.com> <20190924181248.12816-16-michael.a.kubacki@intel.com> In-Reply-To: <20190924181248.12816-16-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGFhMjQ1YmUtMTU1Ny00MGQzLTkxMmItMzQ0MWIzMDMwZWNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVGVCSklWcFJKbGx1RHBseFgxdGxhKzVXWkFlcFRGMnZlVVVxR2xjVnFGYUFjUTlKUzI2NEFBVk9kSExVYVg1MiJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Wednesday, September 25, 2019 2:13 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-platforms][PATCH V2 15/15] Add GalagoPro3 board details to > global build and documentation >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2207 >=20 > * Updates maintainers for the System 76 GalagoPro3 board > * Updated Readme.md with System 76 GalagoPro3 board details > * Adds the ability to build the GalagoPro3 board to build.cfg >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Ankit Sinha > Cc: Jeremy Soller > Signed-off-by: Michael Kubacki > --- > Maintainers.txt | 3 ++ > Platform/Intel/Readme.md | 44 +++++++++++++------- > Platform/Intel/build.cfg | 1 + > 3 files changed, 34 insertions(+), 14 deletions(-) >=20 > diff --git a/Maintainers.txt b/Maintainers.txt index a30ee2f602..1260c8d2= 46 > 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -87,6 +87,9 @@ M: Chasel Chiu > M: Michael Kubacki > M: Nate DeSimone >=20 > +Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3 > +R: Jeremy Soller > + > Platform/Intel/MinPlatformPkg > M: Michael Kubacki > M: Chasel Chiu > diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index > 6a9b1d2e00..03fa4c2315 100644 > --- a/Platform/Intel/Readme.md > +++ b/Platform/Intel/Readme.md > @@ -83,6 +83,15 @@ A UEFI firmware implementation using > MinPlatformPkg is constructed using the fol > ----------------------------------------|--------------------------------= ------------|------------------- > -----------|--------------------| > | Simics Quick Start Package | Nehalem > | SimicsOpenBoardPkg | BoardX58Ich10 | >=20 > +#### System 76 > + > +***Galago Pro Laptop*** > + > +| Machine Name | Supported Chipsets > | BoardPkg | Board Name | > +----------------------------------------|-------------------------------= -------------|------------------ > ------------|--------------------| > +| galp2 | Kaby Lake > | KabylakeOpenBoardPkg | GalagoPro3 | > +| galp3 & galp3-b | Kaby Lake Refresh > | KabylakeOpenBoardPkg | GalagoPro3 | > + > ## Board Package Organization > The board package follows the standard EDK II package structure with the > following additional elements and guidelines: > * Only code usable across more than one board at the root level. > @@ -217,28 +226,31 @@ return back to the minimum platform caller. > | | | post-build, and > clean functions. > | | | > | | |------KabylakeOpenBoardPkg > - | | | |------KabylakeRvp3 > - | | | |---build_config.cfg: > KabylakeRvp3 specific > - | | | | > build settings, environment variables. > - | | | |---build_board.py: > Optional board-specific pre-build, build > - | | | > and clean post-build functions. > + | | | |------GalagoPro3 > + | | | | |---build_config.cfg: > System 76 Galago Pro 3 specific build > + | | | | > settings environment variables. > + | | | |------KabylakeRvp3 > + | | | |---build_config.cfg: > KabylakeRvp3 specific > + | | | | > build settings, environment variables. > + | | | |---build_board.py: > Optional board-specific pre-build, build > + | | | > and clean post-build functions. > | | | > | | |------PurleyOpenBoardPkg > | | | |------BoardMtOlympus > - | | | |---build_config.cfg: > BoardMtOlympus specific > - | | | | > build settings, environment variables. > - | | | |---build_board.py: > Optional board-specific pre-build, > - | | | > build, post-build and clean functions. > + | | | |---build_config.cfg: > BoardMtOlympus specific > + | | | | > build settings, environment variables. > + | | | |---build_board.py: > Optional board-specific pre-build, > + | | | > build, post-build and clean functions. > | | | > | | |------SimicsOpenBoardPkg > | | | |------BoardX58Ich10 > - | | | |---build_config.cfg: > BoardX58Ich10 specific > - | | | | > build settings, environment variables. > + | | | |---build_config.cfg: > BoardX58Ich10 specific > + | | | > build settings, environment variables. > | | | > | | |------WhiskeylakeOpenBoardPkg > - | | | |------WhiskeylakeURvp > - | | | |---build_config.cfg: > WhiskeylakeURvp specific build > - | | | > settings environment variables. > + | | | |------WhiskeylakeURvp > + | | | |---build_config.cfg: > WhiskeylakeURvp specific build > + | | | > settings environment variables. > | | | > |------FSP > > @@ -263,6 +275,10 @@ errors. > ### **Known limitations** >=20 > **KabylakeOpenBoardPkg** > +*GalagoPro3* > +1. The firmware project has not been tested on the Galago Pro 3B. > + > +*KabylakeRvp3* > 1. This firmware project has only been tested for Microsoft Windows 10 x= 64 > boot with AHCI mode and Integrated Graphic > Device. >=20 > diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index > 04e8f4fa64..2040774d1b 100644 > --- a/Platform/Intel/build.cfg > +++ b/Platform/Intel/build.cfg > @@ -54,5 +54,6 @@ NUMBER_OF_PROCESSORS =3D 0 # board_name =3D > path_to_board_build_config.cfg BoardMtOlympus =3D > PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg > BoardX58Ich10 =3D SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg > +GalagoPro3 =3D KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg > KabylakeRvp3 =3D KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > WhiskeylakeURvp =3D > WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg > -- > 2.16.2.windows.1