From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: chasel.chiu@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Mon, 07 Oct 2019 21:12:59 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 21:12:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,269,1566889200"; d="scan'208";a="197581727" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by orsmga006.jf.intel.com with ESMTP; 07 Oct 2019 21:12:57 -0700 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.2]) by PGSMSX102.gar.corp.intel.com ([169.254.6.203]) with mapi id 14.03.0439.000; Tue, 8 Oct 2019 12:12:56 +0800 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "Desimone, Nathaniel L" CC: "Kubacki, Michael A" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT Thread-Index: AQHVevBd7S5LpetmcE6GeuxLebsiV6dQJv3Q Date: Tue, 8 Oct 2019 04:12:56 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504F1996@PGSMSX112.gar.corp.intel.com> References: <20191004201417.5020-1-nathaniel.l.desimone@intel.com> In-Reply-To: <20191004201417.5020-1-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWJjYjgwMjItNDQyMy00MjA3LTllZGQtNzA4YTRlZmRjNjYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYmZiVFNhWWsrOG5aMEo5YTg3UDR6WWNpdm9PODFNZEpHc2VuZXhpQWowN2hcL3kyVEp6MWh5UWpBeWJUdFBIemkifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Nate > DeSimone > Sent: Saturday, October 5, 2019 4:14 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-devel] [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Log= ic > Error in EISS bit ASSERT >=20 > Current ASSERT logic checks that the EISS bit is still set after we clear= it. This > is incorrect, it should be checking that that the EISS bit is clear after= we clear > it. >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Sai Chaganty > Signed-off-by: Nate DeSimone > --- > .../Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSp= iLib.c > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c > index aadc367a9f..c34c378de2 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c > @@ -184,7 +184,7 @@ DisableBiosWriteProtect ( > B_PCH_SPI_BC_WPD ); - ASSERT ((PciSegmentRead8 > (SpiBaseAddress + R_PCH_SPI_BC) & B_PCH_SPI_BC_EISS) !=3D 0);+ ASSERT > ((PciSegmentRead8 (SpiBaseAddress + R_PCH_SPI_BC) & B_PCH_SPI_BC_EISS) > =3D=3D 0); return EFI_SUCCESS; }-- > 2.23.0.windows.1 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#48489): https://edk2.groups.io/g/devel/message/48489 > Mute This Topic: https://groups.io/mt/34398391/1777047 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com= ] > -=3D-=3D-=3D-=3D-=3D-=3D