From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: chasel.chiu@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Tue, 08 Oct 2019 09:22:38 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 09:22:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,270,1566889200"; d="scan'208";a="206670610" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by fmsmga001.fm.intel.com with ESMTP; 08 Oct 2019 09:22:36 -0700 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.2]) by PGSMSX101.gar.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0439.000; Wed, 9 Oct 2019 00:22:36 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [edk2-platforms][PATCH V1 02/17] KabylakeSiliconPkg: Add DSC include file section tags Thread-Topic: [edk2-platforms][PATCH V1 02/17] KabylakeSiliconPkg: Add DSC include file section tags Thread-Index: AQHVfZee3aF3/Bpt7UGTR9Q+0dvF7KdQ7fPQ Date: Tue, 8 Oct 2019 16:22:35 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504F203F@PGSMSX112.gar.corp.intel.com> References: <20191008051645.22052-1-michael.a.kubacki@intel.com> <20191008051645.22052-3-michael.a.kubacki@intel.com> In-Reply-To: <20191008051645.22052-3-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTVkZTM2YmMtNTJlZC00M2VjLWIyMDMtYTE3ZTVkNTllYzU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVmZQQUFPdlVhZ0tMdzJQSWJBa0pkV2VPK3ZIYXhxSGs2RUlFMzhRZEQ2d3NuSUd3cCt5VW5mb1QyM2JEclI0ZiJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Tuesday, October 8, 2019 1:17 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > > Subject: [edk2-platforms][PATCH V1 02/17] KabylakeSiliconPkg: Add DSC > include file section tags >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2245 >=20 > The DSC LibraryClass files in KabylakeSiliconPkg that are intended to be > included elsewhere such as SiPkgPeiLib.dsc, SiPkgDxeLib.dsc, and > SiPkgCommonLib.dsc should have section tags so that they are not > dependent on the top-level DSC file to place the include file in the corr= ect > location in the DSC file and better define the applicability of their lib= rary > content. >=20 > This change adds section tags for the library class related files. > The component files may be built differently in the consuming package > depending on their architecture requirements so those are not modified. >=20 > Cc: Sai Chaganty > Cc: Chasel Chiu > Signed-off-by: Michael Kubacki > --- > Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc | 6 ++++-- > Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc | 5 +++-- > Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc | 3 ++- > 3 files changed, 9 insertions(+), 5 deletions(-) >=20 > diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc > b/Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc > index 920b02e410..fa9dd4a32d 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc > +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc > @@ -1,11 +1,13 @@ > ## @file > -# Component description file for the SkyLake SiPkg both Pei and Dxe > libraries DSC file. > +# Build description file for Kaby Lake silicon PEI and DXE libraries. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # ## > + > +[LibraryClasses.common] > # > # Silicon Init Common Library > # > diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc > b/Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc > index 8c194d8e7c..bc497c3531 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc > +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc > @@ -1,12 +1,13 @@ > # @file > -# Component description file for the SkyLake SiPkg DXE libraries. > +# Build description file for Kaby Lake silicon DXE libraries. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # ## >=20 > +[LibraryClasses.common.DXE_CORE,LibraryClasses.common.DXE_SMM_DRIV > ER,Li > +braryClasses.common.SMM_CORE,LibraryClasses.common.DXE_DRIVER,Libr > aryCl > +asses.common.DXE_RUNTIME_DRIVER,LibraryClasses.common.UEFI_DRIVER > ] > # > # Silicon Init Dxe Library > # > diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc > b/Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc > index 86e34ff359..5334598544 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc > +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc > @@ -1,5 +1,5 @@ > ## @file > -# Component description file for the SkyLake SiPkg PEI libraries. > +# Build description file for Kaby Lake silicon PEI libraries. > # > # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
= # > @@ -7,6 +7,7 @@ # ## >=20 > +[LibraryClasses] > # > # Silicon Init Pei Library > # > -- > 2.16.2.windows.1