From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: chasel.chiu@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Tue, 08 Oct 2019 09:24:08 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 09:24:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,270,1566889200"; d="scan'208";a="277146303" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by orsmga001.jf.intel.com with ESMTP; 08 Oct 2019 09:24:07 -0700 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.2]) by PGSMSX107.gar.corp.intel.com ([169.254.7.216]) with mapi id 14.03.0439.000; Wed, 9 Oct 2019 00:24:06 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , Jeremy Soller Subject: Re: [edk2-platforms][PATCH V1 04/17] KabylakeOpenBoardPkg/GalagoPro3: Relocate PCD DSC include Thread-Topic: [edk2-platforms][PATCH V1 04/17] KabylakeOpenBoardPkg/GalagoPro3: Relocate PCD DSC include Thread-Index: AQHVfZemSlEHGnUILU6nP/q5a46hOqdQ7lAA Date: Tue, 8 Oct 2019 16:24:05 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504F204D@PGSMSX112.gar.corp.intel.com> References: <20191008051645.22052-1-michael.a.kubacki@intel.com> <20191008051645.22052-5-michael.a.kubacki@intel.com> In-Reply-To: <20191008051645.22052-5-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTQ3M2Q3OTMtY2FjZS00Mjg2LTg5NGQtNDI4NTFlYjQ2OGRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWmJHUUtYRXhtNHUrenBkMk0yRXI0a0VsOXdlNVA4Uk96cUJXTUZRSm5HREk2MXpXWUttdWdcL2tGT0FCcHVKQXMifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Tuesday, October 8, 2019 1:17 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Jeremy Soller > Subject: [edk2-platforms][PATCH V1 04/17] > KabylakeOpenBoardPkg/GalagoPro3: Relocate PCD DSC include >=20 > This change moves the include of OpenBoardPkgPcd.dsc to the top of > OpenBoardPkg.dsc to improve visibility and align the include location wit= h > other board DSC files. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Jeremy Soller > Signed-off-by: Michael Kubacki > --- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 3 > +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > index f3dd2b0c91..90ee5dfc53 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -24,6 +24,7 @@ > # Platform On/Off features are defined here > # > !include OpenBoardPkgConfig.dsc > + !include OpenBoardPkgPcd.dsc >=20 >=20 > ################################################################ > ################ > # > @@ -174,8 +175,6 @@ > [LibraryClasses.X64.DXE_RUNTIME_DRIVER] >=20 > ResetSystemLib|$(PLATFORM_SI_PACKAGE)/Pch/Library/DxeRuntimeResetSys > temLib/DxeRuntimeResetSystemLib.inf >=20 > -!include OpenBoardPkgPcd.dsc > - > [Components.IA32] >=20 > # > -- > 2.16.2.windows.1