From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.63.1570552294475915400 for ; Tue, 08 Oct 2019 09:31:34 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 09:31:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,270,1566889200"; d="scan'208";a="218334573" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by fmsmga004.fm.intel.com with ESMTP; 08 Oct 2019 09:31:21 -0700 Received: from pgsmsx112.gar.corp.intel.com ([169.254.3.2]) by PGSMSX107.gar.corp.intel.com ([169.254.7.216]) with mapi id 14.03.0439.000; Wed, 9 Oct 2019 00:31:20 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [edk2-platforms][PATCH V1 10/17] CoffeelakeSiliconPkg: Add DSC include file section tags Thread-Topic: [edk2-platforms][PATCH V1 10/17] CoffeelakeSiliconPkg: Add DSC include file section tags Thread-Index: AQHVfZesTgOc9CpKAU2L487fz/fvwKdQ8GYA Date: Tue, 8 Oct 2019 16:31:20 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504F20B5@PGSMSX112.gar.corp.intel.com> References: <20191008051645.22052-1-michael.a.kubacki@intel.com> <20191008051645.22052-11-michael.a.kubacki@intel.com> In-Reply-To: <20191008051645.22052-11-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzllM2IxOGQtNzhkYi00NzRiLTg1NmMtZjNlOWY0N2I3ZjhlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibFZhN00reVdUQ3ZNcHZUNkMxMVdkcm95dTI4M2R4VHdNXC9xdDBnWksyZ2M0czdZYmsrM25EYkwyV3ROZDlFcW0ifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Tuesday, October 8, 2019 1:17 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > > Subject: [edk2-platforms][PATCH V1 10/17] CoffeelakeSiliconPkg: Add DSC > include file section tags >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2246 >=20 > The DSC LibraryClass files in CoffeelakeSiliconPkg that are intended to b= e > included elsewhere such as SiPkgPeiLib.dsc, SiPkgDxeLib.dsc, and > SiPkgCommonLib.dsc should have section tags so that they are not > dependent on the top-level DSC file to place the include file in the corr= ect > location in the DSC file and better define the applicability of their lib= rary > content. >=20 > This change adds section tags for the library class related files. > The component files may be built differently in the consuming package > depending on their architecture requirements so those are not modified. >=20 > Cc: Sai Chaganty > Cc: Chasel Chiu > Signed-off-by: Michael Kubacki > --- > Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc | 1 + > Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc | 1 + > Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc | 1 + > 3 files changed, 3 insertions(+) >=20 > diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc > b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc > index 2df08c6d01..7a9911e825 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgCommonLib.dsc > @@ -13,6 +13,7 @@ > # > DEFINE PCH =3D Cnl >=20 > +[LibraryClasses.common] > # > # Cpu > # > diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc > b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc > index 214de06d58..e21004c993 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgDxeLib.dsc > @@ -7,6 +7,7 @@ > # > ## >=20 > +[LibraryClasses.common.DXE_CORE,LibraryClasses.common.DXE_SMM_DRIV > ER,Li > +braryClasses.common.SMM_CORE,LibraryClasses.common.DXE_DRIVER,Libr > aryCl > +asses.common.DXE_RUNTIME_DRIVER,LibraryClasses.common.UEFI_DRIVER > ] > # > # Silicon Init Dxe Library > # > diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc > b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc > index 6e244a6ded..bc3fcabd4d 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/SiPkgPeiLib.dsc > @@ -7,6 +7,7 @@ > # > ## >=20 > +[LibraryClasses] > # > # Silicon Init Pei Library > # > -- > 2.16.2.windows.1