From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Kubacki, Michael A" <michael.a.kubacki@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-platforms][PATCH V1 2/2] WhiskeylakeOpenBoardPkg: Correct Platform Hook Library references
Date: Wed, 30 Oct 2019 02:49:32 +0000 [thread overview]
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505146D9@PGSMSX111.gar.corp.intel.com> (raw)
In-Reply-To: <20191029230513.38520-3-michael.a.kubacki@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Kubacki, Michael A <michael.a.kubacki@intel.com>
> Sent: Wednesday, October 30, 2019 7:05 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-platforms][PATCH V1 2/2] WhiskeylakeOpenBoardPkg: Correct
> Platform Hook Library references
>
> Many file descriptions reference "Platform Hook Library" when the file is not
> related to the PlatformHookLib library class. This change updates those
> references in WhiskeylakeOpenBoardPkg to a more accurate description.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA
> cpiLib/SmmBoardAcpiEnableLib.inf | 2 +-
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA
> cpiLib/SmmMultiBoardAcpiSupportLib.inf | 2 +-
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA
> cpiLib/SmmBoardAcpiEnableLib.c | 2 +-
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA
> cpiLib/SmmMultiBoardAcpiSupportLib.c | 2 +-
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA
> cpiLib/SmmSiliconAcpiEnableLib.c | 2 +-
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA
> cpiLib/SmmWhiskeylakeURvpAcpiEnableLib.c | 2 +-
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardI
> nitLib/PeiBoardInitPostMemLib.c | 2 +-
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardI
> nitLib/PeiBoardInitPreMemLib.c | 2 +-
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardI
> nitLib/PeiMultiBoardInitPostMemLib.c | 2 +-
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardI
> nitLib/PeiMultiBoardInitPreMemLib.c | 2 +-
> 10 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmBoardAcpiEnableLib.inf
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmBoardAcpiEnableLib.inf
> index c3fd60007a..7c360a8043 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmBoardAcpiEnableLib.inf
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdAcpiLib/SmmBoardAcpiEnableLib.inf
> @@ -1,5 +1,5 @@
> ## @file
> -# Platform Hook Library instance for Whiskeylake Mobile/Desktop CRB.
> +# Whiskey Lake U RVP SMM Board ACPI Enable library
> #
> #
> # Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmMultiBoardAcpiSupportLib.inf
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmMultiBoardAcpiSupportLib.inf
> index eaf46ad4ef..32e63b15ce 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmMultiBoardAcpiSupportLib.inf
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdAcpiLib/SmmMultiBoardAcpiSupportLib.inf
> @@ -1,5 +1,5 @@
> ## @file
> -# Platform Hook Library instance for Whiskeylake Mobile/Desktop CRB.
> +# Whiskey Lake U RVP SMM Multi-Board ACPI Support library
> #
> #
> # Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmBoardAcpiEnableLib.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmBoardAcpiEnableLib.c
> index e7acbda03a..1554b568d7 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmBoardAcpiEnableLib.c
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdAcpiLib/SmmBoardAcpiEnableLib.c
> @@ -1,5 +1,5 @@
> /** @file
> - Platform Hook Library instances
> + Whiskey Lake U RVP SMM Board ACPI Enable library
>
>
> Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmMultiBoardAcpiSupportLib.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmMultiBoardAcpiSupportLib.c
> index 5fc61861a6..6ff78c2946 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmMultiBoardAcpiSupportLib.c
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdAcpiLib/SmmMultiBoardAcpiSupportLib.c
> @@ -1,5 +1,5 @@
> /** @file
> - Platform Hook Library instances
> + Whiskey Lake U RVP SMM Multi-Board ACPI Support library
>
>
> Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmSiliconAcpiEnableLib.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmSiliconAcpiEnableLib.c
> index 9daceaa25c..6d04e83be2 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmSiliconAcpiEnableLib.c
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdAcpiLib/SmmSiliconAcpiEnableLib.c
> @@ -1,5 +1,5 @@
> /** @file
> - Platform Hook Library instances
> + Whiskey Lake U RVP SMM Silicon ACPI Enable library
>
>
> Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmWhiskeylakeURvpAcpiEnableLib.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmWhiskeylakeURvpAcpiEnableLib.c
> index 6dc47984da..2e0c2ee17e 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dAcpiLib/SmmWhiskeylakeURvpAcpiEnableLib.c
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdAcpiLib/SmmWhiskeylakeURvpAcpiEnableLib.c
> @@ -1,5 +1,5 @@
> /** @file
> - Platform Hook Library instances
> + Whiskey Lake U RVP SMM Board ACPI Enable library
>
>
> Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dInitLib/PeiBoardInitPostMemLib.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dInitLib/PeiBoardInitPostMemLib.c
> index c52d4eceed..a129f30145 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dInitLib/PeiBoardInitPostMemLib.c
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdInitLib/PeiBoardInitPostMemLib.c
> @@ -1,5 +1,5 @@
> /** @file
> - Platform Hook Library instances
> + Whiskey Lake U RVP Board Initialization Post-Memory library
>
>
> Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dInitLib/PeiBoardInitPreMemLib.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dInitLib/PeiBoardInitPreMemLib.c
> index 1283a4c80a..c0f8ea7878 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dInitLib/PeiBoardInitPreMemLib.c
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdInitLib/PeiBoardInitPreMemLib.c
> @@ -1,5 +1,5 @@
> /** @file
> - Platform Hook Library instances
> + Whiskey Lake U RVP Board Initialization Pre-Memory library
>
>
> Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dInitLib/PeiMultiBoardInitPostMemLib.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dInitLib/PeiMultiBoardInitPostMemLib.c
> index 915dadbf8c..c9cec74250 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dInitLib/PeiMultiBoardInitPostMemLib.c
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdInitLib/PeiMultiBoardInitPostMemLib.c
> @@ -1,5 +1,5 @@
> /** @file
> - Platform Hook Library instances
> + Whiskey Lake U RVP Multi-Board Initialization Post-Memory library
>
>
> Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dInitLib/PeiMultiBoardInitPreMemLib.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dInitLib/PeiMultiBoardInitPreMemLib.c
> index 744864f98f..9f4dfbf789 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar
> dInitLib/PeiMultiBoardInitPreMemLib.c
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdInitLib/PeiMultiBoardInitPreMemLib.c
> @@ -1,5 +1,5 @@
> /** @file
> - Platform Hook Library instances
> + Whiskey Lake U RVP Multi-Board Initialization Pre-Memory library
>
>
> Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> --
> 2.16.2.windows.1
next prev parent reply other threads:[~2019-10-30 2:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 23:05 [edk2-platforms][PATCH V1 0/2] Correct Platform Hook Library references Kubacki, Michael A
2019-10-29 23:05 ` [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: " Kubacki, Michael A
2019-10-30 2:47 ` Chiu, Chasel
2019-10-31 1:26 ` [edk2-devel] " Nate DeSimone
2019-10-29 23:05 ` [edk2-platforms][PATCH V1 2/2] WhiskeylakeOpenBoardPkg: " Kubacki, Michael A
2019-10-30 2:49 ` Chiu, Chasel [this message]
2019-10-31 1:26 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C3EFB470A303B4AB093197B6777CCEC505146D9@PGSMSX111.gar.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox