From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.518.1572403779382965834 for ; Tue, 29 Oct 2019 19:49:39 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2019 19:49:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,245,1569308400"; d="scan'208";a="193822438" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by orsmga008.jf.intel.com with ESMTP; 29 Oct 2019 19:49:37 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.128]) by PGSMSX108.gar.corp.intel.com ([169.254.8.51]) with mapi id 14.03.0439.000; Wed, 30 Oct 2019 10:49:33 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [edk2-platforms][PATCH V1 2/2] WhiskeylakeOpenBoardPkg: Correct Platform Hook Library references Thread-Topic: [edk2-platforms][PATCH V1 2/2] WhiskeylakeOpenBoardPkg: Correct Platform Hook Library references Thread-Index: AQHVjq1mOdW9BnzcZUG/gUp+rv3Egqdye+pQ Date: Wed, 30 Oct 2019 02:49:32 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505146D9@PGSMSX111.gar.corp.intel.com> References: <20191029230513.38520-1-michael.a.kubacki@intel.com> <20191029230513.38520-3-michael.a.kubacki@intel.com> In-Reply-To: <20191029230513.38520-3-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjI5NTU4ZGQtYzZlMi00OWZmLWE4Y2QtYmNhYmUyOGY2ZDVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTmpzOE9VWkRZWHVvNlYyWnFTMkVVYVhQbDgzV2o2UWdnMDlGem14cW5GSlRPeWpMTWNNQkxkWVk2cW9pNmdxMiJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Wednesday, October 30, 2019 7:05 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH V1 2/2] WhiskeylakeOpenBoardPkg: Correct > Platform Hook Library references >=20 > Many file descriptions reference "Platform Hook Library" when the file is= not > related to the PlatformHookLib library class. This change updates those > references in WhiskeylakeOpenBoardPkg to a more accurate description. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Michael Kubacki > --- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA > cpiLib/SmmBoardAcpiEnableLib.inf | 2 +- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA > cpiLib/SmmMultiBoardAcpiSupportLib.inf | 2 +- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA > cpiLib/SmmBoardAcpiEnableLib.c | 2 +- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA > cpiLib/SmmMultiBoardAcpiSupportLib.c | 2 +- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA > cpiLib/SmmSiliconAcpiEnableLib.c | 2 +- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA > cpiLib/SmmWhiskeylakeURvpAcpiEnableLib.c | 2 +- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardI > nitLib/PeiBoardInitPostMemLib.c | 2 +- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardI > nitLib/PeiBoardInitPreMemLib.c | 2 +- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardI > nitLib/PeiMultiBoardInitPostMemLib.c | 2 +- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardI > nitLib/PeiMultiBoardInitPreMemLib.c | 2 +- > 10 files changed, 10 insertions(+), 10 deletions(-) >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmBoardAcpiEnableLib.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmBoardAcpiEnableLib.inf > index c3fd60007a..7c360a8043 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmBoardAcpiEnableLib.inf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdAcpiLib/SmmBoardAcpiEnableLib.inf > @@ -1,5 +1,5 @@ > ## @file > -# Platform Hook Library instance for Whiskeylake Mobile/Desktop CRB. > +# Whiskey Lake U RVP SMM Board ACPI Enable library > # > # > # Copyright (c) 2019, Intel Corporation. All rights reserved.
diff = --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmMultiBoardAcpiSupportLib.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmMultiBoardAcpiSupportLib.inf > index eaf46ad4ef..32e63b15ce 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmMultiBoardAcpiSupportLib.inf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdAcpiLib/SmmMultiBoardAcpiSupportLib.inf > @@ -1,5 +1,5 @@ > ## @file > -# Platform Hook Library instance for Whiskeylake Mobile/Desktop CRB. > +# Whiskey Lake U RVP SMM Multi-Board ACPI Support library > # > # > # Copyright (c) 2019, Intel Corporation. All rights reserved.
diff = --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmBoardAcpiEnableLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmBoardAcpiEnableLib.c > index e7acbda03a..1554b568d7 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmBoardAcpiEnableLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdAcpiLib/SmmBoardAcpiEnableLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Whiskey Lake U RVP SMM Board ACPI Enable library >=20 >=20 > Copyright (c) 2019, Intel Corporation. All rights reserved.
diff -= -git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmMultiBoardAcpiSupportLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmMultiBoardAcpiSupportLib.c > index 5fc61861a6..6ff78c2946 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmMultiBoardAcpiSupportLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdAcpiLib/SmmMultiBoardAcpiSupportLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Whiskey Lake U RVP SMM Multi-Board ACPI Support library >=20 >=20 > Copyright (c) 2019, Intel Corporation. All rights reserved.
diff -= -git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmSiliconAcpiEnableLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmSiliconAcpiEnableLib.c > index 9daceaa25c..6d04e83be2 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmSiliconAcpiEnableLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdAcpiLib/SmmSiliconAcpiEnableLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Whiskey Lake U RVP SMM Silicon ACPI Enable library >=20 >=20 > Copyright (c) 2019, Intel Corporation. All rights reserved.
diff -= -git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmWhiskeylakeURvpAcpiEnableLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmWhiskeylakeURvpAcpiEnableLib.c > index 6dc47984da..2e0c2ee17e 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmWhiskeylakeURvpAcpiEnableLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdAcpiLib/SmmWhiskeylakeURvpAcpiEnableLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Whiskey Lake U RVP SMM Board ACPI Enable library >=20 >=20 > Copyright (c) 2019, Intel Corporation. All rights reserved.
diff -= -git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dInitLib/PeiBoardInitPostMemLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dInitLib/PeiBoardInitPostMemLib.c > index c52d4eceed..a129f30145 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dInitLib/PeiBoardInitPostMemLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdInitLib/PeiBoardInitPostMemLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Whiskey Lake U RVP Board Initialization Post-Memory library >=20 >=20 > Copyright (c) 2019, Intel Corporation. All rights reserved.
diff -= -git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dInitLib/PeiBoardInitPreMemLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dInitLib/PeiBoardInitPreMemLib.c > index 1283a4c80a..c0f8ea7878 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dInitLib/PeiBoardInitPreMemLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdInitLib/PeiBoardInitPreMemLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Whiskey Lake U RVP Board Initialization Pre-Memory library >=20 >=20 > Copyright (c) 2019, Intel Corporation. All rights reserved.
diff -= -git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dInitLib/PeiMultiBoardInitPostMemLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dInitLib/PeiMultiBoardInitPostMemLib.c > index 915dadbf8c..c9cec74250 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dInitLib/PeiMultiBoardInitPostMemLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdInitLib/PeiMultiBoardInitPostMemLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Whiskey Lake U RVP Multi-Board Initialization Post-Memory library >=20 >=20 > Copyright (c) 2019, Intel Corporation. All rights reserved.
diff -= -git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dInitLib/PeiMultiBoardInitPreMemLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dInitLib/PeiMultiBoardInitPreMemLib.c > index 744864f98f..9f4dfbf789 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dInitLib/PeiMultiBoardInitPreMemLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdInitLib/PeiMultiBoardInitPreMemLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Whiskey Lake U RVP Multi-Board Initialization Pre-Memory library >=20 >=20 > Copyright (c) 2019, Intel Corporation. All rights reserved.
> -- > 2.16.2.windows.1