From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.4097.1572517337223339327 for ; Thu, 31 Oct 2019 03:22:17 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2019 03:22:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,250,1569308400"; d="scan'208";a="375196387" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by orsmga005.jf.intel.com with ESMTP; 31 Oct 2019 03:22:15 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.128]) by PGSMSX107.gar.corp.intel.com ([169.254.7.221]) with mapi id 14.03.0439.000; Thu, 31 Oct 2019 18:22:14 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Gao, Liming" , Jeremy Soller , "Lu, Shifei A" , "Zhou, Bowen" , "Oram, Isaac W" , "Wei, David Y" , "Agyeman, Prince" Subject: Re: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class. Thread-Topic: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class. Thread-Index: AQHVj4J4JN0hj/jg10myDjoIdBi2q6d0PdgggABNK0A= Date: Thu, 31 Oct 2019 10:22:13 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC50517C59@PGSMSX111.gar.corp.intel.com> References: <20191031002952.3860-1-chasel.chiu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2FiY2Q1MDgtOTBiMy00NWI2LWFjYjgtMGFmM2MxMmNiMmMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibEJLNDVrdHRkQ1ljU0lXWEkyTVhRMWFiaXhXNGg2Y3krcHpwbjErUEl4TlBuMWJlUjhONkpGR0dQNWozMEhmSSJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Agreed. Will rename in V3. Thanks! Chasel > -----Original Message----- > From: Kubacki, Michael A > Sent: Thursday, October 31, 2019 1:50 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Gao, Liming > ; Jeremy Soller ; Lu, Shifei A > ; Zhou, Bowen ; Oram, Isaac > W ; Wei, David Y ; > Agyeman, Prince > Subject: RE: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class= . >=20 > Hi Chasel, >=20 > I don't think SetCacheLib is quite precise enough. Can you please conside= r > an alternative such as SetMtrrLib? >=20 > Thanks, > Michael >=20 > > -----Original Message----- > > From: Chiu, Chasel > > Sent: Wednesday, October 30, 2019 5:30 PM > > To: devel@edk2.groups.io > > Cc: Kubacki, Michael A ; Desimone, > > Nathaniel L ; Gao, Liming > > ; Jeremy Soller ; Lu, > > Shifei A ; Zhou, Bowen ; > > Oram, Isaac W ; Wei, David Y > > ; Agyeman, Prince > > Subject: [edk2-platforms: PATCH v2 0/6] Add SetCacheLib library class. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2314 > > > > The MTRRs may be redundantly or incorrectly configured. > > It is recommended to move this functionality to a library class that > > with a NULL library by default. The board package may provide its own > > library implementation. > > MinPlatformPkg should contain the library class header (API) and the > > NULL library class instance. > > > > Cc: Michael Kubacki > > Cc: Nate DeSimone > > Cc: Liming Gao > > Cc: Jeremy Soller > > Cc: Shifei A Lu > > Cc: Xiaohu Zhou > > Cc: Isaac W Oram > > Cc: Wei David Y > > Cc: Agyeman Prince > > Signed-off-by: Chasel Chiu > > > > Chasel Chiu (6): > > MinPlatformPkg: Add SetCacheLib library class. > > MinPlatformPkg: Add SetCacheLib library class. > > KabylakeOpenBoardPkg: Add SetCacheLib library class. > > WhiskeylakeOpenBoardPkg: Add SetCacheLib library class. > > PurleyOpenBoardPkg/BoardMtOlympus: Add SetCacheLib library class. > > SimicsOpenBoardPkg/BoardX58Ich10: Add SetCacheLib library class. > > > > > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c | > 640 > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------------------------------------------------- > > ------ > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.c > > | 325 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > +++++++++++++++++++++++++++++++++++ > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.c > > | 37 +++++++++++++++++++++++++++++++++++++ > > > > > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPo= s > > tMem.c > | 149 +----------------------------------------- > > ---------------------------------------------------------------------- > > ------------------------ > > ------------- > > > > > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPr= e > > Mem.c > | 164 ++---------------------------------------- > > ---------------------------------------------------------------------- > > ------------------------ > > ---------------------------- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > > | 3 ++- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > > | 2 +- > > > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf | > > 67 > > ------------------------------------------------------------------- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > > | 1 + > > Platform/Intel/MinPlatformPkg/Include/Library/SetCacheLib.h > > | 34 ++++++++++++++++++++++++++++++++++ > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.inf > > | 44 ++++++++++++++++++++++++++++++++++++++++++++ > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.inf > > | 30 ++++++++++++++++++++++++++++++ > > > > > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPo= s > > tMem.inf > | 11 +---------- > > > > > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPr= e > > Mem.inf > | 7 ++----- > > Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc > > | 3 ++- > > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > > | 1 + > > > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk > > g.dsc > | 1 + > > 17 files changed, 484 insertions(+), 1035 deletions(-) delete mode > > 100644 > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c > > create mode 100644 > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.c > > create mode 100644 > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.c > > delete mode 100644 > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf > > create mode 100644 > > Platform/Intel/MinPlatformPkg/Include/Library/SetCacheLib.h > > create mode 100644 > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLib.inf > > create mode 100644 > > Platform/Intel/MinPlatformPkg/Library/SetCacheLib/SetCacheLibNull.inf > > > > -- > > 2.13.3.windows.1 >=20