Re: [edk2-platforms] [Patch v2 4/9] BoardModulePkg: Add fix at build Pcds

["Chiu, Chasel" <chasel.chiu@intel.com>]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Agyeman, Prince <prince.agyeman@intel.com>
> Sent: Wednesday, November 6, 2019 9:26 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-platforms] [Patch v2 4/9] BoardModulePkg: Add fix at build
> Pcds
> 
> * Added ps2 keyboard and Uart enable PCDs.
> * Added PCDs to define IO ports for Uart1 and Uart2
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
> ---
>  .../Intel/BoardModulePkg/BoardModulePkg.dec   | 21
> +++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec
> b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec
> index 8a811602e6..26e662f711 100644
> --- a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec
> +++ b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec
> @@ -46,3 +46,24 @@
>    ## {7F4EE1A3-C1F3-43E4-BA1A-39DCDE46C343}
>    gBoardModulePkgTokenSpaceGuid = { 0x7f4ee1a3, 0xc1f3, 0x43e4, { 0xba,
> 0x1a, 0x39, 0xdc, 0xde, 0x46, 0xc3, 0x43 } }
> 
> +[PcdsFixedAtBuild]
> +  ## PcdPs2KbMsEnable 0x0:Disable, 0x1:Enable
> +
> gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable|0x00|UINT8|0x00000
> 001
> +
> +  ## SuperIo Pci ISA Bridge info. It is an array that contains the
> + Segment, Bus, Device and Function  #  information describing the PCI
> + Device Info. The first byte is the segment number,  #  the second is
> + the bus number, third byte is the device number, the fourth byte  #  is
> the Function.
> +  gBoardModulePkgTokenSpaceGuid.PcdSuperIoPciIsaBridgeDevice|{0xFF,
> + 0xFF, 0xFF, 0xFF}|VOID*|0x00000002
> +
> +  ## PcdUart1Enable 0x0:Disable, 0x1:Enable
> +
> gBoardModulePkgTokenSpaceGuid.PcdUart1Enable|0x00|UINT8|0x0000000
> 3
> +
> +
> gBoardModulePkgTokenSpaceGuid.PcdUart1IrqMask|0x0010|UINT16|0x000
> 00004
> +
> gBoardModulePkgTokenSpaceGuid.PcdUart1IoPort|0x03F8|UINT16|0x00000
> 005
> +
> gBoardModulePkgTokenSpaceGuid.PcdUart1Length|0x08|UINT8|0x00000006
> +
> +  ## PcdUart2Enable 0x0:Disable, 0x1:Enable
> +
> gBoardModulePkgTokenSpaceGuid.PcdUart2Enable|0x00|UINT8|0x0000000
> 7
> +
> +
> gBoardModulePkgTokenSpaceGuid.PcdUart2IrqMask|0x0008|UINT16|0x000
> 00008
> +
> gBoardModulePkgTokenSpaceGuid.PcdUart2IoPort|0x02F8|UINT16|0x00000
> 009
> +
> gBoardModulePkgTokenSpaceGuid.PcdUart2Length|0x08|UINT8|0x0000000
> A
> --
> 2.19.1.windows.1