From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.3230.1573006074964496895 for ; Tue, 05 Nov 2019 18:07:55 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2019 18:07:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,272,1569308400"; d="scan'208";a="200971519" Received: from pgsmsx114.gar.corp.intel.com ([10.108.55.203]) by fmsmga007.fm.intel.com with ESMTP; 05 Nov 2019 18:07:53 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.128]) by pgsmsx114.gar.corp.intel.com ([169.254.4.106]) with mapi id 14.03.0439.000; Wed, 6 Nov 2019 10:07:52 +0800 From: "Chiu, Chasel" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [Patch v2 4/9] BoardModulePkg: Add fix at build Pcds Thread-Topic: [edk2-platforms] [Patch v2 4/9] BoardModulePkg: Add fix at build Pcds Thread-Index: AQHVlEErtt9Yd15UuUeDnWUY3Tghwad9ZW+Q Date: Wed, 6 Nov 2019 02:07:51 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5052325F@PGSMSX111.gar.corp.intel.com> References: <20191106012603.4724-1-prince.agyeman@intel.com> <20191106012603.4724-5-prince.agyeman@intel.com> In-Reply-To: <20191106012603.4724-5-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGRiNzc4NWYtNjU1OS00M2E5LTk2YjMtZjczNWI3ZWExNDkwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoic1Y3WDBiVnBNOTJFaW5PMDl0U2hnVE1NQjZTMUJzelZnM2d3UEdHeFNiY3lRWXVEc3VQaFwvcTd4dTlJR20zSHgifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Agyeman, Prince > Sent: Wednesday, November 6, 2019 9:26 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [Patch v2 4/9] BoardModulePkg: Add fix at build > Pcds >=20 > * Added ps2 keyboard and Uart enable PCDs. > * Added PCDs to define IO ports for Uart1 and Uart2 >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../Intel/BoardModulePkg/BoardModulePkg.dec | 21 > +++++++++++++++++++ > 1 file changed, 21 insertions(+) >=20 > diff --git a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > index 8a811602e6..26e662f711 100644 > --- a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > +++ b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > @@ -46,3 +46,24 @@ > ## {7F4EE1A3-C1F3-43E4-BA1A-39DCDE46C343} > gBoardModulePkgTokenSpaceGuid =3D { 0x7f4ee1a3, 0xc1f3, 0x43e4, { 0xba= , > 0x1a, 0x39, 0xdc, 0xde, 0x46, 0xc3, 0x43 } } >=20 > +[PcdsFixedAtBuild] > + ## PcdPs2KbMsEnable 0x0:Disable, 0x1:Enable > + > gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable|0x00|UINT8|0x00000 > 001 > + > + ## SuperIo Pci ISA Bridge info. It is an array that contains the > + Segment, Bus, Device and Function # information describing the PCI > + Device Info. The first byte is the segment number, # the second is > + the bus number, third byte is the device number, the fourth byte # is > the Function. > + gBoardModulePkgTokenSpaceGuid.PcdSuperIoPciIsaBridgeDevice|{0xFF, > + 0xFF, 0xFF, 0xFF}|VOID*|0x00000002 > + > + ## PcdUart1Enable 0x0:Disable, 0x1:Enable > + > gBoardModulePkgTokenSpaceGuid.PcdUart1Enable|0x00|UINT8|0x0000000 > 3 > + > + > gBoardModulePkgTokenSpaceGuid.PcdUart1IrqMask|0x0010|UINT16|0x000 > 00004 > + > gBoardModulePkgTokenSpaceGuid.PcdUart1IoPort|0x03F8|UINT16|0x00000 > 005 > + > gBoardModulePkgTokenSpaceGuid.PcdUart1Length|0x08|UINT8|0x00000006 > + > + ## PcdUart2Enable 0x0:Disable, 0x1:Enable > + > gBoardModulePkgTokenSpaceGuid.PcdUart2Enable|0x00|UINT8|0x0000000 > 7 > + > + > gBoardModulePkgTokenSpaceGuid.PcdUart2IrqMask|0x0008|UINT16|0x000 > 00008 > + > gBoardModulePkgTokenSpaceGuid.PcdUart2IoPort|0x02F8|UINT16|0x00000 > 009 > + > gBoardModulePkgTokenSpaceGuid.PcdUart2Length|0x08|UINT8|0x0000000 > A > -- > 2.19.1.windows.1