From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.3360.1573006132743770173 for ; Tue, 05 Nov 2019 18:08:52 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2019 18:08:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,272,1569308400"; d="scan'208";a="285515344" Received: from pgsmsx112.gar.corp.intel.com ([10.108.55.201]) by orsmga001.jf.intel.com with ESMTP; 05 Nov 2019 18:08:51 -0800 Received: from pgsmsx110.gar.corp.intel.com (10.221.44.111) by PGSMSX112.gar.corp.intel.com (10.108.55.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 10:08:50 +0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.128]) by PGSMSX110.gar.corp.intel.com ([169.254.13.229]) with mapi id 14.03.0439.000; Wed, 6 Nov 2019 10:08:50 +0800 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "Agyeman, Prince" Subject: Re: [edk2-devel] [edk2-platforms] [Patch v2 7/9] KabylakeOpenBoardPkg: Add Ps2 Keyboard Support Thread-Topic: [edk2-devel] [edk2-platforms] [Patch v2 7/9] KabylakeOpenBoardPkg: Add Ps2 Keyboard Support Thread-Index: AQHVlEEytPbNLfkg1kiBDyyVyKTbAqd9ZaAg Date: Wed, 6 Nov 2019 02:08:49 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC50523295@PGSMSX111.gar.corp.intel.com> References: <20191106012603.4724-1-prince.agyeman@intel.com> <20191106012603.4724-8-prince.agyeman@intel.com> In-Reply-To: <20191106012603.4724-8-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDQ2ZTY2OWQtZmZjMy00N2QwLWJkZTYtODI1ZWM0ZGU5NTBjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiR0ZLcmNXRmhwV0ZTY1RzSGhKb0ozNlNreGs0emRJZjhcLzNMK3I3VEd0VlRPZWZZU3FIaGhMc0FweDN2UXpqeHMifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Return-Path: chasel.chiu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Agyeman, > Prince > Sent: Wednesday, November 6, 2019 9:26 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [edk2-platforms] [Patch v2 7/9] KabylakeOpenBoardP= kg: > Add Ps2 Keyboard Support >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2228 >=20 > What was done: >=20 > * Added BDS Ps2 keyboard DXE driver. >=20 > * Added Super I/O DXE driver to publish the SIO protocol needed by the P= s2 > keyboard DXE driver. >=20 > * Included a Ps2 Library to BdsDxe driver to add the Ps2 device path to > ConIn and ConInDev variables >=20 > * Configured the Super I/O Pci to Isa bridge bus, device, function devic= e info > PCD. This will help the Super I/O driver identify which bridge the Super= I/O is > connected to. >=20 > * Removed duplicate Ps2 enable PCDs >=20 > * Updated libraries to use Ps2 enable PCD defined in BoardModulePkg >=20 > Signed-off-by: Prince Agyeman > --- > .../Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf | 3 ++- > .../Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf | 3 ++- > .../Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 7 > +++++++ .../Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf | > 2 ++ > .../KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc | 6 > ++++++ > .../Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf | 3 ++- > .../Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf | 3 ++- > .../KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 6 > ++++++ > .../KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf | 2 ++ > .../KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 7 > +++++++ > Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec | 2 -- > 11 files changed, 38 insertions(+), 6 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeBoardAcpiTableLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeBoardAcpiTableLib.inf > index a79bdcdbc6..35cd5c8fdb 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeBoardAcpiTableLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/DxeBoardAcpiTableLib.inf > @@ -33,9 +33,10 @@ > MinPlatformPkg/MinPlatformPkg.dec > KabylakeOpenBoardPkg/OpenBoardPkg.dec > KabylakeSiliconPkg/SiPkg.dec > + BoardModulePkg/BoardModulePkg.dec >=20 > [Pcd] > - gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPs2KbMsEnable > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable > gMinPlatformPkgTokenSpaceGuid.PcdPciExpNative > gMinPlatformPkgTokenSpaceGuid.PcdNativeAspmEnable > gMinPlatformPkgTokenSpaceGuid.PcdLowPowerS0Idle > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.inf > index db8ba7a822..9fe27f9fda 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/DxeMultiBoardAcpiSupportLib.inf > @@ -34,9 +34,10 @@ > MinPlatformPkg/MinPlatformPkg.dec > KabylakeOpenBoardPkg/OpenBoardPkg.dec > KabylakeSiliconPkg/SiPkg.dec > + BoardModulePkg/BoardModulePkg.dec >=20 > [Pcd] > - gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPs2KbMsEnable > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPciExpNative > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdNativeAspmEnable > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdLowPowerS0Idle > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > index f59248bba4..55edc1a2f8 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -311,6 +311,11 @@ > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf >=20 > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe. > inf > + MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf{ > + > + NULL|BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.inf > + } > UefiCpuPkg/CpuDxe/CpuDxe.inf >=20 > ShellPkg/Application/Shell/Shell.inf { @@ -408,3 +413,5 @@ > !endif > } > !endif > + BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > + > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > index 80efab1aad..d58466d390 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > @@ -335,6 +335,8 @@ INF > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > INF > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe. > inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > +INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > +INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf >=20 > INF ShellPkg/Application/Shell/Shell.inf >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc > index c68b8a49cf..c6f5ae7534 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc > @@ -308,6 +308,12 @@ > gMinPlatformPkgTokenSpaceGuid.PcdTestPointIbvPlatformFeature|{0x03, > 0x0F, 0x07, 0x1F, 0x1F, 0x0F, 0x0F, 0x07, 0x03, 0x00, 0x00, 0x00, 0x00, = 0x00, > 0x00, 0x00} !endif >=20 > + ###################################### > + # Board Configuration > + ###################################### > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable|1 > + gBoardModulePkgTokenSpaceGuid.PcdSuperIoPciIsaBridgeDevice|{0x00, > + 0x00, 0x1F, 0x00} > + > [PcdsFixedAtBuild.IA32] > ###################################### > # Edk2 Configuration > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeBoardAcpiTableLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeBoardAcpiTableLib.inf > index bfb58e868f..e0bf5823d8 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeBoardAcpiTableLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeBoardAcpiTableLib.inf > @@ -33,9 +33,10 @@ > MinPlatformPkg/MinPlatformPkg.dec > KabylakeOpenBoardPkg/OpenBoardPkg.dec > KabylakeSiliconPkg/SiPkg.dec > + BoardModulePkg/BoardModulePkg.dec >=20 > [Pcd] > - gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPs2KbMsEnable > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPciExpNative > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdNativeAspmEnable > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdLowPowerS0Idle > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeMultiBoardAcpiSupportLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeMultiBoardAcpiSupportLib.inf > index 00cdbe80ce..e5de9268e7 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeMultiBoardAcpiSupportLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeMultiBoardAcpiSupportLib.inf > @@ -34,9 +34,10 @@ > MinPlatformPkg/MinPlatformPkg.dec > KabylakeOpenBoardPkg/OpenBoardPkg.dec > KabylakeSiliconPkg/SiPkg.dec > + BoardModulePkg/BoardModulePkg.dec >=20 > [Pcd] > - gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPs2KbMsEnable > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPciExpNative > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdNativeAspmEnable > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdLowPowerS0Idle > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > index 7e65eeda6f..e7f5ed39d2 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > @@ -381,6 +381,11 @@ > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf >=20 > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe. > inf > + MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf{ > + > + NULL|BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.inf > + } > UefiCpuPkg/CpuDxe/CpuDxe.inf >=20 > !if gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1 @@ > -485,3 +490,4 @@ > !endif > } > !endif > + BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > index dbd6f2aa10..98eb7dcb5a 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > @@ -336,6 +336,8 @@ INF > MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > INF > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe. > inf > +INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > +INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf >=20 > INF ShellPkg/Application/Shell/Shell.inf >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d > sc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d > sc > index 34cc731313..580504cbc1 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d > sc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d > +++ sc > @@ -324,6 +324,13 @@ > gMinPlatformPkgTokenSpaceGuid.PcdTestPointIbvPlatformFeature|{0x03, > 0x0F, 0x07, 0x1F, 0x1F, 0x0F, 0x0F, 0x07, 0x03, 0x00, 0x00, 0x00, 0x00, = 0x00, > 0x00, 0x00} !endif >=20 > + > + ###################################### > + # Board Configuration > + ###################################### > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable|1 > + gBoardModulePkgTokenSpaceGuid.PcdSuperIoPciIsaBridgeDevice|{0x00, > + 0x00, 0x1F, 0x00} > + > [PcdsFixedAtBuild.IA32] > ###################################### > # Edk2 Configuration > diff --git a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > index 9680e63bad..01d6116616 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > +++ b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > @@ -288,8 +288,6 @@ > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdBoardUcmcGpioTableSize|0|UI > NT16|0x0000001 > # Misc >=20 > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdIoExpanderPresent|FALSE|BOOL > EAN|0x000000EC >=20 > - > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPs2KbMsEnable|1|UINT8|0x40 > 000009 > - >=20 > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdAcpiSleepState|1|UINT8|0x400 > 00002 >=20 > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdAcpiHibernate|1|UINT8|0x4000 > 0003 >=20 > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdLowPowerS0Idle|0|UINT8|0x40 > 000004 > -- > 2.19.1.windows.1 >=20 >=20 >=20