From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.3370.1573006148512688316 for ; Tue, 05 Nov 2019 18:09:08 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2019 18:09:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,272,1569308400"; d="scan'208";a="285515376" Received: from pgsmsx112.gar.corp.intel.com ([10.108.55.201]) by orsmga001.jf.intel.com with ESMTP; 05 Nov 2019 18:09:07 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.128]) by PGSMSX112.gar.corp.intel.com ([169.254.3.19]) with mapi id 14.03.0439.000; Wed, 6 Nov 2019 10:09:06 +0800 From: "Chiu, Chasel" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [Patch v2 8/9] SimicsOpenBoardPkg: Add Ps2 keyboard Support Thread-Topic: [edk2-platforms] [Patch v2 8/9] SimicsOpenBoardPkg: Add Ps2 keyboard Support Thread-Index: AQHVlEEr+onvYOAnCUCu6SRybIGc+qd9ZcrA Date: Wed, 6 Nov 2019 02:09:05 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5052329F@PGSMSX111.gar.corp.intel.com> References: <20191106012603.4724-1-prince.agyeman@intel.com> <20191106012603.4724-9-prince.agyeman@intel.com> In-Reply-To: <20191106012603.4724-9-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2NmOTk3YmQtYWJjNS00N2Y5LWFiZjQtMzFmZTU1NWEwM2FhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWjJZbWVqbXUwY2ZYT3hMcVVGbUpOYjJsaGVZbFJ0UXl2YVk5RFwvVkJDeUl2UGNrS1RJc2ZDQkN1cFRKNyt5NVYifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Agyeman, Prince > Sent: Wednesday, November 6, 2019 9:26 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [Patch v2 8/9] SimicsOpenBoardPkg: Add Ps2 > keyboard Support >=20 > Added BIOS keyboard support to BoardX58Ich10 >=20 > * Included BoardModulePkg's generic Super I/O DXE driver > * Configured Super I/O and Ps2 keyboard related PCD to enable Ps2 > keyboard >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 2 > ++ .../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 1 + > .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 6 > ++++++ > 3 files changed, 9 insertions(+) >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > index e0a02b4efc..7329b19e8e 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > @@ -283,3 +283,5 @@ > $(BOARD_PKG)/SimicsDxe/SimicsDxe.inf > $(BOARD_PKG)/SimicsVideoDxe/SimicsVideoDxe.inf > $(BOARD_PKG)/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > + BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > + > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > index 6dc7b4aa56..ef6b35c92f 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > @@ -212,6 +212,7 @@ INF > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > INF MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > +INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf >=20 > INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc > index 0298e4b12d..cd95755f91 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > +++ c > @@ -196,6 +196,12 @@ > gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuThreadCount|4 > gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicAddressBase|0xFEC01000 >=20 > + ###################################### > + # Board Configuration > + ###################################### > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable|1 > + gBoardModulePkgTokenSpaceGuid.PcdSuperIoPciIsaBridgeDevice|{0x00, > + 0x00, 0x1F, 0x00} > + > [PcdsFixedAtBuild.X64] > ###################################### > # Edk2 Configuration > -- > 2.19.1.windows.1