From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.5692.1573744912009666822 for ; Thu, 14 Nov 2019 07:21:52 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2019 07:21:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,304,1569308400"; d="scan'208";a="195063826" Received: from pgsmsx114.gar.corp.intel.com ([10.108.55.203]) by orsmga007.jf.intel.com with ESMTP; 14 Nov 2019 07:21:37 -0800 Received: from pgsmsx106.gar.corp.intel.com (10.221.44.98) by pgsmsx114.gar.corp.intel.com (10.108.55.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 Nov 2019 23:15:24 +0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.24]) by PGSMSX106.gar.corp.intel.com ([10.221.44.98]) with mapi id 14.03.0439.000; Thu, 14 Nov 2019 23:15:23 +0800 From: "Chiu, Chasel" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms] [PATCH V1 01/13] KabylakeSiliconPkg: Change MODULE_TYPE of SiliconInitLib to PEIM Thread-Topic: [edk2-platforms] [PATCH V1 01/13] KabylakeSiliconPkg: Change MODULE_TYPE of SiliconInitLib to PEIM Thread-Index: AQHVmrPqL+h/7YUPWECiQ5s2Vc6ioaeKxxWQ Date: Thu, 14 Nov 2019 15:15:23 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505A5D9B@PGSMSX111.gar.corp.intel.com> References: <20191114060655.5161-1-nathaniel.l.desimone@intel.com> <20191114060655.5161-2-nathaniel.l.desimone@intel.com> In-Reply-To: <20191114060655.5161-2-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjcwMmQ4MTAtMzg3Yy00NDc4LTkyMmYtMjY4NDgyMWU4YWU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTWdBSWRvcitNaktNcUNCK2xOeFlxOWRtWWpPOUlUQmFrZ09GZU43TDk5clwvdlNHYXdPNmh1RTFkYzE0dEM4bEMifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Return-Path: chasel.chiu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V1 01/13] KabylakeSiliconPkg: Change > MODULE_TYPE of SiliconInitLib to PEIM >=20 > This library contains PEI phase only code. For example, > ClearIchSmiAndWake() calls PeiServicesGetBootMode(). > Accordingly, this library should have never been marked as a BASE library= . >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Sai Chaganty > Signed-off-by: Nate DeSimone > --- > .../PeiSiliconInitLib.inf} | 3 ++- > .../{SiliconInitLib =3D> PeiSiliconInitLib}/SiliconInit.c | 0 > .../{SiliconInitLib =3D> PeiSiliconInitLib}/SiliconInitPreMem.c | 0 > 3 files changed, 2 insertions(+), 1 deletion(-) rename > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib/SiliconInitLib.i= nf =3D> > PeiSiliconInitLib/PeiSiliconInitLib.inf} (91%) rename > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =3D> > PeiSiliconInitLib}/SiliconInit.c (100%) rename > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =3D> > PeiSiliconInitLib}/SiliconInitPreMem.c (100%) >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLib.= inf > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSiliconIn= itLib.i > nf > similarity index 91% > rename from > Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLib.in= f > rename to > Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSiliconInit= Lib.inf > index 132080e876..ff83bf2835 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInit= Lib.inf > +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSili > +++ conInitLib.inf > @@ -11,8 +11,9 @@ > BASE_NAME =3D SiliconInitLib FILE_GUID > =3D 72CD3A7B-FEA5-4F5E-9165-4DD12187BB13 VERSION_STRING > =3D 1.0- MODULE_TYPE =3D BASE+ MODULE_TYPE > =3D PEIM LIBRARY_CLASS =3D SiliconInitLib+ # # The > following information is for reference only and not required by the build > tools. #diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInit.c > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.= c > similarity index 100% > rename from > Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInit.c > rename to > Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitPreM= em.c > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitP= reMe > m.c > similarity index 100% > rename from > Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitPreMem= .c > rename to > Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPre= Mem.c > -- > 2.23.0.windows.1