From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.2634.1574399753946044814 for ; Thu, 21 Nov 2019 21:15:54 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 21:15:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="219351934" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by orsmga002.jf.intel.com with ESMTP; 21 Nov 2019 21:15:52 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.24]) by PGSMSX102.gar.corp.intel.com ([10.221.44.80]) with mapi id 14.03.0439.000; Fri, 22 Nov 2019 13:15:51 +0800 From: "Chiu, Chasel" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old comments Thread-Topic: [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old comments Thread-Index: AQHVoEn+fOHeU8fMF0yj8qWUf47sUKeWpzRQ Date: Fri, 22 Nov 2019 05:15:51 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505AB878@PGSMSX111.gar.corp.intel.com> References: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> <20191121085853.2626-4-nathaniel.l.desimone@intel.com> In-Reply-To: <20191121085853.2626-4-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWU4NTNlN2UtMmVlMi00NWRmLWE2ODEtMDZmZDBhODJmYjIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU1FYVDdXVzhCU3lpdGdyYlJOODE0WmliNDRCYVI4TFlqbFE0d1F2WGJBT2k4ZEhhRnh5dkREK2FVeUE4UHIwYyJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, November 21, 2019 4:59 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup ol= d > comments >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Sai Chaganty > Signed-off-by: Nate DeSimone > --- > .../Library/PeiSiliconInitLib/SiliconInit.c | 3 +++ > .../Library/PeiSiliconInitLib/SiliconInitPreMem.c | 4 +--- > 2 files changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.= c > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.= c > index d09bec0489..2057973d4b 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconI= nit.c > +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silicon > +++ Init.c > @@ -199,6 +199,9 @@ ClearIchSmiAndWake ( > return EFI_SUCCESS; } +/**+ Late Silicon Initialization+**/ VOID > LateSiliconInit ( VOIDdiff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitP= reMe > m.c > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitP= reMe > m.c > index 65a67a6795..6af9e0fcfc 100644 > --- > a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitP= reMe > m.c > +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silicon > +++ InitPreMem.c > @@ -31,9 +31,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include > -//@todo it should be moved to Si Pkg. /**- Early Platform PCH > initialization+ Early Silicon initialization **/ VOID EarlySiliconInit (= @@ > -233,4 +232,3 @@ SiliconInit ( > } }--- > 2.24.0.windows.2