From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.2643.1574399774178871297 for ; Thu, 21 Nov 2019 21:16:14 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 21:16:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="205380333" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by fmsmga007.fm.intel.com with ESMTP; 21 Nov 2019 21:16:13 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.24]) by KMSMSX154.gar.corp.intel.com ([169.254.12.98]) with mapi id 14.03.0439.000; Fri, 22 Nov 2019 13:16:10 +0800 From: "Chiu, Chasel" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup Thread-Topic: [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup Thread-Index: AQHVoEn9HN2jk4hHaUakk8slaVbnY6eWp0tw Date: Fri, 22 Nov 2019 05:16:10 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505AB88F@PGSMSX111.gar.corp.intel.com> References: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> <20191121085853.2626-6-nathaniel.l.desimone@intel.com> In-Reply-To: <20191121085853.2626-6-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjJiNWE0ZDAtMDA0OC00YzgzLTkzYTMtMjEzNmRmMGI4NmY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWTFESFpDdTFnU2MzUFFkaEFIekZlZ2g4bXZ1SDFaR2RoK3VhQ3RjRVV0WjQzVGVZc2Y1Q0JGaVQzWm1MT20zdyJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, November 21, 2019 4:59 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: > TcoWdtHob.h Cleanup >=20 > Removes duplicate EFI_HOB_GENERIC_HEADER and EFI_HOB_GUID_TYPE > definitions from TcoWdtHob.h >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Sai Chaganty > Signed-off-by: Nate DeSimone > --- > .../Include/Guid/TcoWdtHob.h | 23 ++----------------- > 1 file changed, 2 insertions(+), 21 deletions(-) >=20 > diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h > b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h > index 5bf2527963..9e83ed49c1 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h > @@ -7,35 +7,16 @@ > #ifndef __TCO_WDT_HOB_H__ #define __TCO_WDT_HOB_H__ +#include > + #define TCO_WDT_HOB_GUID \ { \ 0x3e405418, 0xd8c, > 0x4f1a, { 0xb0, 0x55, 0xbe, 0xf9, 0x8, 0x41, 0x46, 0x8d } \ } -#ifndef > _PEI_HOB_H_-#ifndef __HOB__H__-#ifndef __PI_HOB_H__-typedef struct > _EFI_HOB_GENERIC_HEADER {- UINT16 HobType;- UINT16 > HobLength;- UINT32 Reserved;-} EFI_HOB_GENERIC_HEADER;--typedef > struct _EFI_HOB_GUID_TYPE {- EFI_HOB_GENERIC_HEADER Header;- > EFI_GUID Name;- //- // Guid specific data goes here- > //-} EFI_HOB_GUID_TYPE;-#endif-#endif-#endif- typedef struct > { EFI_HOB_GUID_TYPE Header; UINT8 > TcoRebootHappened; } TCO_WDT_HOB; #endif--- > 2.24.0.windows.2