From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.2673.1574399897613449047 for ; Thu, 21 Nov 2019 21:18:17 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 21:18:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="216292802" Received: from kmsmsx155.gar.corp.intel.com ([172.21.73.106]) by fmsmga001.fm.intel.com with ESMTP; 21 Nov 2019 21:18:15 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.24]) by KMSMSX155.gar.corp.intel.com ([169.254.15.202]) with mapi id 14.03.0439.000; Fri, 22 Nov 2019 13:18:14 +0800 From: "Chiu, Chasel" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" Subject: Re: [edk2-platforms] [PATCH V2 12/14] KabylakeOpenBoardPkg: Add support for PcdFspDispatchModeUseFspPeiMain Thread-Topic: [edk2-platforms] [PATCH V2 12/14] KabylakeOpenBoardPkg: Add support for PcdFspDispatchModeUseFspPeiMain Thread-Index: AQHVoEn/XdEBmUTuXkOemrlGO/G7h6eWp8Xg Date: Fri, 22 Nov 2019 05:18:14 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505AB8FC@PGSMSX111.gar.corp.intel.com> References: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> <20191121085853.2626-13-nathaniel.l.desimone@intel.com> In-Reply-To: <20191121085853.2626-13-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzI2ZWZkM2QtMzRlYS00YjM4LTgwYWUtNGY1NjE0YWJkODY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWXRaUW9LUWZVQ05oSXRkSzM4UkQrZVRxTnA3XC80NnI0Zjl1a2dXblRMelplYjFSOUpPdFwvSEFwY1FLR2ROZmpOIn0= x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, November 21, 2019 4:59 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH V2 12/14] KabylakeOpenBoardPkg: Add > support for PcdFspDispatchModeUseFspPeiMain >=20 > If PcdFspDispatchModeUseFspPeiMain is FALSE, then the BoardPkg should > include PeiMain in FvPreMemory. >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Signed-off-by: Nate DeSimone > --- > .../KabylakeRvp3/OpenBoardPkg.fdf | 5 +++-- > .../KabylakeRvp3/OpenBoardPkgPcd.dsc | 20 > +++++++++++++++++++ > 2 files changed, 23 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > index 98eb7dcb5a..3b3b153b68 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > @@ -229,10 +229,11 @@ READ_LOCK_STATUS =3D TRUE > FvNameGuid =3D FC8FE6B5-CD9B-411E-BD8F-31824D0CDE3D INF > UefiCpuPkg/SecCore/SecCore.inf-!if > (gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode =3D=3D FALSE) || > (gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1)+!if > (gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode =3D=3D FALSE) || > (gMinPlatformPkgTokenSpaceGuid.PcdFspDispatchModeUseFspPeiMain =3D=3D > FALSE) || (gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1) = # > # PeiMain is needed only for FSP API mode or EDK2 build,-# in FSP dispatc= h > mode the one inside FSP Binary is launched.+# in FSP dispatch mode the on= e > inside FSP Binary is launched+# unless requested otherwise > (PcdFspDispatchModeUseFspPeiMain =3D=3D FALSE). # INF > MdeModulePkg/Core/Pei/PeiMain.inf !endifdiff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d > sc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d > sc > index 580504cbc1..5474edd01c 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d > sc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d > +++ sc > @@ -39,6 +39,26 @@ > # gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode|TRUE + > #+ # FALSE: The PEI Main included in FvPreMemory is used to dispatch all > PEIMs+ # (both inside FSP and outside FSP).+ # Pros:+ > # * PEI Main is re-built from source and is always the latest > version+ # * Platform code can link any desired LibraryClass to > PEI Main+ # (Ex: Custom DebugLib instance, SerialPortLib, > etc.)+ # Cons:+ # * The PEI Main being used to > execute FSP PEIMs is not the PEI Main+ # that the FSP PEIMs > were tested with, adding risk of breakage.+ # * Two copies of > PEI Main will exist in the final binary,+ # #1 in FSP-M, #2 i= n > FvPreMemory. The copy in FSP-M is never+ # executed, > wasting space.+ #+ # TRUE: The PEI Main included in FSP is > used to dispatch all PEIMs+ # (both inside FSP and outside FSP). > PEI Main will not be included in+ # FvPreMemory. This is the > default and is the recommended choice.+ #+ > gMinPlatformPkgTokenSpaceGuid.PcdFspDispatchModeUseFspPeiMain|TRUE > + # # FSP Base address PCD will be updated in FDF basing on flash map= . > #-- > 2.24.0.windows.2