From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.1176.1574825464974172452 for ; Tue, 26 Nov 2019 19:31:05 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Nov 2019 19:31:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,248,1571727600"; d="scan'208";a="206648684" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by fmsmga008.fm.intel.com with ESMTP; 26 Nov 2019 19:31:03 -0800 Received: from pgsmsx110.gar.corp.intel.com (10.221.44.111) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 27 Nov 2019 11:26:34 +0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.24]) by PGSMSX110.gar.corp.intel.com ([10.221.44.111]) with mapi id 14.03.0439.000; Wed, 27 Nov 2019 11:26:34 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Gao, Zhichao" Subject: Re: [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove ResetSystemLib.h override Thread-Topic: [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove ResetSystemLib.h override Thread-Index: AQHVpM5YpMrzX5i5tkG2OXdegGw2ZKeeW0eg Date: Wed, 27 Nov 2019 03:26:33 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505AF563@PGSMSX111.gar.corp.intel.com> References: <20191127025643.32056-1-michael.a.kubacki@intel.com> <20191127025643.32056-2-michael.a.kubacki@intel.com> In-Reply-To: <20191127025643.32056-2-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDc0MWQ3NzktZmZiZC00NDc4LWE0NzctMmIwY2Q4ZThiMmQ3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOUtsWjh2Vm42RjNrZDY5QTE2U0FGY2hVaDE5K0xCTTVJSkZ6b0ZPYjNrVHdQNU1GcHJyZysyKzEwXC9rZFFENGkifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Return-Path: chasel.chiu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Wednesday, November 27, 2019 10:57 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Zhichao > Subject: [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove > ResetSystemLib.h override >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2375 >=20 > Removes a stale ResetSystemLib.h override in KabylakeSiliconPkg that does > not contain the prototype for ResetSystem () and ResetPlatformSpecific ()= . >=20 > The ResetSystemLib.h file from MdeModulePkg will be used. Any INF files > that did not include the MdeModulePkg.dec under [Packages] were updated > to do so. >=20 > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Zhichao Gao > Signed-off-by: Michael Kubacki > --- >=20 > Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/DxeResetSy= s > temLib.inf | 3 +- >=20 > Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystemLib/Dxe > RuntimeResetSystemLib.inf | 3 +- >=20 > Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiPchResetLi= b.i > nf | 3 +- >=20 > Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiResetSy= st > emLib.inf | 3 +- >=20 > Silicon/Intel/KabylakeSiliconPkg/SampleCode/MdeModulePkg/Include/Librar > y/ResetSystemLib.h | 62 -------------------- > 5 files changed, 8 insertions(+), 66 deletions(-) >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/DxeReset= S > ystemLib.inf > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/DxeReset= S > ystemLib.inf > index aa8877140a..46313bf35f 100644 > --- > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/DxeReset= S > ystemLib.inf > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/Dxe > +++ ResetSystemLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Component description file for Intel Ich7 Reset System Library. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -35,6 +35,7 @@ > PchCycleDecodingLib >=20 > [Packages] > MdePkg/MdePkg.dec > +MdeModulePkg/MdeModulePkg.dec > KabylakeSiliconPkg/SiPkg.dec >=20 >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystemLib/D > xeRuntimeResetSystemLib.inf > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystemLib/D > xeRuntimeResetSystemLib.inf > index 6b27661603..c7fad31c71 100644 > --- > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystemLib/D > xeRuntimeResetSystemLib.inf > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystem > +++ Lib/DxeRuntimeResetSystemLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Component description file for Intel Ich7 Reset System Library. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -36,6 +36,7 @@ > PchCycleDecodingLib >=20 > [Packages] > MdePkg/MdePkg.dec > +MdeModulePkg/MdeModulePkg.dec > KabylakeSiliconPkg/SiPkg.dec >=20 >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiPchReset= Li > b.inf > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiPchReset= Li > b.inf > index b04f4006ef..29f69078a4 100644 > --- > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiPchReset= Li > b.inf > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiPch > +++ ResetLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Component description file for PCH Reset Lib Pei Phase # -# Copyright= (c) > 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -28,6 +28,7 @@ > ResetSystemLib >=20 > [Packages] > MdePkg/MdePkg.dec > +MdeModulePkg/MdeModulePkg.dec > KabylakeSiliconPkg/SiPkg.dec >=20 > [Sources] > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiReset= Sy > stemLib.inf > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiReset= Sy > stemLib.inf > index 18a92a6f18..3c6ff78863 100644 > --- > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiReset= Sy > stemLib.inf > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/Pei > +++ ResetSystemLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Component description file for Intel Ich7 Reset System Library. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -32,6 +32,7 @@ > PchCycleDecodingLib >=20 > [Packages] > MdePkg/MdePkg.dec > +MdeModulePkg/MdeModulePkg.dec > KabylakeSiliconPkg/SiPkg.dec >=20 >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/SampleCode/MdeModulePkg/Include/Libr > ary/ResetSystemLib.h > b/Silicon/Intel/KabylakeSiliconPkg/SampleCode/MdeModulePkg/Include/Libr > ary/ResetSystemLib.h > deleted file mode 100644 > index 75d3e15ed7..0000000000 > --- > a/Silicon/Intel/KabylakeSiliconPkg/SampleCode/MdeModulePkg/Include/Libr > ary/ResetSystemLib.h > +++ /dev/null > @@ -1,62 +0,0 @@ > -/** @file > - System reset Library Services. This library class defines a set of > - methods that reset the whole system. > - > -Copyright (c) 2005 - 2010, Intel Corporation. All rights reserved.
> -SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef __RESET_SYSTEM_LIB_H__ > -#define __RESET_SYSTEM_LIB_H__ > - > -/** > - This function causes a system-wide reset (cold reset), in which > - all circuitry within the system returns to its initial state. This typ= e of reset > - is asynchronous to system operation and operates without regard to > - cycle boundaries. > - > - If this function returns, it means that the system does not support co= ld > reset. > -**/ > -VOID > -EFIAPI > -ResetCold ( > - VOID > - ); > - > -/** > - This function causes a system-wide initialization (warm reset), in whi= ch > all processors > - are set to their initial state. Pending cycles are not corrupted. > - > - If this function returns, it means that the system does not support wa= rm > reset. > -**/ > -VOID > -EFIAPI > -ResetWarm ( > - VOID > - ); > - > -/** > - This function causes the system to enter a power state equivalent > - to the ACPI G2/S5 or G3 states. > - > - If this function returns, it means that the system does not support > shutdown reset. > -**/ > -VOID > -EFIAPI > -ResetShutdown ( > - VOID > - ); > - > -/** > - This function causes the system to enter S3 and then wake up > immediately. > - > - If this function returns, it means that the system does not support S3 > feature. > -**/ > -VOID > -EFIAPI > -EnterS3WithImmediateWake ( > - VOID > - ); > - > -#endif > -- > 2.16.2.windows.1