From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.5408.1575009757109744161 for ; Thu, 28 Nov 2019 22:42:37 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 22:42:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,256,1571727600"; d="scan'208";a="234620155" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by fmsmga004.fm.intel.com with ESMTP; 28 Nov 2019 22:42:35 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.24]) by PGSMSX102.gar.corp.intel.com ([10.221.44.80]) with mapi id 14.03.0439.000; Fri, 29 Nov 2019 14:42:35 +0800 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2 25/47] KabylakeOpenBoardPkg/KabylakeRvp3: Add PEI_ARCH and DXE_ARCH Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V2 25/47] KabylakeOpenBoardPkg/KabylakeRvp3: Add PEI_ARCH and DXE_ARCH Thread-Index: AQHVpYhL6DFSDZdGGkiU4jITnC+SZKehtTJA Date: Fri, 29 Nov 2019 06:42:34 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505B1EDF@PGSMSX111.gar.corp.intel.com> References: <20191128010614.43628-1-michael.a.kubacki@intel.com> <20191128010614.43628-26-michael.a.kubacki@intel.com> In-Reply-To: <20191128010614.43628-26-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzhiM2FkMTYtZWJlNC00Y2RiLWE2MmUtM2I4YTE3Mjg0MjE1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWkNJWVhpM0I3dEN0UWNhaUd1cCtrRnE3NHZLY1wvXC9EbFwvbjYyN0tOOUhpMDJrUUNac25sU1NGcjVYZFNMQUZyVCJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Thursday, November 28, 2019 9:06 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-devel] [edk2-platforms][PATCH V2 25/47] > KabylakeOpenBoardPkg/KabylakeRvp3: Add PEI_ARCH and DXE_ARCH >=20 > This change adds two new macros to OpenBoardPkg.dsc that identify the > build architecture for PEI and DXE modules. The intention of this macro = is to > ensure that all DSC files that compose the package build (such as those > included from MinPlatformPkg or an advanced feature package) build > phase-specific drivers for the architecture defined by the board package= . >=20 > This is a macro that is required in all Minimum Platform board packages. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Michael Kubacki > Reviewed-by: Nate DeSimone > --- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | > 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > index 4b07c0a684..831e441d70 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > @@ -13,6 +13,8 @@ > DEFINE PLATFORM_BOARD_PACKAGE =3D > KabylakeOpenBoardPkg > DEFINE BOARD =3D KabylakeRvp3 > DEFINE PROJECT =3D > $(PLATFORM_BOARD_PACKAGE)/$(BOARD) > + DEFINE PEI_ARCH =3D IA32 > + DEFINE DXE_ARCH =3D X64 >=20 > # > # Include PCD configuration for this board. > @@ -102,10 +104,15 @@ > ####################################### > # Component Includes > ####################################### > + > +# @todo: Change below line to [Components.$(PEI_ARCH)] after > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2308 > +# is completed > [Components.IA32] > !include $(PLATFORM_PACKAGE)/Include/Dsc/CorePeiInclude.dsc > !include $(PLATFORM_SI_PACKAGE)/SiPkgPei.dsc >=20 > +# @todo: Change below line to [Components.$(DXE_ARCH)] after > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2308 > +# is completed > [Components.X64] > !include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc > !include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc > @@ -266,6 +273,11 @@ >=20 > TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/S > mmTestPointCheckLib.inf > !endif >=20 > +####################################### > +# PEI Components > +####################################### > +# @todo: Change below line to [Components.$(PEI_ARCH)] after > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2308 > +# is completed > [Components.IA32] > ####################################### > # Edk2 Packages > @@ -373,6 +385,11 @@ > !endif > $(PLATFORM_BOARD_PACKAGE)/BiosInfo/BiosInfo.inf >=20 > +####################################### > +# DXE Components > +####################################### > +# @todo: Change below line to [Components.$(DXE_ARCH)] after > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2308 > +# is completed > [Components.X64] > ####################################### > # Edk2 Packages > -- > 2.16.2.windows.1 >=20 >=20 >=20