From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.5520.1575010577411363544 for ; Thu, 28 Nov 2019 22:56:17 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 22:56:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,256,1571727600"; d="scan'208";a="410882962" Received: from kmsmsx156.gar.corp.intel.com ([172.21.138.133]) by fmsmga006.fm.intel.com with ESMTP; 28 Nov 2019 22:56:16 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.24]) by KMSMSX156.gar.corp.intel.com ([169.254.1.162]) with mapi id 14.03.0439.000; Fri, 29 Nov 2019 14:52:15 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Gao, Liming" , "Agyeman, Prince" Subject: Re: [edk2-platforms][PATCH V2 33/47] Platform/Intel: Add advanced feature build support Thread-Topic: [edk2-platforms][PATCH V2 33/47] Platform/Intel: Add advanced feature build support Thread-Index: AQHVpYhXj2dOxakLBUCYq8qVyU/Zpqeht/hA Date: Fri, 29 Nov 2019 06:52:14 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505B1F68@PGSMSX111.gar.corp.intel.com> References: <20191128010614.43628-1-michael.a.kubacki@intel.com> <20191128010614.43628-34-michael.a.kubacki@intel.com> In-Reply-To: <20191128010614.43628-34-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDA3MGM1ZDktM2EzOS00MjFkLTkwNDAtYzlkOTViOWUxYzE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYXZvbDR0dzVqd1FmQXdHQitjcjVZTmliRVBXeFNmSWRrSlEwb2pMY3V0VkRwbnIyamFIQU9HTHhsbWpmenRXaSJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Thursday, November 28, 2019 9:06 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming ; > Agyeman, Prince > Subject: [edk2-platforms][PATCH V2 33/47] Platform/Intel: Add advanced > feature build support >=20 > This change adds the ability for board packages built with build_bios.py = to > build advanced features located in Features/Intel. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Agyeman Prince > Signed-off-by: Michael Kubacki > Reviewed-by: Nate DeSimone > --- > Platform/Intel/build.cfg | 1 + > Platform/Intel/build_bios.py | 3 +++ > 2 files changed, 4 insertions(+) >=20 > diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index > e42db243f6..86a9115021 100644 > --- a/Platform/Intel/build.cfg > +++ b/Platform/Intel/build.cfg > @@ -12,6 +12,7 @@ WORKSPACE_FSP_BIN =3D FSP EDK_TOOLS_BIN =3D > edk2-BaseTools-win32 EDK_BASETOOLS =3D BaseTools > WORKSPACE_DRIVERS =3D edk2-platforms/Drivers > +WORKSPACE_FEATURES =3D edk2-platforms/Features/Intel > WORKSPACE_PLATFORM =3D edk2-platforms/Platform/Intel > WORKSPACE_SILICON =3D edk2-platforms/Silicon/Intel > WORKSPACE_PLATFORM_BIN =3D diff --git a/Platform/Intel/build_bios.py > b/Platform/Intel/build_bios.py index ea098de705..1ef35aca0a 100644 > --- a/Platform/Intel/build_bios.py > +++ b/Platform/Intel/build_bios.py > @@ -104,6 +104,8 @@ def pre_build(build_config, build_type=3D"DEBUG", > silent=3DFalse, toolchain=3DNone): >=20 > config["WORKSPACE_PLATFORM"]) > config["WORKSPACE_SILICON"] =3D os.path.join(config["WORKSPACE"], >=20 > config["WORKSPACE_SILICON"]) > + config["WORKSPACE_FEATURES"] =3D os.path.join(config["WORKSPACE"], > + > + config["WORKSPACE_FEATURES"]) > config["WORKSPACE_DRIVERS"] =3D os.path.join(config["WORKSPACE"], >=20 > config["WORKSPACE_DRIVERS"]) > config["WORKSPACE_PLATFORM_BIN"] =3D \ @@ -117,6 +119,7 @@ def > pre_build(build_config, build_type=3D"DEBUG", silent=3DFalse, toolchain= =3DNone): > config["PACKAGES_PATH"] =3D config["WORKSPACE_PLATFORM"] > config["PACKAGES_PATH"] +=3D os.pathsep + > config["WORKSPACE_SILICON"] > config["PACKAGES_PATH"] +=3D os.pathsep + > config["WORKSPACE_SILICON_BIN"] > + config["PACKAGES_PATH"] +=3D os.pathsep + > + config["WORKSPACE_FEATURES"] > config["PACKAGES_PATH"] +=3D os.pathsep + > config["WORKSPACE_DRIVERS"] > config["PACKAGES_PATH"] +=3D os.pathsep + \ > os.path.join(config["WORKSPACE"], "FSP") > -- > 2.16.2.windows.1