From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.5556.1575011390809736735 for ; Thu, 28 Nov 2019 23:09:50 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 23:09:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,256,1571727600"; d="scan'208";a="217732986" Received: from kmsmsx156.gar.corp.intel.com ([172.21.138.133]) by fmsmga001.fm.intel.com with ESMTP; 28 Nov 2019 23:09:49 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.24]) by KMSMSX156.gar.corp.intel.com ([169.254.1.162]) with mapi id 14.03.0439.000; Fri, 29 Nov 2019 15:02:02 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [edk2-platforms][PATCH V2 37/47] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Enable advanced features Thread-Topic: [edk2-platforms][PATCH V2 37/47] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Enable advanced features Thread-Index: AQHVpYhiCPAbsD7yuE6JNaFs3GuCTaehurZA Date: Fri, 29 Nov 2019 07:02:02 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505B1F9A@PGSMSX111.gar.corp.intel.com> References: <20191128010614.43628-1-michael.a.kubacki@intel.com> <20191128010614.43628-38-michael.a.kubacki@intel.com> In-Reply-To: <20191128010614.43628-38-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDFiMTk0ZWQtMDdhZi00ZDY5LTkyMjktYjJlNjA3YWM2ZWI5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYUNcL1Y0NEVBZkVkK29MaDl1S2VLZ29kVm9GNm5vZjhaQXpnelZFNUl1R0N0bnU3M1lIRTZ6N2VmbkZFelFFdUQifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Thursday, November 28, 2019 9:06 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH V2 37/47] > WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Enable advanced features >=20 > This change enables advanced features to be used by the WhiskeylakeURvp > board in WhiskeylakeOpenBoardPkg. >=20 > Some platform macros in OpenBoardPkg.dsc are consolidated so all values > are set at the top of the file before including advanced feature code. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Michael Kubacki > Reviewed-by: Nate DeSimone > --- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg. > dsc | 44 +++++++++----------- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg > Pcd.dsc | 1 + >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg. > fdf | 4 ++ > 3 files changed, 25 insertions(+), 24 deletions(-) >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kg.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kg.dsc > index ae3fec05ed..47e156be08 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kg.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > k > +++ g.dsc > @@ -17,36 +17,32 @@ > DEFINE PROJECT =3D > $(PLATFORM_BOARD_PACKAGE)/$(BOARD) > DEFINE PEI_ARCH =3D IA32 > DEFINE DXE_ARCH =3D X64 > - > - # > - # Include PCD configuration for this board. > - # > - !include OpenBoardPkgPcd.dsc > - > -############################################################### > ################# > -# > -# Defines Section - statements that will be processed to create a Makefi= le. > -# > -############################################################### > ################# > -[Defines] > - PLATFORM_NAME =3D $(PLATFORM_PACKAGE) > - PLATFORM_GUID =3D > 84D0F5BD-0EF3-4CC0-9B09-F2D0F2AA5C5E > - PLATFORM_VERSION =3D 0.1 > - DSC_SPECIFICATION =3D 0x00010005 > - OUTPUT_DIRECTORY =3D Build/$(PROJECT) > - SUPPORTED_ARCHITECTURES =3D IA32|X64 > - BUILD_TARGETS =3D DEBUG|RELEASE > - SKUID_IDENTIFIER =3D ALL > - FLASH_DEFINITION =3D > $(PROJECT)/OpenBoardPkg.fdf > - > - FIX_LOAD_TOP_MEMORY_ADDRESS =3D 0x0 > - DEFINE TOP_MEMORY_ADDRESS =3D 0x0 > + DEFINE TOP_MEMORY_ADDRESS =3D 0x0 >=20 > # > # Default value for OpenBoardPkg.fdf use > # > DEFINE BIOS_SIZE_OPTION =3D SIZE_70 >=20 > + PLATFORM_NAME =3D $(PLATFORM_PACKAGE) > + PLATFORM_GUID =3D > 84D0F5BD-0EF3-4CC0-9B09-F2D0F2AA5C5E > + PLATFORM_VERSION =3D 0.1 > + DSC_SPECIFICATION =3D 0x00010005 > + OUTPUT_DIRECTORY =3D Build/$(PROJECT) > + SUPPORTED_ARCHITECTURES =3D IA32|X64 > + BUILD_TARGETS =3D DEBUG|RELEASE > + SKUID_IDENTIFIER =3D ALL > + > + FLASH_DEFINITION =3D > $(PROJECT)/OpenBoardPkg.fdf > + FIX_LOAD_TOP_MEMORY_ADDRESS =3D 0x0 > + > + # > + # Include PCD configuration for this board. > + # > + !include > + > AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaro > und.d > + sc > + !include OpenBoardPkgPcd.dsc > + !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc > + >=20 > ################################################################ > ################ > # > # SKU Identification section - list of all SKU IDs supported by this boa= rd. > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kgPcd.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kgPcd.dsc > index 52471cb25b..906f7b7ade 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kgPcd.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > k > +++ gPcd.dsc > @@ -24,6 +24,7 @@ > # Stage 3 - boot to shell only > # Stage 4 - boot to OS > # Stage 5 - boot to OS with security boot enabled > + # Stage 6 - boot with advanced features enabled > # > gMinPlatformPkgTokenSpaceGuid.PcdBootStage|4 >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kg.fdf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kg.fdf > index 130930ad40..f39b41b186 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kg.fdf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > k > +++ g.fdf > @@ -623,6 +623,8 @@ READ_LOCK_CAP =3D TRUE > READ_LOCK_STATUS =3D TRUE > FvNameGuid =3D 6053D78A-457E-4490-A237-31D0FBE2F305 >=20 > +!include AdvancedFeaturePkg/Include/PreMemory.fdf > + > !if gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdTbtEnable =3D=3D TRUE > INF $(PLATFORM_BOARD_PACKAGE)/Features/Tbt/TbtInit/Pei/PeiTbtInit.inf > !endif > @@ -649,6 +651,8 @@ READ_LOCK_CAP =3D TRUE > READ_LOCK_STATUS =3D TRUE > FvNameGuid =3D BE3DF86F-E464-44A3-83F7-0D27E6B88C27 >=20 > +!include AdvancedFeaturePkg/Include/PostMemory.fdf > + > !if gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdTbtEnable =3D=3D TRUE > INF $(PLATFORM_BOARD_PACKAGE)/Features/Tbt/TbtInit/Dxe/TbtDxe.inf > INF $(PLATFORM_BOARD_PACKAGE)/Features/PciHotPlug/PciHotPlug.inf > -- > 2.16.2.windows.1