From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.481.1576456369073710418 for ; Sun, 15 Dec 2019 16:32:49 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Dec 2019 16:32:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,319,1571727600"; d="scan'208";a="364874574" Received: from kmsmsx155.gar.corp.intel.com ([172.21.73.106]) by orsmga004.jf.intel.com with ESMTP; 15 Dec 2019 16:32:27 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.106]) by KMSMSX155.gar.corp.intel.com ([169.254.15.24]) with mapi id 14.03.0439.000; Mon, 16 Dec 2019 08:32:26 +0800 From: "Chiu, Chasel" To: "Agyeman, Prince" , "Desimone, Nathaniel L" CC: "Kubacki, Michael A" , "devel@edk2.groups.io" Subject: Re: [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Topic: [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Index: AQHVsh3hZxcNfULf/k61WCN6xlkZnKe76ucA Date: Mon, 16 Dec 2019 00:32:26 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505CA6B9@PGSMSX111.gar.corp.intel.com> References: <8d09f32eda0d6e8fdc40c7be6e8472323db4c1c5.1576286588.git.prince.agyeman@intel.com> In-Reply-To: <8d09f32eda0d6e8fdc40c7be6e8472323db4c1c5.1576286588.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGQ3NWVhZWYtZTI2My00MTMzLWFhNGYtZTFjOWI3ODkxYjY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRys0RzNHVTYwUW1tUUh4ME5ERlJCNEd5bXlyQmo3TWZaMEdkeklkSjFFU0RBTTNJVkFjYWNxVHFiUkxQZFd4cSJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Nate, Prince, I would recommend that we set larger gSiPkgTokenSpaceGuid.PcdPeiTemporaryRa= mStackSize so we do not have to update this again and again later when requ= ired temporary ram increased by enabling some boot loader features. How about set it to 0x30000? Thanks, Chasel > -----Original Message----- > From: Agyeman, Prince > Sent: Saturday, December 14, 2019 9:29 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: Update > PCDs to enable stack sharing >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2409 >=20 > Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing. > This fixes the boot failure seen with the latest Coffee Lake (CFL) FSP bi= nary (v > 7.0.68.41) >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Michael Kubacki >=20 > Signed-off-by: Prince Agyeman > --- > .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 11 > +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kgPcd.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kgPcd.dsc > index 906f7b7ade..cfe42883be 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kgPcd.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > k > +++ gPcd.dsc > @@ -54,15 +54,14 @@ > gSiPkgTokenSpaceGuid.PcdTsegSize|0x1000000 >=20 > # > - # FSP API mode does not share stack with the boot loader, > - # so FSP needs more temporary memory for FSP heap + stack size. > + # When sharing stack with boot loader, FSP only needs small temp ram > + for heap > # > - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x26000 > + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x10000 > + > # > - # FSP API mode does not need to enlarge the boot loader stack size > - # since the stacks are separate. > + # Boot loader stack size has to be big enough to executing FSP > # > - gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 > + gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x28000 >=20 > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 >=20 > gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000 > -- > 2.19.1.windows.1