From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.2666.1576557018500447223 for ; Mon, 16 Dec 2019 20:30:18 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Dec 2019 20:30:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,324,1571727600"; d="scan'208";a="217388598" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga006.jf.intel.com with ESMTP; 16 Dec 2019 20:30:16 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.106]) by PGSMSX101.gar.corp.intel.com ([169.254.1.61]) with mapi id 14.03.0439.000; Tue, 17 Dec 2019 12:24:10 +0800 From: "Chiu, Chasel" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH 04/11] MinPlatformPkg: Add BDS Board Boot Manager library Thread-Topic: [edk2-platforms] [PATCH 04/11] MinPlatformPkg: Add BDS Board Boot Manager library Thread-Index: AQHVsh5jq+56LVNjnEW3h/g28etKoKe9vsxA Date: Tue, 17 Dec 2019 04:24:10 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505D1CA7@PGSMSX111.gar.corp.intel.com> References: <1a09aca176f54fff55f69ad40935d01d7330350a.1576282834.git.prince.agyeman@intel.com> In-Reply-To: <1a09aca176f54fff55f69ad40935d01d7330350a.1576282834.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjU5OGEwMjAtZTQwNy00N2ZmLWJhMjAtMmY0MTNjM2ZjYzA5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibXo4Qjl6eWk4YW04VDdxZVcwcEc2MUk1SHFybW96R3JtazZGREdqd1RqazB5TU9kbGwzaTRFclhSditEbXRBNSJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Prince, BoardBootManagerLib.c is added as new file so it should have 2019 in copyri= ght. With that Reviewed-by: Chasel Chiu > -----Original Message----- > From: Agyeman, Prince > Sent: Saturday, December 14, 2019 9:33 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 04/11] MinPlatformPkg: Add BDS Board > Boot Manager library >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 >=20 > As Minplatform's PlatformBootManager library instance implements event > signals (as specified in the minimum platform specification) to trigger b= oard > actions, some of its functions namely PlatformBootManagerWaitCallback > and PlatformBootManagerUnableToBoot will not have events signaled for > boards to take action. >=20 > This library implements PlatformBootManagerWaitCallback and > PlatformBootManagerUnableToBoot which will be linked to Minplatform's > PlatformBootManager libary instance. >=20 > Added is an interface/header file that defines the board boot manager > library. >=20 > Also added is a NULL implementation of the board boot manager library >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../BoardBootManagerLib.c | 38 > ++++++++++++++++++ > .../BoardBootManagerLibNull.inf | 31 +++++++++++++++ > .../Include/Library/BoardBootManagerLib.h | 39 > +++++++++++++++++++ > 3 files changed, 108 insertions(+) > create mode 100644 > Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/Boar > dBootManagerLib.c > create mode 100644 > Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/Boar > dBootManagerLibNull.inf > create mode 100644 > Platform/Intel/MinPlatformPkg/Include/Library/BoardBootManagerLib.h >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/Bo > ardBootManagerLib.c > b/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/Bo > ardBootManagerLib.c > new file mode 100644 > index 0000000000..46fce8f59f > --- /dev/null > +++ > b/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/ > +++ BoardBootManagerLib.c > @@ -0,0 +1,38 @@ > +/** @file > + This file include board specific boot manager callbacks > + > + Copyright (c) 2018, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +#include > + > +/** > + This function is called each second during the boot manager waits > timeout. > + > + @param TimeoutRemain The remaining timeout. > +**/ > +VOID > +EFIAPI > +BoardBootManagerWaitCallback ( > + IN UINT16 TimeoutRemain > + ) > +{ > + return; > +} > + > +/** > + The function is called when no boot option could be launched, > + including platform recovery options and options pointing to > +applications > + built into firmware volumes. > + > +**/ > +VOID > +EFIAPI > +BoardBootManagerUnableToBoot ( > + VOID > + ) > +{ > + return; > +} > + > diff --git > a/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/Bo > ardBootManagerLibNull.inf > b/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/Bo > ardBootManagerLibNull.inf > new file mode 100644 > index 0000000000..084207b111 > --- /dev/null > +++ > b/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/ > +++ BoardBootManagerLibNull.inf > @@ -0,0 +1,31 @@ > +## @file > +# The module definition file for BoardBootManagerLib. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# > +SPDX-License-Identifier: BSD-2-Clause-Patent # ## > + > +[Defines] > + INF_VERSION =3D 0x00010005 > + BASE_NAME =3D BoardBootManagerLib > + FILE_GUID =3D > 7BA684A4-5B32-4F0C-B0FF-581F143E606C > + MODULE_TYPE =3D DXE_DRIVER > + VERSION_STRING =3D 1.0 > + LIBRARY_CLASS =3D > BoardBootManagerLib|DXE_DRIVER > + > + > +# > +# The following information is for reference only and not required by th= e > build tools. > +# > +# VALID_ARCHITECTURES =3D IA32 X64 EBC > +# > + > +[Sources] > + BoardBootManagerLib.c > + > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + MinPlatformPkg/MinPlatformPkg.dec > diff --git > a/Platform/Intel/MinPlatformPkg/Include/Library/BoardBootManagerLib.h > b/Platform/Intel/MinPlatformPkg/Include/Library/BoardBootManagerLib.h > new file mode 100644 > index 0000000000..4240142073 > --- /dev/null > +++ > b/Platform/Intel/MinPlatformPkg/Include/Library/BoardBootManagerLib. > +++ h > @@ -0,0 +1,39 @@ > +/** @file > + Board Boot Manager library definition. A platform can implement > + instances to support platform-specific behavior. > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > + > +#ifndef __BOARD_BOOT_MANAGER_LIB_H_ > +#define __BOARD_BOOT_MANAGER_LIB_H_ > +#include > + > + > +/** > + This function is called each second during boot manager waits the > timeout. > + > + @param TimeoutRemain The remaining timeout. > +**/ > +VOID > +EFIAPI > +BoardBootManagerWaitCallback ( > + IN UINT16 TimeoutRemain > + ); > + > +/** > + The function is called when no boot option could be launched, > + including platform recovery options and options pointing to > +applications > + built into firmware volumes. > + > +**/ > +VOID > +EFIAPI > +BoardBootManagerUnableToBoot ( > + VOID > + ); > + > +#endif > -- > 2.19.1.windows.1