From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.5520.1576634389876285057 for ; Tue, 17 Dec 2019 17:59:50 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 17:59:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,327,1571727600"; d="scan'208";a="298240147" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by orsmga001.jf.intel.com with ESMTP; 17 Dec 2019 17:59:48 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.106]) by KMSMSX151.gar.corp.intel.com ([169.254.10.100]) with mapi id 14.03.0439.000; Wed, 18 Dec 2019 09:59:47 +0800 From: "Chiu, Chasel" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [edk2-platforms][PATCH V3 1/1] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Topic: [edk2-platforms][PATCH V3 1/1] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Index: AQHVtSyq+RJntlsQ4kuYDKWfOGXYD6e/Iy4g Date: Wed, 18 Dec 2019 01:59:46 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505D3262@PGSMSX111.gar.corp.intel.com> References: <20191217225134.40000-1-michael.a.kubacki@intel.com> In-Reply-To: <20191217225134.40000-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjQxOGI4YTQtZDgwZS00ZmVjLTkyYzctYTc5NGM5NzAzMzdlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiclJuQ1dTdDZsSlVIMTFvQXhGcklhQTVhSXRkbWgxRmROejJudVM5eVVlNkxKektxeVRHSkd1ZGRTTWpsTkV4bSJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kubacki, Michael A > Sent: Wednesday, December 18, 2019 6:52 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH V3 1/1] WhiskeylakeOpenBoardPkg: Update > PCDs to enable stack sharing >=20 > From: "Agyeman, Prince" >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2409 >=20 > Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing. >=20 > This fixes the boot failure seen with the latest Coffee Lake (CFL) FSP bi= nary (v > 7.0.68.41). >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Michael Kubacki > Co-authored-by: Michael Kubacki > Signed-off-by: Prince Agyeman > Reviewed-by: Chasel Chiu > --- >=20 > Notes: > 1. Michael Kubacki is taking over patch ownership since Prince > is out of office. >=20 > V3 Change: > - Changed the value of PcdPeiTemporaryRamStackSize to 0x30000 > to exceed the minimum stack size specified in the Coffee Lake > FSP Integration Guide (160KB / 0x28000) with some padding. >=20 > V2 Change: > - The value of PcdPeiTemporaryRamStackSize was changed from > 0x40000 > to 0x28000 to exactly meet the minimum stack size specified in > the Coffee Lake FSP Integration Guide. Note that the memory > initialization code in the FSP previously exceeded the available > stack size. >=20 >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg > Pcd.dsc | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kgPcd.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kgPcd.dsc > index 906f7b7ade..1ae51d9d5e 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kgPcd.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > k > +++ gPcd.dsc > @@ -54,15 +54,14 @@ > gSiPkgTokenSpaceGuid.PcdTsegSize|0x1000000 >=20 > # > - # FSP API mode does not share stack with the boot loader, > - # so FSP needs more temporary memory for FSP heap + stack size. > + # When sharing stack with boot loader, FSP only needs small temp ram > + for heap > # > - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x26000 > + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x10000 > + > # > - # FSP API mode does not need to enlarge the boot loader stack size > - # since the stacks are separate. > + # Boot loader stack size has to be big enough to executing FSP > # > - gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 > + gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x30000 >=20 > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 >=20 > gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000 > -- > 2.16.2.windows.1