From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.7318.1576744106350918009 for ; Thu, 19 Dec 2019 00:28:26 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2019 00:28:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,330,1571727600"; d="scan'208";a="241076890" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by fmsmga004.fm.intel.com with ESMTP; 19 Dec 2019 00:28:24 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.106]) by PGSMSX101.gar.corp.intel.com ([169.254.1.61]) with mapi id 14.03.0439.000; Thu, 19 Dec 2019 16:28:23 +0800 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Chaganty, Rangasai V" , "Dong, Eric" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Features/Intel/AcpiDebugFeaturePkg: Add feature active PCD Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Features/Intel/AcpiDebugFeaturePkg: Add feature active PCD Thread-Index: AQHVtkIUTUB+53K1JkyK30J9SEu5Q6fBH/NQ Date: Thu, 19 Dec 2019 08:28:23 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC505D5885@PGSMSX111.gar.corp.intel.com> References: <20191219075748.31380-1-michael.a.kubacki@intel.com> In-Reply-To: <20191219075748.31380-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjgwOGNkNzItNzI1YS00ZTdmLTgyZjUtMjFhZjhiYjNjYzk0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYUF2NUhXM1wvQnNjZXpueVhDT0dSdkJFYkFZaklSMlA2aVVEYUhxaU1FRTYzZHo3TUdKNkp5OEc2NEM0THJEOHkifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Thursday, December 19, 2019 3:58 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Dong, Eric ; Gao, Liming > > Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1] > Features/Intel/AcpiDebugFeaturePkg: Add feature active PCD >=20 > Adds a dynamic PCD that specifies whether the feature is active. >=20 > This is useful because the feature might be enabled via FeatureFlag PCD > PcdAcpiDebugFeatureEnable meaning it is built and included in the flash > image but the board might need to control whether the feature is active > based on input such as a Setup menu option. >=20 > A deactivated feature will be dispatched but simply exit in the entry po= int. >=20 > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Eric Dong > Cc: Liming Gao > Signed-off-by: Michael Kubacki > --- > Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec > | 14 +++++++++++++- >=20 > Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDe > bugDxe.inf | 5 +++-- > Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDe > bugSmm.inf | 5 +++-- >=20 > Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDe > bug.c | 4 ++++ > Features/Intel/Debugging/AcpiDebugFeaturePkg/Readme.md > | 1 + > 5 files changed, 24 insertions(+), 5 deletions(-) >=20 > diff --git > a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec > b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec > index a74ee3e084..c3bd89fe2b 100644 > --- > a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec > +++ > b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.d > +++ ec > @@ -34,6 +34,18 @@ >=20 > gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugBufferSize|0x10000|UI > NT32|0xF0000001 >=20 > [PcdsDynamic, PcdsDynamicEx] > + ## This PCD specifies whether the feature is active. > + # > + # The PCD value can be modified at boot time to activate and > deactivate the feature functionality. > + # > + # Note that this differs from PcdFeatureEnable which > + determines whether the feature is included # as an advanced feature > + in the flash image. If enabled, the feature is then eligible to be > activated/deactivated # via this PCD. > + # > + # An enabled but deactivated feature will be dispatched but exit in > + its entry point without performing any # feature actions. > + > + > gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureActive|TRUE|B > OOL > + EAN|0xD0000001 > + > ## This PCD specifies ACPI debug message buffer address. > # The PCD value will be updated during boot time when the buffer is > allocated. > - > gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugAddress|0|UINT32|0x > D0000001 > + > + > gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugAddress|0|UINT32|0x > D000 > + 0002 > diff --git > a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD > ebugDxe.inf > b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD > ebugDxe.inf > index dfcee0a842..b293d83cd9 100644 > --- > a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD > ebugDxe.inf > +++ > b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD > +++ ebugDxe.inf > @@ -35,8 +35,9 @@ > Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec >=20 > [Pcd] > - gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugBufferSize ## > CONSUMES > - gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugAddress ## > PRODUCES > + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureActive ## > CONSUMES > + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugBufferSize ## > CONSUMES > + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugAddress > ## PRODUCES >=20 > [Sources] > AcpiDebug.c > diff --git > a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD > ebugSmm.inf > b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD > ebugSmm.inf > index 089bb57707..dbb33e4ae2 100644 > --- > a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD > ebugSmm.inf > +++ > b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD > +++ ebugSmm.inf > @@ -36,8 +36,9 @@ > Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec >=20 > [Pcd] > - gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugBufferSize ## > CONSUMES > - gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugAddress ## > PRODUCES > + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureActive ## > CONSUMES > + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugBufferSize ## > CONSUMES > + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugAddress > ## PRODUCES >=20 > [Sources] > AcpiDebug.c > diff --git > a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD > ebug.c > b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD > ebug.c > index 42428d8005..4caeffc7de 100644 > --- > a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD > ebug.c > +++ > b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiD > +++ ebug.c > @@ -289,6 +289,10 @@ InitializeAcpiDebugDxe ( > EFI_STATUS Status; > EFI_EVENT EndOfDxeEvent; >=20 > + if (!PcdGetBool (PcdAcpiDebugFeatureActive)) { > + return EFI_SUCCESS; > + } > + > // > // Register EndOfDxe notification > // that point could ensure the Acpi Debug related PCDs initialized. > diff --git a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Readme.md > b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Readme.md > index bc0dce9348..bbd7675c11 100644 > --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Readme.md > +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Readme.md > @@ -78,6 +78,7 @@ instance assigned to `AcpiDebugSmm`. >=20 > ## Configuration > * PcdAcpiDebugEnable - Enables this feature. > +* PcdAcpiDebugFeatureActive - Activates this feature. > * PcdAcpiDebugAddress - The address of the ACPI debug message buffer. > * PcdAcpiDebugBufferSize - The size of the ACPI debug message buffer. >=20 > -- > 2.16.2.windows.1 >=20 >=20 >=20