From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.6805.1579497600356407960 for ; Sun, 19 Jan 2020 21:20:00 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2020 21:20:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,340,1574150400"; d="scan'208";a="220583545" Received: from pgsmsx113.gar.corp.intel.com ([10.108.55.202]) by fmsmga007.fm.intel.com with ESMTP; 19 Jan 2020 21:19:59 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.4]) by pgsmsx113.gar.corp.intel.com ([169.254.6.65]) with mapi id 14.03.0439.000; Mon, 20 Jan 2020 13:19:58 +0800 From: "Chiu, Chasel" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Zhang, Shenglei" , "Desimone, Nathaniel L" , "Kubacki, Michael A" Subject: Re: [edk2-platforms] [PATCH] BoardModulePkg: Fix ECC Coding Style Issues Thread-Topic: [edk2-platforms] [PATCH] BoardModulePkg: Fix ECC Coding Style Issues Thread-Index: AQHVyv/0+dF8MswWzkCdD96XjKy0ZafzDEdw Date: Mon, 20 Jan 2020 05:19:57 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC50670C27@PGSMSX111.gar.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWJiOGNhNDItZjBmNy00YzM0LTg3YmItMTNhZjAwYTk3YTBhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTEtZc0F3Nkw2akFqZDBhcDEwSGlGcVhZVkhOQlZKMEFKV3lycjc4R1VPbVBtYUQzZUQ0WExsbFQzbjBDZjlyWSJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Agyeman, Prince > Sent: Wednesday, January 15, 2020 1:28 AM > To: devel@edk2.groups.io > Cc: Zhang, Shenglei ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH] BoardModulePkg: Fix ECC Coding Style > Issues >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2453 >=20 > Fixed coding style issues as reported by the ECC tool >=20 > Cc: Shenglei Zhang > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Michael Kubacki >=20 > Signed-off-by: Prince Agyeman > --- > .../BoardModulePkg/LegacySioDxe/ComponentName.h | 5 +++++ > .../BoardModulePkg/LegacySioDxe/LegacySioDxe.inf | 2 ++ > .../Intel/BoardModulePkg/LegacySioDxe/SioChip.c | 5 +++-- > .../Intel/BoardModulePkg/LegacySioDxe/SioDriver.c | 15 ++++++++------- > .../Library/BdsPs2KbcLib/BdsPs2KbcLib.c | 6 +++--- > .../Library/BdsPs2KbcLib/BdsPs2KbcLib.h | 4 ++-- > 6 files changed, 23 insertions(+), 14 deletions(-) >=20 > diff --git a/Platform/Intel/BoardModulePkg/LegacySioDxe/ComponentName.h > b/Platform/Intel/BoardModulePkg/LegacySioDxe/ComponentName.h > index 85ca348701..91bc245f3a 100644 > --- a/Platform/Intel/BoardModulePkg/LegacySioDxe/ComponentName.h > +++ b/Platform/Intel/BoardModulePkg/LegacySioDxe/ComponentName.h > @@ -6,6 +6,9 @@ > SPDX-License-Identifier: BSD-2-Clause-Patent **/ >=20 > +#ifndef _LEGACY_SIO_DXE_COMPONENT_NAME_H_ #define > +_LEGACY_SIO_DXE_COMPONENT_NAME_H_ > + > /** > Retrieves a Unicode string that is the user-readable name of the EFI > Driver. >=20 > @@ -85,3 +88,5 @@ SioComponentNameGetControllerName ( > IN CHAR8 *Language, > OUT CHAR16 **ControllerName > ); > + > +#endif > diff --git a/Platform/Intel/BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > b/Platform/Intel/BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > index 1d7cd92604..698d406450 100644 > --- a/Platform/Intel/BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > +++ b/Platform/Intel/BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > @@ -44,6 +44,8 @@ > SioDriver.c > SioDriver.h > ComponentName.c > + ComponentName.h > + Register.h >=20 > [Pcd] > gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable > diff --git a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.c > b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.c > index b9a84ca51c..846dddf739 100644 > --- a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.c > +++ b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.c > @@ -145,7 +145,7 @@ DEVICE_INFO mDeviceInfo[] =3D { >=20 >=20 > /** > - Gets the number of devices in Table of SIO Controllers mDeviceInfo > + Gets the number of devices in Table of SIO Controllers mDeviceInfo. >=20 > @retval Number of enabled devices in Table of SIO Controllers. > **/ > @@ -153,7 +153,8 @@ UINTN > EFIAPI > GetDeviceCount ( > VOID > -){ > + ) > +{ > UINTN Count; > // Get mDeviceInfo item count > // -1 to account for for the end device info diff --git > a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioDriver.c > b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioDriver.c > index 5bfdc94681..484c53e953 100644 > --- a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioDriver.c > +++ b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioDriver.c > @@ -118,13 +118,14 @@ BOOLEAN > EFIAPI > SioDeviceEnabled ( > IN SIO_PCI_ISA_BRIDGE_DEVICE_INFO *CurrentDevice -){ > - SIO_PCI_ISA_BRIDGE_DEVICE_INFO *Device =3D \ > - (SIO_PCI_ISA_BRIDGE_DEVICE_INFO *) FixedPcdGetPtr > (PcdSuperIoPciIsaBridgeDevice); > - if(CompareMem (Device, CurrentDevice, sizeof > (SIO_PCI_ISA_BRIDGE_DEVICE_INFO)) =3D=3D 0) { > - return TRUE; > - } > - return FALSE; > + ) > +{ > + SIO_PCI_ISA_BRIDGE_DEVICE_INFO *Device; > + Device =3D (SIO_PCI_ISA_BRIDGE_DEVICE_INFO *) FixedPcdGetPtr > +(PcdSuperIoPciIsaBridgeDevice); > + if(CompareMem (Device, CurrentDevice, sizeof > (SIO_PCI_ISA_BRIDGE_DEVICE_INFO)) =3D=3D 0) { > + return TRUE; > + } > + return FALSE; > } >=20 > /** > diff --git > a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c > b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c > index eff10bddb4..0cf4c4d262 100644 > --- a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c > +++ b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c > @@ -65,7 +65,7 @@ DetectPs2Keyboard ( > MicroSecondDelay (30); > } >=20 > - if (FoundPs2Kbc =3D=3D FALSE) { > + if (!FoundPs2Kbc) { > return FALSE; > } >=20 > @@ -126,7 +126,7 @@ IsPs2KeyboardConnected ( > BOOLEAN Result; > Result =3D DetectPs2Keyboard (); >=20 > - if (Result =3D=3D FALSE) { > + if (!Result) { > // > // If there is no ps2 keyboard detected for the 1st time, retry agai= n. > // > @@ -138,7 +138,7 @@ IsPs2KeyboardConnected ( >=20 > /** > Updates the ConIn variable with Ps2 Keyboard device path, > - if it doesn't already exists in ConIn and ConInDev > + if it doesn't already exists in ConIn and ConInDev. > **/ > VOID > AddPs2Keyboard ( > diff --git > a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.h > b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.h > index d9a27e6681..a96d53b98d 100644 > --- a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.h > +++ b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.h > @@ -6,8 +6,8 @@ >=20 > **/ >=20 > -#ifndef _PS2_KBC_LIB_H > -#define _PS2_KBC_LIB_H > +#ifndef _PS2_KBC_LIB_H_ > +#define _PS2_KBC_LIB_H_ >=20 > #include > #include > -- > 2.19.1.windows.1