Re: [edk2-platforms] [PATCH V2 2/2] Enable build for CometlakeOpenBoardPkg

["Chiu, Chasel" <chasel.chiu@intel.com>]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>
> Sent: Wednesday, February 19, 2020 7:56 PM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>
> Subject: [edk2-platforms] [PATCH V2 2/2] Enable build for
> CometlakeOpenBoardPkg
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2280
> 
> This change adds the configuration to enable build for CometlakeURvp.
> Also it updates Cometlake U Rvp details to the Readme.md.
> 
> Signed-off-by: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> ---
>  Platform/Intel/Readme.md | 25 ++++++++++++++++++-------
> Platform/Intel/build.cfg |  3 ++-
>  2 files changed, 20 insertions(+), 8 deletions(-)
> 
> diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index
> 02d9517d19..2e66b4ce72 100644
> --- a/Platform/Intel/Readme.md
> +++ b/Platform/Intel/Readme.md
> @@ -19,7 +19,7 @@ package.
>  ## Board Naming Convention
>  The board packages supported by Intel follow the naming convention
> \<xxx\>OpenBoardPkg where xxx refers to the  encompassing platform
> name for a particular platform generation. For example, the
> [`KabylakeOpenBoardPkg`](https://github.com/tianocore/edk2-platforms/tree
> /master/Platform/Intel/KabylakeOpenBoardPkg) contains the -board code for
> Intel Kaby Lake reference systems. Intel uses the moniker "OpenBoardPkg" to
> indicate that this package
> +board code for Intel KabyLake reference systems. Intel uses the moniker
> +"OpenBoardPkg" to indicate that this package
>  is the open source board code. A closed source counterpart may exist which
> simply uses "BoardPkg". Both directly use  the MinPlatformPkg from
> edk2-platforms.
> 
> @@ -53,9 +53,10 @@ A UEFI firmware implementation using MinPlatformPkg
> is constructed using the fol
> 
> 
>  ## Board Support
> -* The `KabylakeOpenBoardPkg` contains board implementations for Kaby
> Lake systems.
> +* The `KabylakeOpenBoardPkg` contains board implementations for
> KabyLake systems.
>  * The `SimicsOpenBoardPkg` contains board implementations for the Simics
> hardware simulator.
> -* The `WhiskeylakeOpenBoardPkg` contains board implementations for
> Whiskey Lake systems.
> +* The `WhiskeylakeOpenBoardPkg` contains board implementations for
> WhiskeyLake systems.
> +* The `CometlakeOpenBoardPkg` contains board implementations for
> CometLake systems.
> 
>  ### **Supported Hardware**
> 
> @@ -65,8 +66,9 @@ A UEFI firmware implementation using MinPlatformPkg
> is constructed using the fol
> 
>  | Machine Name                          | Supported Chipsets
> | BoardPkg                     | Board Name         |
> 
> ----------------------------------------|--------------------------------------------|-------------
> -----------------|--------------------|
> -| RVP 3                                 | Sky Lake, Kaby Lake, Kaby
> Lake Refresh     | KabylakeOpenBoardPkg         | KabylakeRvp3
> |
> -| WHL-U DDR4 RVP                        | Whiskey Lake
> | WhiskeylakeOpenBoardPkg      | WhiskeylakeURvp    |
> +| RVP 3                                 | SkyLake, KabyLake,
> KabyLake Refresh        | KabylakeOpenBoardPkg         |
> KabylakeRvp3       |
> +| WHL-U DDR4 RVP                        | WhiskeyLake
> | WhiskeylakeOpenBoardPkg      | WhiskeylakeURvp    |
> +| CML-U LPDDR3 RVP                      | CometLake V1
> | CometlakeOpenBoardPkg        | CometlakeURvp      |
> 
>  *Note: RVP = Reference and Validation Platform*
> 
> @@ -82,8 +84,8 @@ A UEFI firmware implementation using MinPlatformPkg
> is constructed using the fol
> 
>  | Machine Name                          | Supported Chipsets
> | BoardPkg                     | Board Name         |
> 
> ----------------------------------------|--------------------------------------------|-------------
> -----------------|--------------------|
> -| galp2                                 | Kaby Lake
> | KabylakeOpenBoardPkg         | GalagoPro3         |
> -| galp3 & galp3-b                       | Kaby Lake Refresh
> | KabylakeOpenBoardPkg         | GalagoPro3         |
> +| galp2                                 | KabyLake
> | KabylakeOpenBoardPkg         | GalagoPro3         |
> +| galp3 & galp3-b                       | KabyLake Refresh
> | KabylakeOpenBoardPkg         | GalagoPro3         |
> 
>  ## Board Package Organization
>  The board package follows the standard EDK II package structure with the
> following additional elements and guidelines:
> @@ -237,6 +239,11 @@ return back to the minimum platform caller.
>            |       |        |               |---build_config.cfg:
> WhiskeylakeURvp specific build
>            |       |        |
> settings environment variables.
>            |       |        |
> +          |       |        |------CometlakeOpenBoardPkg
> +          |       |        |       |------CometlakeURvp
> +          |       |        |               |---build_config.cfg:
> CometlakeURvp specific build
> +          |       |        |
> settings environment variables.
> +          |       |        |
>            |------FSP
>    </pre>
> 
> @@ -257,6 +264,10 @@ return back to the minimum platform caller.
>  1. This firmware project has only been tested booting to Microsoft Windows
> 10 x64 with AHCI mode and Integrated Graphic
>     Device.
> 
> +**CometlakeOpenBoardPkg**
> +1. This firmware project has been tested booting to Microsoft Windows 10
> x64 with AHCI mode and External Graphic Device.
> +2. This firmware project has been also tested booting to Ubuntu 17.10 with
> AHCI mode and Integrated Graphic Device.
> +
>  ### **Package Builds**
> 
>  In some cases, such as BoardModulePkg, a package may provide a set of
> functionality that is included in other diff --git a/Platform/Intel/build.cfg
> b/Platform/Intel/build.cfg index 86a9115021..5bc1dea43c 100644
> --- a/Platform/Intel/build.cfg
> +++ b/Platform/Intel/build.cfg
> @@ -1,7 +1,7 @@
>  # @ build.cfg
>  # This is the main/default build configuration file  # -# Copyright (c) 2019,
> Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.<BR>
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  #
> 
> @@ -58,3 +58,4 @@ BoardX58Ich10 =
> SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
>  GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
>  KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
>  WhiskeylakeURvp =
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
> +CometlakeURvp =
> CometlakeOpenBoardPkg/CometlakeURvp/build_config.cfg
> --
> 2.16.2.windows.1