From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.2881.1582188118229721460 for ; Thu, 20 Feb 2020 00:41:58 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2020 00:41:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,463,1574150400"; d="scan'208";a="259203730" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by fmsmga004.fm.intel.com with ESMTP; 20 Feb 2020 00:41:56 -0800 Received: from pgsmsx109.gar.corp.intel.com (10.221.44.109) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Feb 2020 16:40:01 +0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.103]) by PGSMSX109.gar.corp.intel.com ([169.254.14.178]) with mapi id 14.03.0439.000; Thu, 20 Feb 2020 16:40:01 +0800 From: "Chiu, Chasel" To: "Esakkithevar, Kathappan" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Kethi Reddy, Deepika" , "Agyeman, Prince" Subject: Re: [edk2-platforms] [PATCH V2 2/2] Enable build for CometlakeOpenBoardPkg Thread-Topic: [edk2-platforms] [PATCH V2 2/2] Enable build for CometlakeOpenBoardPkg Thread-Index: AQHV5xuixzB27yxBfEiAhA/v/ZyKzKgjxE8A Date: Thu, 20 Feb 2020 08:40:00 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC506A61FE@PGSMSX111.gar.corp.intel.com> References: <20200219115626.13020-1-kathappan.esakkithevar@intel.com> In-Reply-To: <20200219115626.13020-1-kathappan.esakkithevar@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjViODllZTUtNmRhMC00MTgxLWJkZjItN2I1NGE4ZWExYjVmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoienN2bmlYbnRPQ3loNDhkZGdOTlwvNDE1b3pGMDdrS01jQTdKY1diY1ltSkt5bFpzVE16ZEZDdklETzdxSFY1WTEifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Return-Path: chasel.chiu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Esakkithevar, Kathappan > Sent: Wednesday, February 19, 2020 7:56 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Kethi Reddy, Deepika > ; Agyeman, Prince > > Subject: [edk2-platforms] [PATCH V2 2/2] Enable build for > CometlakeOpenBoardPkg >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2280 >=20 > This change adds the configuration to enable build for CometlakeURvp. > Also it updates Cometlake U Rvp details to the Readme.md. >=20 > Signed-off-by: Kathappan Esakkithevar > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Deepika Kethi Reddy > Cc: Prince Agyeman > --- > Platform/Intel/Readme.md | 25 ++++++++++++++++++------- > Platform/Intel/build.cfg | 3 ++- > 2 files changed, 20 insertions(+), 8 deletions(-) >=20 > diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index > 02d9517d19..2e66b4ce72 100644 > --- a/Platform/Intel/Readme.md > +++ b/Platform/Intel/Readme.md > @@ -19,7 +19,7 @@ package. > ## Board Naming Convention > The board packages supported by Intel follow the naming convention > \OpenBoardPkg where xxx refers to the encompassing platform > name for a particular platform generation. For example, the > [`KabylakeOpenBoardPkg`](https://github.com/tianocore/edk2-platforms/tree > /master/Platform/Intel/KabylakeOpenBoardPkg) contains the -board code for > Intel Kaby Lake reference systems. Intel uses the moniker "OpenBoardPkg" = to > indicate that this package > +board code for Intel KabyLake reference systems. Intel uses the moniker > +"OpenBoardPkg" to indicate that this package > is the open source board code. A closed source counterpart may exist whi= ch > simply uses "BoardPkg". Both directly use the MinPlatformPkg from > edk2-platforms. >=20 > @@ -53,9 +53,10 @@ A UEFI firmware implementation using MinPlatformPkg > is constructed using the fol >=20 >=20 > ## Board Support > -* The `KabylakeOpenBoardPkg` contains board implementations for Kaby > Lake systems. > +* The `KabylakeOpenBoardPkg` contains board implementations for > KabyLake systems. > * The `SimicsOpenBoardPkg` contains board implementations for the Simics > hardware simulator. > -* The `WhiskeylakeOpenBoardPkg` contains board implementations for > Whiskey Lake systems. > +* The `WhiskeylakeOpenBoardPkg` contains board implementations for > WhiskeyLake systems. > +* The `CometlakeOpenBoardPkg` contains board implementations for > CometLake systems. >=20 > ### **Supported Hardware** >=20 > @@ -65,8 +66,9 @@ A UEFI firmware implementation using MinPlatformPkg > is constructed using the fol >=20 > | Machine Name | Supported Chipsets > | BoardPkg | Board Name | >=20 > ----------------------------------------|--------------------------------= ------------|------------- > -----------------|--------------------| > -| RVP 3 | Sky Lake, Kaby Lake, Kaby > Lake Refresh | KabylakeOpenBoardPkg | KabylakeRvp3 > | > -| WHL-U DDR4 RVP | Whiskey Lake > | WhiskeylakeOpenBoardPkg | WhiskeylakeURvp | > +| RVP 3 | SkyLake, KabyLake, > KabyLake Refresh | KabylakeOpenBoardPkg | > KabylakeRvp3 | > +| WHL-U DDR4 RVP | WhiskeyLake > | WhiskeylakeOpenBoardPkg | WhiskeylakeURvp | > +| CML-U LPDDR3 RVP | CometLake V1 > | CometlakeOpenBoardPkg | CometlakeURvp | >=20 > *Note: RVP =3D Reference and Validation Platform* >=20 > @@ -82,8 +84,8 @@ A UEFI firmware implementation using MinPlatformPkg > is constructed using the fol >=20 > | Machine Name | Supported Chipsets > | BoardPkg | Board Name | >=20 > ----------------------------------------|--------------------------------= ------------|------------- > -----------------|--------------------| > -| galp2 | Kaby Lake > | KabylakeOpenBoardPkg | GalagoPro3 | > -| galp3 & galp3-b | Kaby Lake Refresh > | KabylakeOpenBoardPkg | GalagoPro3 | > +| galp2 | KabyLake > | KabylakeOpenBoardPkg | GalagoPro3 | > +| galp3 & galp3-b | KabyLake Refresh > | KabylakeOpenBoardPkg | GalagoPro3 | >=20 > ## Board Package Organization > The board package follows the standard EDK II package structure with the > following additional elements and guidelines: > @@ -237,6 +239,11 @@ return back to the minimum platform caller. > | | | |---build_config.cfg: > WhiskeylakeURvp specific build > | | | > settings environment variables. > | | | > + | | |------CometlakeOpenBoardPkg > + | | | |------CometlakeURvp > + | | | |---build_config.cfg: > CometlakeURvp specific build > + | | | > settings environment variables. > + | | | > |------FSP > >=20 > @@ -257,6 +264,10 @@ return back to the minimum platform caller. > 1. This firmware project has only been tested booting to Microsoft Windo= ws > 10 x64 with AHCI mode and Integrated Graphic > Device. >=20 > +**CometlakeOpenBoardPkg** > +1. This firmware project has been tested booting to Microsoft Windows 10 > x64 with AHCI mode and External Graphic Device. > +2. This firmware project has been also tested booting to Ubuntu 17.10 wi= th > AHCI mode and Integrated Graphic Device. > + > ### **Package Builds** >=20 > In some cases, such as BoardModulePkg, a package may provide a set of > functionality that is included in other diff --git a/Platform/Intel/build= .cfg > b/Platform/Intel/build.cfg index 86a9115021..5bc1dea43c 100644 > --- a/Platform/Intel/build.cfg > +++ b/Platform/Intel/build.cfg > @@ -1,7 +1,7 @@ > # @ build.cfg > # This is the main/default build configuration file # -# Copyright (c) = 2019, > Intel Corporation. All rights reserved.
> +# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent # >=20 > @@ -58,3 +58,4 @@ BoardX58Ich10 =3D > SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg > GalagoPro3 =3D KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg > KabylakeRvp3 =3D KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > WhiskeylakeURvp =3D > WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg > +CometlakeURvp =3D > CometlakeOpenBoardPkg/CometlakeURvp/build_config.cfg > -- > 2.16.2.windows.1