From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.370.1582613493819694515 for ; Mon, 24 Feb 2020 22:51:33 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2020 22:51:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,483,1574150400"; d="scan'208";a="231366915" Received: from kmsmsx156.gar.corp.intel.com ([172.21.138.133]) by fmsmga008.fm.intel.com with ESMTP; 24 Feb 2020 22:51:32 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.103]) by KMSMSX156.gar.corp.intel.com ([169.254.1.75]) with mapi id 14.03.0439.000; Tue, 25 Feb 2020 14:45:44 +0800 From: "Chiu, Chasel" To: "Shindo, Miki" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Agyeman, Prince" Subject: Re: [edk2-platforms: PATCH] MinPlatformPkg/PeiReportFvLib: Install FvFspT in PeiReportFvLib Thread-Topic: [edk2-platforms: PATCH] MinPlatformPkg/PeiReportFvLib: Install FvFspT in PeiReportFvLib Thread-Index: AQHV6SDW8R6D2uY5e06phZ2sRrxTqqgrfACw Date: Tue, 25 Feb 2020 06:45:43 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC506AA9C2@PGSMSX111.gar.corp.intel.com> References: <20200222013731.16204-1-miki.shindo@intel.com> In-Reply-To: <20200222013731.16204-1-miki.shindo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGQ3YjE0NWQtY2ViMi00N2Y5LWFmNzQtN2U1Y2M0ZTZhYWYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUXE0a3JIUjk3blFtV2N0dVBXXC9sd2tMd2tPdnlXYzFseTdoamh4NXMzQ3ozU25jNTFuUnVxQWRHZ1lFdW1aVm8ifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Shindo, Miki > Sent: Saturday, February 22, 2020 9:38 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Agyeman, Prince > > Subject: [edk2-platforms: PATCH] MinPlatformPkg/PeiReportFvLib: Install > FvFspT in PeiReportFvLib >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2410 >=20 > TPM measurements in PEI runs on FV_INFO_PPI notification function. > Currently FvFspT is not installed so it is not measured by TPM. > This commit makes FvFspT installed by FV_INFO_PPI so the measurement > would run for FvFspT. FvFspT code actually runs, it has to be measured. >=20 > Signed-off-by: Miki Shindo > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Prince Agyeman > --- > .../Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFv= Lib > .c | 13 ++++++++++++- > .../Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFv= Lib > .inf | 4 +++- > 2 files changed, 15 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRe= p > ortFvLib.c > b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRe= p > ortFvLib.c > index 0d805d6fe7..6158fc9412 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRe= p > ortFvLib.c > +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/ > +++ PeiReportFvLib.c > @@ -1,7 +1,7 @@ > /** @file > Source code file for Report Firmware Volume (FV) library >=20 > -Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2018 - 2020, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -31,6 +31,17 @@ ReportPreMemFv ( > 0 > ); > } > + if (PcdGetBool(PcdFspWrapperBootMode)) { > + DEBUG ((DEBUG_INFO, "Install FlashFvFspT - 0x%x, 0x%x\n", PcdGet32 > (PcdFlashFvFspTBase), PcdGet32 (PcdFlashFvFspTSize))); > + PeiServicesInstallFvInfo2Ppi ( > + &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 > (PcdFlashFvFspTBase))->FileSystemGuid), > + (VOID *) (UINTN) PcdGet32 (PcdFlashFvFspTBase), > + PcdGet32 (PcdFlashFvFspTSize), > + NULL, > + NULL, > + 0 > + ); > + } > DEBUG ((DEBUG_INFO, "Install FlashFvSecurity - 0x%x, 0x%x\n", PcdGet32 > (PcdFlashFvSecurityBase), PcdGet32 (PcdFlashFvSecuritySize))); > PeiServicesInstallFvInfo2Ppi ( > &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 > (PcdFlashFvSecurityBase))->FileSystemGuid), > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRe= p > ortFvLib.inf > b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRe= p > ortFvLib.inf > index ef03e110bd..79cd5ee1f7 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRe= p > ortFvLib.inf > +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/ > +++ PeiReportFvLib.inf > @@ -1,7 +1,7 @@ > ### @file > # Component information file for the Report Firmware Volume (FV) library= . > # > -# Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2018 - 2020, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -36,6 +36,8 @@ > gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMBase > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTBase > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSBase > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspUBase > ## CONSUMES > -- > 2.16.2.windows.1