From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.7230.1582767666607557911 for ; Wed, 26 Feb 2020 17:41:06 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2020 17:41:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,490,1574150400"; d="scan'208";a="238233505" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by orsmga003.jf.intel.com with ESMTP; 26 Feb 2020 17:41:05 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.103]) by KMSMSX154.gar.corp.intel.com ([169.254.12.45]) with mapi id 14.03.0439.000; Thu, 27 Feb 2020 09:39:17 +0800 From: "Chiu, Chasel" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 1/2] CoffeelakeSiliconPkg: Add Missing GUID Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH 1/2] CoffeelakeSiliconPkg: Add Missing GUID Thread-Index: AQHV7D/jAjblF9XZKUWyv9gy356DRqgtMecA///ynYCAAR5xcA== Date: Thu, 27 Feb 2020 01:39:17 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC506AD9CE@PGSMSX111.gar.corp.intel.com> References: <3C3EFB470A303B4AB093197B6777CCEC506ACD89@PGSMSX111.gar.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDdjNWQ0NDUtZjM4Ni00MGQ0LWFiMTMtNjdlM2E3NDg5ZGY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOUsweXNIaUNKbG04dW5IOVwvVHdhSlB5TzVzZTJzRkZvblRpcGJXbkJyQlgyYmN1V1R1MjBxaTRmUHhualJYK1UifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Prince, This is fixing VS2017 build issues, so should be able to refer to the same= BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2408 You may update BZ to mention about additional missing GUID build failure t= hat will be addressed too. Thanks, Chasel > -----Original Message----- > From: Agyeman, Prince > Sent: Thursday, February 27, 2020 12:27 AM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Desimone, Nathaniel L > Subject: RE: [edk2-devel] [edk2-platforms] [PATCH 1/2] CoffeelakeSilicon= Pkg: > Add Missing GUID >=20 > Hi Chasel, >=20 > No specific BZ was filed for the missing GUID issue, though reported on= this > mailing list. >=20 > Thanks > Prince >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Wednesday, February 26, 2020 1:16 AM > To: Agyeman, Prince ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L > Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 1/2] CoffeelakeSilicon= Pkg: > Add Missing GUID >=20 >=20 > Please add BZ in commit message, with this update: Reviewed-by: Chasel > Chiu >=20 > > -----Original Message----- > > From: Agyeman, Prince > > Sent: Wednesday, February 26, 2020 8:59 AM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > > > Subject: [edk2-platforms] [PATCH 1/2] CoffeelakeSiliconPkg: Add > > Missing GUID > > > > Added missing GUID gEfiMemoryTypeInformationGuid to > > PeiPolicyUpdateLib.inf to fix VS2017 build issue > > > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > > > Signed-off-by: Prince Agyeman > > --- > > .../Policy/Library/PeiPolicyUpdateLib/PeiPolicyUpdateLib.inf | 1 = + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdat > > eLi > > b/PeiPolicyUpdateLib.inf > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdat > > eLi > > b/PeiPolicyUpdateLib.inf > > index e95c1b15c5..478e2d0512 100644 > > --- > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdat > > eLi > > b/PeiPolicyUpdateLib.inf > > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyU > > +++ pd > > +++ ateLib/PeiPolicyUpdateLib.inf > > @@ -271,3 +271,4 @@ > > [Guids] > > gTianoLogoGuid ## CONSUMES > > gSiConfigGuid ## CONSUMES > > + gEfiMemoryTypeInformationGuid ## CONSUMES > > -- > > 2.19.1.windows.1 >=20 >=20 >=20 >=20