public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Agyeman, Prince" <prince.agyeman@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-platforms] [PATCH v4 1/4] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove BoardFuncInit
Date: Thu, 27 Feb 2020 02:18:51 +0000	[thread overview]
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC506ADA32@PGSMSX111.gar.corp.intel.com> (raw)
In-Reply-To: <3e1e8f0cdf9ba13f62b4ab4aaa57f3ef6135b877.1582676457.git.prince.agyeman@intel.com>


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Agyeman, Prince <prince.agyeman@intel.com>
> Sent: Wednesday, February 26, 2020 8:28 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-platforms] [PATCH v4 1/4]
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove BoardFuncInit
> 
> Removes BoardFuncInit related functionality in WhiskeylakeURvp.
> 
> Co-authored-by: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
> ---
>  .../Library/BoardInitLib/BoardFunc.c          | 19 ------------
>  .../Library/BoardInitLib/BoardFunc.h          | 20 -------------
>  .../Library/BoardInitLib/BoardFuncInit.c      | 26 -----------------
>  .../BoardInitLib/BoardFuncInitPreMem.c        | 29 +++++--------------
>  .../BoardInitLib/BoardPchInitPreMemLib.c      |  3 +-
>  .../PeiMultiBoardInitPostMemLib.inf           |  4 ---
>  .../PeiWhiskeylakeURvpInitPostMemLib.c        |  8 -----
>  .../PeiWhiskeylakeURvpInitPreMemLib.c         | 10 +------
>  8 files changed, 9 insertions(+), 110 deletions(-)  delete mode 100644
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardIni
> tLib/BoardFunc.c
>  delete mode 100644
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardIni
> tLib/BoardFunc.h
>  delete mode 100644
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardIni
> tLib/BoardFuncInit.c
> 
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardFunc.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardFunc.c
> deleted file mode 100644
> index 7a2fed9904..0000000000
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardFunc.c
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -/** @file
> -  Board's PCD function hook.
> -
> -
> -  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> -  SPDX-License-Identifier: BSD-2-Clause-Patent -**/
> -
> -#include <PiPei.h>
> -
> -EFI_STATUS
> -PeiBoardSpecificInitPostMemNull (
> -  VOID
> -  )
> -{
> -  return EFI_SUCCESS;
> -}
> -
> -
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardFunc.h
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardFunc.h
> deleted file mode 100644
> index 9e0ff8d033..0000000000
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardFunc.h
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -/** @file
> -  Header file for Board Hook function intance.
> -
> -
> -  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> -  SPDX-License-Identifier: BSD-2-Clause-Patent -**/
> -
> -#ifndef _BOARD_FUNC_H_
> -#define _BOARD_FUNC_H_
> -
> -#include <Uefi.h>
> -
> -EFI_STATUS
> -PeiBoardSpecificInitPostMemNull (
> -  VOID
> -  );
> -
> -#endif // _BOARD_FUNC_H_
> -
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardFuncInit.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardFuncInit.c
> deleted file mode 100644
> index b8c69166ed..0000000000
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardFuncInit.c
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -/** @file
> -  Source code for the board configuration init function in Post Memory init
> phase.
> -
> -
> -  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> -  SPDX-License-Identifier: BSD-2-Clause-Patent -**/
> -
> -#include "BoardFunc.h"
> -
> -/**
> -  Board's PCD function hook init function for PEI post memory phase.
> -
> -  @param[in]  BoardId   An unsigned integrer represent the board id.
> -
> -  @retval EFI_SUCCESS   The function completed successfully.
> -**/
> -EFI_STATUS
> -BoardFunctionInit (
> -  IN UINT16 BoardId
> -)
> -{
> -
> -  return EFI_SUCCESS;
> -}
> -
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardFuncInitPreMem.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardFuncInitPreMem.c
> index 1944a02bf1..06ff64da8d 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardFuncInitPreMem.c
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdInitLib/BoardFuncInitPreMem.c
> @@ -2,39 +2,24 @@
>    Source code for the board configuration init function in Post Memory init
> phase.
> 
> 
> -  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2019 - 2020, Intel Corporation. All rights
> + reserved.<BR>
>    SPDX-License-Identifier: BSD-2-Clause-Patent  **/
> 
>  #include <GopConfigLib.h>
> +
>  //
>  // Null function for nothing GOP VBT update.
>  //
>  VOID
> -GopVbtSpecificUpdateNull(
> +GopVbtSpecificUpdateNull (
>    IN CHILD_STRUCT **ChildStructPtr
> -);
> +  );
> +
>  //
>  // for CFL U DDR4
>  //
>  VOID
> -CflUDdr4GopVbtSpecificUpdate(
> +CflUDdr4GopVbtSpecificUpdate (
>    IN CHILD_STRUCT **ChildStructPtr
> -);
> -/**
> -  Board's PCD function hook init function for PEI post memory phase.
> -
> -  @param[in]  BoardId   An unsigned integrer represent the board id.
> -
> -  @retval EFI_SUCCESS   The function completed successfully.
> -**/
> -EFI_STATUS
> -BoardFunctionInitPreMem (
> -  IN UINT16 BoardId
> -  )
> -{
> -
> -  return EFI_SUCCESS;
> -}
> -
> -
> +  );
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardPchInitPreMemLib.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardPchInitPreMemLib.c
> index 5305ec7f7c..1f778c4f7e 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/BoardPchInitPreMemLib.c
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdInitLib/BoardPchInitPreMemLib.c
> @@ -2,7 +2,7 @@
>   Source code for the board PCH configuration Pcd init functions for
> Pre-Memory Init phase.
> 
> 
> -  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2019 - 2020, Intel Corporation. All rights
> + reserved.<BR>
>    SPDX-License-Identifier: BSD-2-Clause-Patent  **/
> 
> @@ -310,7 +310,6 @@ GpioGroupTierInit (
>    //
>    // GPIO Group Tier
>    //
> -
>    switch (BoardId) {
>      case BoardIdWhiskeyLakeRvp:
>        PcdSet32S (PcdGpioGroupToGpeDw0, GPIO_CNL_LP_GROUP_GPP_G);
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/PeiMultiBoardInitPostMemLib.inf
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/PeiMultiBoardInitPostMemLib.inf
> index 436314a6a3..845790209f 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/PeiMultiBoardInitPostMemLib.inf
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdInitLib/PeiMultiBoardInitPostMemLib.inf
> @@ -44,13 +44,9 @@
>  [Sources]
>    PeiWhiskeylakeURvpInitPostMemLib.c
>    PeiMultiBoardInitPostMemLib.c
> -  BoardFunc.c
> -  BoardFuncInit.c
>    GpioTableDefault.c
>    GpioTableWhiskeylakeUDdr4Rvp.c
> 
> -[FixedPcd]
> -
>  [Pcd]
>    gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdBoardGpioTable
>    gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdBoardGpioTableSize
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/PeiWhiskeylakeURvpInitPostMemLib.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/PeiWhiskeylakeURvpInitPostMemLib.c
> index f704c42f2d..c61743acdc 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/PeiWhiskeylakeURvpInitPostMemLib.c
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdInitLib/PeiWhiskeylakeURvpInitPostMemLib.c
> @@ -33,11 +33,6 @@
>  #include "WhiskeylakeURvpInit.h"
>  #include <Library/ConfigBlockLib.h>
> 
> -EFI_STATUS
> -BoardFunctionInit (
> -  IN UINT16 BoardId
> -  );
> -
>  /**
>    GPIO init function for PEI post memory phase.
> 
> @@ -168,9 +163,6 @@ BoardConfigInit (
>    Status = BoardMiscInit (BoardId);
>    ASSERT_EFI_ERROR (Status);
> 
> -  Status = BoardFunctionInit (BoardId);
> -  ASSERT_EFI_ERROR (Status);
> -
>    Status = BoardSecurityInit (BoardId);
>    ASSERT_EFI_ERROR (Status);
>  }
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/PeiWhiskeylakeURvpInitPreMemLib.c
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/PeiWhiskeylakeURvpInitPreMemLib.c
> index 75813ff351..69fed14c06 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board
> InitLib/PeiWhiskeylakeURvpInitPreMemLib.c
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa
> +++ rdInitLib/PeiWhiskeylakeURvpInitPreMemLib.c
> @@ -1,6 +1,6 @@
>  /** @file
> 
> -  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2019 - 2020, Intel Corporation. All rights
> + reserved.<BR>
>    SPDX-License-Identifier: BSD-2-Clause-Patent  **/
> 
> @@ -120,11 +120,6 @@ SaDisplayConfigInit (
>    IN UINT16 BoardId
>    );
> 
> -EFI_STATUS
> -BoardFunctionInitPreMem (
> -  IN UINT16 BoardId
> -  );
> -
>  EFI_STATUS
>  EFIAPI
>  PlatformInitPreMemCallBack (
> @@ -273,9 +268,6 @@ BoardConfigInitPreMem (
> 
>    Status = SaDisplayConfigInit (BoardId);
>    ASSERT_EFI_ERROR (Status);
> -
> -  Status = BoardFunctionInitPreMem (BoardId);
> -  ASSERT_EFI_ERROR (Status);
>  }
> 
>  /**
> --
> 2.19.1.windows.1


  reply	other threads:[~2020-02-27  2:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26  0:28 [edk2-platforms] [PATCH v4 0/4] Add Initial Support for UP Xtreme Agyeman, Prince
2020-02-26  0:28 ` [edk2-platforms] [PATCH v4 1/4] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove BoardFuncInit Agyeman, Prince
2020-02-27  2:18   ` Chiu, Chasel [this message]
2020-02-26  0:28 ` [edk2-platforms] [PATCH v4 2/4] WhiskeylakeOpenBoardPkg: Add UpXtreme board ID Agyeman, Prince
2020-02-27  2:19   ` [edk2-devel] " Chiu, Chasel
2020-02-26  0:28 ` [edk2-platforms] [PATCH v4 3/4] WhiskeylakeOpenBoardPkg/UpXtreme: Add Includes and Libraries Agyeman, Prince
2020-02-27  2:18   ` Chiu, Chasel
2020-02-26  0:28 ` [edk2-platforms] [PATCH v4 4/4] WhiskeylakeOpenBoardPkg/UpXtreme: Add DSC and build files Agyeman, Prince
2020-02-27  2:19   ` Chiu, Chasel
2020-02-27  3:13 ` [edk2-devel] [edk2-platforms] [PATCH v4 0/4] Add Initial Support for UP Xtreme Nate DeSimone
2020-02-27  7:26 ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C3EFB470A303B4AB093197B6777CCEC506ADA32@PGSMSX111.gar.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox