From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web09.7633.1582769935223912093 for ; Wed, 26 Feb 2020 18:18:55 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2020 18:18:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,490,1574150400"; d="scan'208";a="261280670" Received: from kmsmsx157.gar.corp.intel.com ([172.21.138.134]) by fmsmga004.fm.intel.com with ESMTP; 26 Feb 2020 18:18:53 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.103]) by kmsmsx157.gar.corp.intel.com ([169.254.5.222]) with mapi id 14.03.0439.000; Thu, 27 Feb 2020 10:18:52 +0800 From: "Chiu, Chasel" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH v4 1/4] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove BoardFuncInit Thread-Topic: [edk2-platforms] [PATCH v4 1/4] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove BoardFuncInit Thread-Index: AQHV7DuwYNQR/ZHEMk+uK3/SdTyBpaguT/dA Date: Thu, 27 Feb 2020 02:18:51 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC506ADA32@PGSMSX111.gar.corp.intel.com> References: <3e1e8f0cdf9ba13f62b4ab4aaa57f3ef6135b877.1582676457.git.prince.agyeman@intel.com> In-Reply-To: <3e1e8f0cdf9ba13f62b4ab4aaa57f3ef6135b877.1582676457.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjk5Zjg1NzAtNjI4NS00MmQ2LTk1YzctZGY4NTZkZGVjYjI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN2duaWxKRHBSNWw1U2REMGdYbUxBUlpJZk1QTHNRMjJadHZwa0FNZGc2Wk9QWW5OR3VXMTdFbUxJWnB1eEJZRyJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Agyeman, Prince > Sent: Wednesday, February 26, 2020 8:28 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH v4 1/4] > WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove BoardFuncInit >=20 > Removes BoardFuncInit related functionality in WhiskeylakeURvp. >=20 > Co-authored-by: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Prince Agyeman > --- > .../Library/BoardInitLib/BoardFunc.c | 19 ------------ > .../Library/BoardInitLib/BoardFunc.h | 20 ------------- > .../Library/BoardInitLib/BoardFuncInit.c | 26 ----------------- > .../BoardInitLib/BoardFuncInitPreMem.c | 29 +++++-------------- > .../BoardInitLib/BoardPchInitPreMemLib.c | 3 +- > .../PeiMultiBoardInitPostMemLib.inf | 4 --- > .../PeiWhiskeylakeURvpInitPostMemLib.c | 8 ----- > .../PeiWhiskeylakeURvpInitPreMemLib.c | 10 +------ > 8 files changed, 9 insertions(+), 110 deletions(-) delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardIni > tLib/BoardFunc.c > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardIni > tLib/BoardFunc.h > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardIni > tLib/BoardFuncInit.c >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardFunc.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardFunc.c > deleted file mode 100644 > index 7a2fed9904..0000000000 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardFunc.c > +++ /dev/null > @@ -1,19 +0,0 @@ > -/** @file > - Board's PCD function hook. > - > - > - Copyright (c) 2019, Intel Corporation. All rights reserved.
> - SPDX-License-Identifier: BSD-2-Clause-Patent -**/ > - > -#include > - > -EFI_STATUS > -PeiBoardSpecificInitPostMemNull ( > - VOID > - ) > -{ > - return EFI_SUCCESS; > -} > - > - > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardFunc.h > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardFunc.h > deleted file mode 100644 > index 9e0ff8d033..0000000000 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardFunc.h > +++ /dev/null > @@ -1,20 +0,0 @@ > -/** @file > - Header file for Board Hook function intance. > - > - > - Copyright (c) 2019, Intel Corporation. All rights reserved.
> - SPDX-License-Identifier: BSD-2-Clause-Patent -**/ > - > -#ifndef _BOARD_FUNC_H_ > -#define _BOARD_FUNC_H_ > - > -#include > - > -EFI_STATUS > -PeiBoardSpecificInitPostMemNull ( > - VOID > - ); > - > -#endif // _BOARD_FUNC_H_ > - > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardFuncInit.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardFuncInit.c > deleted file mode 100644 > index b8c69166ed..0000000000 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardFuncInit.c > +++ /dev/null > @@ -1,26 +0,0 @@ > -/** @file > - Source code for the board configuration init function in Post Memory i= nit > phase. > - > - > - Copyright (c) 2019, Intel Corporation. All rights reserved.
> - SPDX-License-Identifier: BSD-2-Clause-Patent -**/ > - > -#include "BoardFunc.h" > - > -/** > - Board's PCD function hook init function for PEI post memory phase. > - > - @param[in] BoardId An unsigned integrer represent the board id. > - > - @retval EFI_SUCCESS The function completed successfully. > -**/ > -EFI_STATUS > -BoardFunctionInit ( > - IN UINT16 BoardId > -) > -{ > - > - return EFI_SUCCESS; > -} > - > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardFuncInitPreMem.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardFuncInitPreMem.c > index 1944a02bf1..06ff64da8d 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardFuncInitPreMem.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdInitLib/BoardFuncInitPreMem.c > @@ -2,39 +2,24 @@ > Source code for the board configuration init function in Post Memory i= nit > phase. >=20 >=20 > - Copyright (c) 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2019 - 2020, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent **/ >=20 > #include > + > // > // Null function for nothing GOP VBT update. > // > VOID > -GopVbtSpecificUpdateNull( > +GopVbtSpecificUpdateNull ( > IN CHILD_STRUCT **ChildStructPtr > -); > + ); > + > // > // for CFL U DDR4 > // > VOID > -CflUDdr4GopVbtSpecificUpdate( > +CflUDdr4GopVbtSpecificUpdate ( > IN CHILD_STRUCT **ChildStructPtr > -); > -/** > - Board's PCD function hook init function for PEI post memory phase. > - > - @param[in] BoardId An unsigned integrer represent the board id. > - > - @retval EFI_SUCCESS The function completed successfully. > -**/ > -EFI_STATUS > -BoardFunctionInitPreMem ( > - IN UINT16 BoardId > - ) > -{ > - > - return EFI_SUCCESS; > -} > - > - > + ); > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardPchInitPreMemLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardPchInitPreMemLib.c > index 5305ec7f7c..1f778c4f7e 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/BoardPchInitPreMemLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdInitLib/BoardPchInitPreMemLib.c > @@ -2,7 +2,7 @@ > Source code for the board PCH configuration Pcd init functions for > Pre-Memory Init phase. >=20 >=20 > - Copyright (c) 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2019 - 2020, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent **/ >=20 > @@ -310,7 +310,6 @@ GpioGroupTierInit ( > // > // GPIO Group Tier > // > - > switch (BoardId) { > case BoardIdWhiskeyLakeRvp: > PcdSet32S (PcdGpioGroupToGpeDw0, GPIO_CNL_LP_GROUP_GPP_G); > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/PeiMultiBoardInitPostMemLib.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/PeiMultiBoardInitPostMemLib.inf > index 436314a6a3..845790209f 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/PeiMultiBoardInitPostMemLib.inf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdInitLib/PeiMultiBoardInitPostMemLib.inf > @@ -44,13 +44,9 @@ > [Sources] > PeiWhiskeylakeURvpInitPostMemLib.c > PeiMultiBoardInitPostMemLib.c > - BoardFunc.c > - BoardFuncInit.c > GpioTableDefault.c > GpioTableWhiskeylakeUDdr4Rvp.c >=20 > -[FixedPcd] > - > [Pcd] > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdBoardGpioTable > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdBoardGpioTableSize > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/PeiWhiskeylakeURvpInitPostMemLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/PeiWhiskeylakeURvpInitPostMemLib.c > index f704c42f2d..c61743acdc 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/PeiWhiskeylakeURvpInitPostMemLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdInitLib/PeiWhiskeylakeURvpInitPostMemLib.c > @@ -33,11 +33,6 @@ > #include "WhiskeylakeURvpInit.h" > #include >=20 > -EFI_STATUS > -BoardFunctionInit ( > - IN UINT16 BoardId > - ); > - > /** > GPIO init function for PEI post memory phase. >=20 > @@ -168,9 +163,6 @@ BoardConfigInit ( > Status =3D BoardMiscInit (BoardId); > ASSERT_EFI_ERROR (Status); >=20 > - Status =3D BoardFunctionInit (BoardId); > - ASSERT_EFI_ERROR (Status); > - > Status =3D BoardSecurityInit (BoardId); > ASSERT_EFI_ERROR (Status); > } > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/PeiWhiskeylakeURvpInitPreMemLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/PeiWhiskeylakeURvpInitPreMemLib.c > index 75813ff351..69fed14c06 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Board > InitLib/PeiWhiskeylakeURvpInitPreMemLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdInitLib/PeiWhiskeylakeURvpInitPreMemLib.c > @@ -1,6 +1,6 @@ > /** @file >=20 > - Copyright (c) 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2019 - 2020, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent **/ >=20 > @@ -120,11 +120,6 @@ SaDisplayConfigInit ( > IN UINT16 BoardId > ); >=20 > -EFI_STATUS > -BoardFunctionInitPreMem ( > - IN UINT16 BoardId > - ); > - > EFI_STATUS > EFIAPI > PlatformInitPreMemCallBack ( > @@ -273,9 +268,6 @@ BoardConfigInitPreMem ( >=20 > Status =3D SaDisplayConfigInit (BoardId); > ASSERT_EFI_ERROR (Status); > - > - Status =3D BoardFunctionInitPreMem (BoardId); > - ASSERT_EFI_ERROR (Status); > } >=20 > /** > -- > 2.19.1.windows.1